From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BC2D327798 for ; Mon, 22 Dec 2025 06:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766385652; cv=none; b=LaKEOzJb6LomV9DW3KIP5RIQ3xQQRf5Ub19DOn68fVF6XLsSejjc+jN7QuZCpDd9Y5stvA+ABKEbIlHI9e5YOI3ZDqo//nbmRizbzPfMtPNH0+jEtzCenaJ6pJk7dV3WREgejyJwG5bGP4zvNxpwG1dH3ZTtfLy8HxA5tZgDdlA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766385652; c=relaxed/simple; bh=rP6QYpytQMGZd27phGooY7RQP9NfnWfEWJfnoQtwV5o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z1WUECezmbtw8HxT3qGSkMPlsnsjvYAm6slZm/k8mTViV6SjPzNpZ7zqbPktoz9yj6CzYm+X3+E5h9jNctJqTS/lRMmCUglNfMPcTIX3pKITB1yx0XtjC7gGSjx0mczpbsTFdyURoQxffsCBX7cwikBPB6j8nlLujfbRlMz6U9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b0Jn6Ky/; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b0Jn6Ky/" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7b75e366866so1616587b3a.2 for ; Sun, 21 Dec 2025 22:40:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766385650; x=1766990450; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qPXWXbJD0J7h2WhDXKa99kJBcNS76iyn70zC5bGEQyw=; b=b0Jn6Ky/X4rvXqEbjfShioAN4mKGSHbcisJMGLewppkO4i7h2XI2BT2Tqk6hYP0+q9 VLjOzlskp7ESy75jMRyxGwmZKFfLy0sDz8bwzV1YqM9cB6O+A4octWn7mtCCbs86B4x9 H/3bWyc/5YxQn3UnVZSm5jMagkeWSBj6yVjPNLYT/Sx+aXuJdwGS/2HNvm3xcO1SDG+l nXAzaVPogGWeYmepWElpgPosdp3nYxw8fkG2xp9ErcQ7Za+SAJuNmeswAYRui9DokL9P vka79YiFhu1vYUBoZC46Eikqt4tRXxIRv/jTZx2AFcbBf2wAUFghCebl9KcpdpoILN2d 4EDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766385650; x=1766990450; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qPXWXbJD0J7h2WhDXKa99kJBcNS76iyn70zC5bGEQyw=; b=U7YlPWeHAktm8OGv8LfLQ7xQcQm2sPFw7sp2M9NsKQ0T1esPAMXSpCo97Dws4gptob 3sTSAHXjreZKFZaC41swHS8LKRLebMl0N3MXXeyUUKNb/brJQil253m2XgYTbuAw9FHm zr6BCeyuvqrOIqXw86OGP5aW1+cnTEO5eTo/X6KwPGH29Sn9i/QEszUQG9PCBM6hywm1 /cERTQJo6vY/yrAi00AxwrMhVG3sei7DSlaQzNw2Qim062iSQn+Yfu7u1gSBn1BL8eGM P6bGiKZUiFm/7DBMFJPWmNmI7poTvqU9ce4TxHWmpzNhU4+k6M3AuuNHPbsJG0qnZcIb TjnA== X-Forwarded-Encrypted: i=1; AJvYcCWKrgi0oNBqmuXy+rl55tsFE0/7Qvnm1FZqjlPDqDfwL/Jnp6o8DCAKv3gEECor3h9jkKYZo7kZwFkBxs8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxn0je22HgM1sDlDHPcczgxCeD4r6U5t89Mwi06DYiOr6ZAdIIh Tzlb6uhmuZ+Q69OXGBqZMbKaxIjmbGtxrIzz3iQYkM7Wn2iP1u2M9Ocy X-Gm-Gg: AY/fxX7qG5uo9m4pozTsmZeup0b9yR0RjVMnjX3Cv8gdjFW4Yjc3Y1ZPGJTr5Faaccr GfhtyQN9lkn0MpDdEZPqD2mWEwsPJKoAucB8z2CzFSGLozNauvHWFGMSDIgZ4rbGeoGGu+zKDRb 5yconX0xrpxDI1wr3WRuR+PnABMCs38XfSfgBxFO3cOu5MNexS0EFkJN8f1NrxoX+tK4GVN3g7T 4AhLfumDT9cJ/dB4CcNwQAjDjBaPgMQ2ozXFHJtws4v3RUcn3BO8XBJdjOjGNyAfm1BaW8fEQrg HofR74CRHqg4B/0a6Pfn0tRxTHcxnVlAAGIhprMjLruYnhAuhO+HGwWvgFOxC+yfXNWf8ztVD4s Wf/pd59SSRRQyWQRlD63nB8yrrMNrjUFOFKItsW84/23z6fPPEc1/tMvfmjvBp71DVbJgeRWdFx gZanxkNrMkdOALz7vYhGxdMAlnvr1sLsHGaAYhjblXDpUt X-Google-Smtp-Source: AGHT+IE62I9JyCTUp3ETxHws6VOOJR04P/KWDZqZ4yG8YBlKUZEaGLiVAdwx8Q1PoK8HXIjIa0sCkQ== X-Received: by 2002:aa7:9312:0:b0:7e8:43f5:bd56 with SMTP id d2e1a72fcca58-7ff6784e709mr7675977b3a.66.1766385650330; Sun, 21 Dec 2025 22:40:50 -0800 (PST) Received: from [172.16.20.12] ([136.226.245.27]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7dfac29bsm9215799b3a.39.2025.12.21.22.40.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Dec 2025 22:40:49 -0800 (PST) Message-ID: <90700087-7367-403c-97c5-81108a573aae@gmail.com> Date: Mon, 22 Dec 2025 12:11:17 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board To: Dmitry Baryshkov Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251201172222.3764933-1-tessolveupstream@gmail.com> <20251201172222.3764933-3-tessolveupstream@gmail.com> Content-Language: en-US From: tessolveupstream@gmail.com In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06-12-2025 04:51, Dmitry Baryshkov wrote: > On Mon, Dec 01, 2025 at 10:52:22PM +0530, Sudarshan Shetty wrote: >> Add the device tree for the QCS615-based Talos EVK platform. The >> platform is composed of a System-on-Module following the SMARC >> standard, and a Carrier Board. >> >> The Carrier Board supports several display configurations, HDMI and >> LVDS. Both configurations use the same base hardware, with the display >> selection controlled by a DIP switch. >> >> Use a DTBO file, talos-evk-lvds-auo,g133han01.dtso, which defines an >> overlay that disables HDMI and adds LVDS. The DTs file talos-evk >> can describe the HDMI display configurations. >> >> The initial device tree includes support for: >> - CPU and memory >> - UART >> - GPIOs >> - Regulators >> - PMIC >> - Early console >> - AT24MAC602 EEPROM >> - MCP2515 SPI to CAN >> - ADV7535 DSI-to-HDMI bridge >> - DisplayPort interface >> >> Signed-off-by: Sudarshan Shetty >> --- >> arch/arm64/boot/dts/qcom/Makefile | 3 + >> .../qcom/talos-evk-lvds-auo,g133han01.dtso | 131 +++++ >> arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 447 ++++++++++++++++++ >> arch/arm64/boot/dts/qcom/talos-evk.dts | 137 ++++++ >> 4 files changed, 718 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso >> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi >> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index 5b52f9e4e5f3..94c20074397c 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -305,6 +305,9 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-mtp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb >> +talos-evk-lvds-auo,g133han01-dtbs := talos-evk.dtb talos-evk-lvds-auo,g133han01.dtbo >> +dtb-$(CONFIG_ARCH_QCOM) += talos-evk-lvds-auo,g133han01.dtb >> x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo >> dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb >> x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtbo >> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso b/arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso >> new file mode 100644 >> index 000000000000..2a90d61892e7 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso >> @@ -0,0 +1,131 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> +/dts-v1/; >> +/plugin/; >> + >> +#include >> + >> +&{/} { >> + backlight: backlight { >> + compatible = "gpio-backlight"; >> + gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>; >> + default-on; >> + }; >> + >> + hdmi-out { >> + status = "disabled"; >> + }; >> + >> + lcd-pwm-en { >> + compatible = "gpio-backlight"; >> + gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>; >> + default-on; >> + }; > > I really don't like the idea of describing two separate backlight > devices here. We have a single backlight on the panel, controlled by two > GPIOs. I think, using GPIO instead of a PWM is a sensible enough usecase > to let DT use two GPIOs in gpio-backlight (with corresponding changes to > the bindings and the driver). > Okay, will take care in the next patch. >> + >> + panel-lvds { >> + compatible = "auo,g133han01"; > > backlight = <&backlight>; > >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + /* LVDS A (Odd pixels) */ >> + port@0 { >> + reg = <0>; >> + dual-lvds-odd-pixels; >> + >> + lvds_panel_out_a: endpoint { >> + remote-endpoint = <&sn65dsi84_out_a>; >> + }; >> + }; >> + >> + /* LVDS B (Even pixels) */ >> + port@1 { >> + reg = <1>; >> + dual-lvds-even-pixels; >> + >> + lvds_panel_out_b: endpoint { >> + remote-endpoint = <&sn65dsi84_out_b>; >> + }; >> + }; >> + }; >> + }; >> +}; >> + >