From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8288C43465 for ; Mon, 21 Sep 2020 16:16:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7458120739 for ; Mon, 21 Sep 2020 16:16:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bFr/8F0r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728201AbgIUQQ3 (ORCPT ); Mon, 21 Sep 2020 12:16:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727557AbgIUQQ2 (ORCPT ); Mon, 21 Sep 2020 12:16:28 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72EB4C061755 for ; Mon, 21 Sep 2020 09:16:28 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id w2so94903wmi.1 for ; Mon, 21 Sep 2020 09:16:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=htPCe9d3Pa34TUPhjBFaGH8jRG+GS7pqXbTfR7z8+ow=; b=bFr/8F0r8SQESPG+ae54M5kO3y6FJPn/zwCLYrMQZraawA77/OO7/q6mgP3wWpVDC3 c/SeKw1k9YRMjOTs612ls6tyHIFP/czLpsQ5AP27Ju3iQglx2JTIU/RDTOmsCbRbVDEL kIqS6kj41Y1rnt0GJlu8gKKtRxLpOmfzifKg7CANEf4OoZ4qExU17GLLr2PKmThEhgwt OQrzNZNm4kaQi7P5Z3/NqMPH3xbUl+CeSWtdWInpuHpt0Hl7LlNk+Vb+N9Hjf/ITfd3+ bMfQzlziZuc5U2m2ddQfl1+c8svX1aF1+zP9mY2081/UqiWS+1TWOcGour0yfJxlhbK0 sfJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=htPCe9d3Pa34TUPhjBFaGH8jRG+GS7pqXbTfR7z8+ow=; b=jiuJHmbluqOnC4OCponqhpgwJT9i0kOJ8pPvU/6HmyPSTubevUP8La43ESVgkhxzew n/0wp0ctg+UGRAX4N73/u+oEGykzBSlhS7aHPQ53z/WT+0gTTAHtqbwrGymeqa/FMVRR puoRzXvWrJXAGh1MjIefuVRAsZoQR0yAbqKbVRqs5hrIPkfJrpYzlNdIrN3kTyIAA8SZ 7KWbq/uBD1nhRDcZgyDjqo4KYfQCxQWnPziO5X80WN0OPT4EdKwLrK3/HfkFNQ2z3/WH kVkzWmI8plx+T1CoNbg9Scs9DIZGxftZoHKvTbw+j2nzWL3UlSLTh1aTwkXIHbG7YC0J keQA== X-Gm-Message-State: AOAM530CWrj9Ane78wim8dCOl8Nx8xWTOwOwijxAJnna4UVIeWbqzXNc lPlko0mRrVoHPGxkYG/tHEQ= X-Google-Smtp-Source: ABdhPJwROwWW5Cd9tMiIlzNGJ1RQLMos0xb80a01XNW5a03Lm1yduKnwbtLNjxfaN/pF20k1d7GARg== X-Received: by 2002:a1c:4886:: with SMTP id v128mr118594wma.139.1600704987151; Mon, 21 Sep 2020 09:16:27 -0700 (PDT) Received: from ziggy.stardust ([213.195.113.201]) by smtp.gmail.com with ESMTPSA id m18sm71951wmg.32.2020.09.21.09.16.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Sep 2020 09:16:26 -0700 (PDT) Subject: Re: [PATCH v3 6/9] soc: mediatek: cmdq: add write_s_mask value function To: Dennis YC Hsieh , Philipp Zabel , David Airlie , Daniel Vetter , CK Hu , Bibby Hsieh , Houlong Wei Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, wsd_upstream@mediatek.com, HS Liao References: <1594136714-11650-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1594136714-11650-7-git-send-email-dennis-yc.hsieh@mediatek.com> From: Matthias Brugger Message-ID: <9073ff83-ad99-8e40-e25e-360df74435fd@gmail.com> Date: Mon, 21 Sep 2020 18:16:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1594136714-11650-7-git-send-email-dennis-yc.hsieh@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/07/2020 17:45, Dennis YC Hsieh wrote: > add write_s_mask_value function in cmdq helper functions which > writes a constant value to address with mask and large dma > access support. > > Signed-off-by: Dennis YC Hsieh Now pushed to v5.9-next/soc Thanks! > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 21 +++++++++++++++++++++ > include/linux/soc/mediatek/mtk-cmdq.h | 15 +++++++++++++++ > 2 files changed, 36 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 4e86b65815fc..b6e25f216605 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -294,6 +294,27 @@ int cmdq_pkt_write_s_value(struct cmdq_pkt *pkt, u8 high_addr_reg_idx, > } > EXPORT_SYMBOL(cmdq_pkt_write_s_value); > > +int cmdq_pkt_write_s_mask_value(struct cmdq_pkt *pkt, u8 high_addr_reg_idx, > + u16 addr_low, u32 value, u32 mask) > +{ > + struct cmdq_instruction inst = {}; > + int err; > + > + inst.op = CMDQ_CODE_MASK; > + inst.mask = ~mask; > + err = cmdq_pkt_append_command(pkt, inst); > + if (err < 0) > + return err; > + > + inst.op = CMDQ_CODE_WRITE_S_MASK; > + inst.sop = high_addr_reg_idx; > + inst.offset = addr_low; > + inst.value = value; > + > + return cmdq_pkt_append_command(pkt, inst); > +} > +EXPORT_SYMBOL(cmdq_pkt_write_s_mask_value); > + > int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event) > { > struct cmdq_instruction inst = { {0} }; > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > index ae73e10da274..d9390d76ee14 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -165,6 +165,21 @@ int cmdq_pkt_write_s_value(struct cmdq_pkt *pkt, u8 high_addr_reg_idx, > u16 addr_low, u32 value); > > /** > + * cmdq_pkt_write_s_mask_value() - append write_s command with mask to the CMDQ > + * packet which write value to a physical > + * address > + * @pkt: the CMDQ packet > + * @high_addr_reg_idx: internal register ID which contains high address of pa > + * @addr_low: low address of pa > + * @value: the specified target value > + * @mask: the specified target mask > + * > + * Return: 0 for success; else the error code is returned > + */ > +int cmdq_pkt_write_s_mask_value(struct cmdq_pkt *pkt, u8 high_addr_reg_idx, > + u16 addr_low, u32 value, u32 mask); > + > +/** > * cmdq_pkt_wfe() - append wait for event command to the CMDQ packet > * @pkt: the CMDQ packet > * @event: the desired event type to "wait and CLEAR" >