public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wen Xiong <wenxiong@linux.ibm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, gjoyce@linux.ibm.com
Subject: Re: [PATCH 1/1] genirq/msi: Dynamic remove/add stroage adapter hits EEH
Date: Wed, 19 Mar 2025 21:58:54 -0500	[thread overview]
Message-ID: <90777da90abe02c87d30968bfedc9168@linux.ibm.com> (raw)
In-Reply-To: <87a59h3sk9.ffs@tglx>

> The real problem has nothing to do with a remove/add operation. The
> problem is solely in the probe function.

Hi Thomas,
Thanks for your suggestion!

I don't think we have problems in probe function since this driver has 
been in productions for many many years.
Also we didn't see the issue before the "MSI domain" patchset dropping 
into linux interrupt code(no issue in rhel92 release).

Device reset is not called in probe function. We don't see the issue 
without dynamically remove/add operation.
There is a small window which irqbalance daemon kicks in during device 
reset. So it took about over 6 hours to recreate the issue when doing 
remove/add loop operation.

We can't find the good way to fix the issue in both of device drivers. 
So we look for some help in interrupt code.

Looks each irq_data has a state(IRQD_AFFINITY_MANAGED), Can we play this 
flag during the reset in device driver?

* IRQD_NO_BALANCING        - Balancing disabled for this IRQ
* IRQD_AFFINITY_ON_ACTIVATE    - Affinity is set on activation. Don't
                    call irq_chip::irq_set_affinity() when deactivated.

OR
If we registered an affinity notifier in device driver, can this tell us 
the msix vector has been clear to 0 when irqbalance daemon kicks in?

Thank you so much, I really appreciate any suggestion/help!
Wendy


  reply	other threads:[~2025-03-20  2:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-19 12:14 [PATCH 1/1] genirq/msi: Dynamic remove/add stroage adapter hits EEH wenxiong
2025-03-19 16:15 ` Thomas Gleixner
2025-03-20  2:58   ` Wen Xiong [this message]
2025-03-20  8:23     ` Thomas Gleixner
2025-03-20  8:48       ` Thomas Gleixner
2025-03-27 21:36         ` Wen Xiong
2025-03-28 11:27           ` Thomas Gleixner
2025-04-01 20:14             ` Wen Xiong
2025-04-02  8:33               ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90777da90abe02c87d30968bfedc9168@linux.ibm.com \
    --to=wenxiong@linux.ibm.com \
    --cc=gjoyce@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox