public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fenghua Yu <fenghua.yu@intel.com>
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: Reinette Chatre <reinette.chatre@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>,
	"D Scott Phillips OS" <scott@os.amperecomputing.com>,
	<carl@os.amperecomputing.com>, <lcherian@marvell.com>,
	<bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
	<xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
	Jamie Iles <quic_jiles@quicinc.com>,
	Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
	<dfustini@baylibre.com>, <amitsinght@marvell.com>
Subject: Re: [PATCH v6 01/24] tick/nohz: Move tick_nohz_full_mask declaration outside the #ifdef
Date: Tue, 26 Sep 2023 07:31:04 -0700	[thread overview]
Message-ID: <908ce024-db79-ecb0-c47a-626227038411@intel.com> (raw)
In-Reply-To: <20230914172138.11977-2-james.morse@arm.com>

Hi, Peter and James,

On 9/14/23 10:21, James Morse wrote:
> tick_nohz_full_mask lists the CPUs that are nohz_full. This is only
> needed when CONFIG_NO_HZ_FULL is defined. tick_nohz_full_cpu() allows
> a specific CPU to be tested against the mask, and evaluates to false
> when CONFIG_NO_HZ_FULL is not defined.
> 
> The resctrl code needs to pick a CPU to run some work on, a new helper
> prefers housekeeping CPUs by examining the tick_nohz_full_mask. Hiding
> the declaration behind #ifdef CONFIG_NO_HZ_FULL forces all the users to
> be behind an ifdef too.
> 
> Move the tick_nohz_full_mask declaration, this lets callers drop the
> ifdef, and guard access to tick_nohz_full_mask with IS_ENABLED() or
> something like tick_nohz_full_cpu().
> 
> The definition does not need to be moved as any callers should be
> removed at compile time unless CONFIG_NO_HZ_FULL is defined.
> 
> CC: Frederic Weisbecker <frederic@kernel.org>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>

checkpatch.pl reports warning:
WARNING: 'Tested-by:' is the preferred signature form
#27:
Tested-By: Peter Newman <peternewman@google.com>

The same warning is reported on all following patches in this series.

According to Documentation/process/submitting-patches.rst, "Tested-by" 
(instead of "Tested-By") is used.

Could you please fix the warnings?

Thanks.

-Fenghua

  reply	other threads:[~2023-09-26 14:31 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14 17:21 [PATCH v6 00/24] x86/resctrl: monitored closid+rmid together, separate arch/fs locking James Morse
2023-09-14 17:21 ` [PATCH v6 01/24] tick/nohz: Move tick_nohz_full_mask declaration outside the #ifdef James Morse
2023-09-26 14:31   ` Fenghua Yu [this message]
2023-10-03 21:05   ` Reinette Chatre
2023-09-14 17:21 ` [PATCH v6 02/24] x86/resctrl: kfree() rmid_ptrs from rdtgroup_exit() James Morse
2023-10-02 17:00   ` Reinette Chatre
2023-10-05 17:05     ` James Morse
2023-10-05 18:04       ` Reinette Chatre
2023-10-25 17:56         ` James Morse
2023-10-04 18:00   ` Moger, Babu
2023-10-05 17:06     ` James Morse
2023-09-14 17:21 ` [PATCH v6 03/24] x86/resctrl: Create helper for RMID allocation and mondata dir creation James Morse
2023-10-03 21:07   ` Reinette Chatre
2023-09-14 17:21 ` [PATCH v6 04/24] x86/resctrl: Move rmid allocation out of mkdir_rdt_prepare() James Morse
2023-10-03 21:07   ` Reinette Chatre
2023-10-04 18:01   ` Moger, Babu
2023-10-05 17:06     ` James Morse
2023-09-14 17:21 ` [PATCH v6 05/24] x86/resctrl: Track the closid with the rmid James Morse
2023-10-03 21:11   ` Reinette Chatre
2023-09-14 17:21 ` [PATCH v6 06/24] x86/resctrl: Access per-rmid structures by index James Morse
2023-10-03 21:12   ` Reinette Chatre
2023-10-24  9:28   ` Maciej Wieczór-Retman
2023-09-14 17:21 ` [PATCH v6 07/24] x86/resctrl: Allow RMID allocation to be scoped by CLOSID James Morse
2023-10-03 21:12   ` Reinette Chatre
2023-09-14 17:21 ` [PATCH v6 08/24] x86/resctrl: Track the number of dirty RMID a CLOSID has James Morse
2023-10-03 21:13   ` Reinette Chatre
2023-10-05 17:07     ` James Morse
2023-09-14 17:21 ` [PATCH v6 09/24] x86/resctrl: Use set_bit()/clear_bit() instead of open coding James Morse
2023-09-17 21:00   ` David Laight
2023-09-29 16:13     ` James Morse
2023-10-03 21:14   ` Reinette Chatre
2023-10-04 20:38   ` Moger, Babu
2023-10-05 17:07     ` James Morse
2023-09-14 17:21 ` [PATCH v6 10/24] x86/resctrl: Allocate the cleanest CLOSID by searching closid_num_dirty_rmid James Morse
2023-10-03 21:14   ` Reinette Chatre
2023-10-05 20:13   ` Moger, Babu
2023-10-25 17:56     ` James Morse
2023-10-05 20:26   ` Moger, Babu
2023-10-25 17:56     ` James Morse
2023-10-24 12:06   ` Maciej Wieczór-Retman
2023-09-14 17:21 ` [PATCH v6 11/24] x86/resctrl: Move CLOSID/RMID matching and setting to use helpers James Morse
2023-10-03 21:15   ` Reinette Chatre
2023-09-14 17:21 ` [PATCH v6 12/24] x86/resctrl: Add cpumask_any_housekeeping() for limbo/overflow James Morse
2023-10-03 21:15   ` Reinette Chatre
2023-10-05 17:07     ` James Morse
2023-09-14 17:21 ` [PATCH v6 13/24] x86/resctrl: Queue mon_event_read() instead of sending an IPI James Morse
2023-10-03 21:17   ` Reinette Chatre
2023-10-25 17:56     ` James Morse
2023-09-14 17:21 ` [PATCH v6 14/24] x86/resctrl: Allow resctrl_arch_rmid_read() to sleep James Morse
2023-10-03 21:18   ` Reinette Chatre
2023-10-25 17:57     ` James Morse
2023-10-05 21:33   ` Moger, Babu
2023-09-14 17:21 ` [PATCH v6 15/24] x86/resctrl: Allow arch to allocate memory needed in resctrl_arch_rmid_read() James Morse
2023-10-03 21:18   ` Reinette Chatre
2023-10-05 21:46   ` Moger, Babu
2023-10-25 17:58     ` James Morse
2023-09-14 17:21 ` [PATCH v6 16/24] x86/resctrl: Make resctrl_mounted checks explicit James Morse
2023-10-03 21:19   ` Reinette Chatre
2023-09-14 17:21 ` [PATCH v6 17/24] x86/resctrl: Move alloc/mon static keys into helpers James Morse
2023-10-03 21:19   ` Reinette Chatre
2023-09-14 17:21 ` [PATCH v6 18/24] x86/resctrl: Make rdt_enable_key the arch's decision to switch James Morse
2023-10-03 21:19   ` Reinette Chatre
2023-09-14 17:21 ` [PATCH v6 19/24] x86/resctrl: Add helpers for system wide mon/alloc capable James Morse
2023-10-03 21:19   ` Reinette Chatre
2023-09-14 17:21 ` [PATCH v6 20/24] x86/resctrl: Add CPU online callback for resctrl work James Morse
2023-10-03 21:20   ` Reinette Chatre
2023-09-14 17:21 ` [PATCH v6 21/24] x86/resctrl: Allow overflow/limbo handlers to be scheduled on any-but cpu James Morse
2023-10-03 21:22   ` Reinette Chatre
2023-10-25 17:57     ` James Morse
2023-10-27 21:20       ` Reinette Chatre
2023-09-14 17:21 ` [PATCH v6 22/24] x86/resctrl: Add cpu offline callback for resctrl work James Morse
2023-10-03 21:23   ` Reinette Chatre
2023-10-25 17:57     ` James Morse
2023-09-14 17:21 ` [PATCH v6 23/24] x86/resctrl: Move domain helper migration into resctrl_offline_cpu() James Morse
2023-10-03 21:23   ` Reinette Chatre
2023-09-14 17:21 ` [PATCH v6 24/24] x86/resctrl: Separate arch and fs resctrl locks James Morse
2023-10-03 21:28   ` Reinette Chatre
2023-10-25 17:55     ` James Morse
2023-09-27  7:38 ` [PATCH v6 00/24] x86/resctrl: monitored closid+rmid together, separate arch/fs locking Shaopeng Tan (Fujitsu)
2023-09-29 16:13   ` James Morse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=908ce024-db79-ecb0-c47a-626227038411@intel.com \
    --to=fenghua.yu@intel.com \
    --cc=Babu.Moger@amd.com \
    --cc=amitsinght@marvell.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=bobo.shaobowang@huawei.com \
    --cc=bp@alien8.de \
    --cc=carl@os.amperecomputing.com \
    --cc=dfustini@baylibre.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=lcherian@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peternewman@google.com \
    --cc=quic_jiles@quicinc.com \
    --cc=reinette.chatre@intel.com \
    --cc=scott@os.amperecomputing.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=tan.shaopeng@fujitsu.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xhao@linux.alibaba.com \
    --cc=xingxin.hx@openanolis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox