Re: [PATCH 0/2] Add support for QC08C format in iris driver

Neil Armstrong
2025-10-01T08:39:10Z

Hi,

On 9/19/25 17:47, Dikshita Agarwal wrote:
> Add support for the QC08C color format in both the encoder and decoder
> paths of the iris driver. The changes include:
>
> - Adding QC08C format handling in the driver for both encoding and
> decoding.
> - Updating format enumeration to properly return supported formats.
> - Ensuring the correct HFI format is set for firmware communication.
> -Making all related changes required for seamless integration of QC08C
> support.
>
> The changes have been validated using v4l2-ctl, compliance, and GStreamer (GST) tests.
> Both GST and v4l2-ctl tests were performed using the NV12 format, as
> these clients do not support the QCOM-specific QC08C format, and all
> tests passed successfully.

Sorry but this means you didn't test the full decoding and encoding with GST and v4l2-ctl using QC08C ?
So how did you test ?

Thanks,
Neil

>
> During v4l2-ctl testing, a regression was observed when using the NV12
> color format after adding QC08C support. A fix for this regression has
> also been posted [1].
>
> [1]: https://lore.kernel.org/linux-media/20250918103235.4066441-1-dikshita.agarwal@oss.qualcomm.com/T/#u
>
> Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
> ---
> Dikshita Agarwal (2):
> media: iris: Add support for QC08C format for decoder
> media: iris: Add support for QC08C format for encoder
>
> drivers/media/platform/qcom/iris/iris_buffer.c | 17 ++++--
> .../platform/qcom/iris/iris_hfi_gen1_command.c | 15 ++++--
> .../platform/qcom/iris/iris_hfi_gen2_command.c | 21 +++++++-
> .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 +
> drivers/media/platform/qcom/iris/iris_instance.h | 7 ++-
> .../media/platform/qcom/iris/iris_platform_gen2.c | 1 +
> drivers/media/platform/qcom/iris/iris_utils.c | 3 +-
> drivers/media/platform/qcom/iris/iris_vdec.c | 61 ++++++++++++++++++----
> drivers/media/platform/qcom/iris/iris_venc.c | 59 +++++++++++++++++----
> 9 files changed, 152 insertions(+), 33 deletions(-)
> ---
> base-commit: 40b7a19f321e65789612ebaca966472055dab48c
> change-id: 20250918-video-iris-ubwc-enable-87eac6f41fa4
>
> Best regards,