Re: [PATCH 0/2] Add support for QC08C format in iris driver

Nicolas Dufresne
2025-10-01T13:48:00Z

[-- Attachment #1: Type: text/plain, Size: 3264 bytes --]

Hi,

Le mercredi 01 octobre 2025 à 10:39 +0200, Neil Armstrong a écrit :
> Hi,
>
> On 9/19/25 17:47, Dikshita Agarwal wrote:
> > Add support for the QC08C color format in both the encoder and decoder
> > paths of the iris driver. The changes include:
> >
> > - Adding QC08C format handling in the driver for both encoding and
> > decoding.
> > - Updating format enumeration to properly return supported formats.
> > - Ensuring the correct HFI format is set for firmware communication.
> > -Making all related changes required for seamless integration of QC08C
> > support.
> >
> > The changes have been validated using v4l2-ctl, compliance, and GStreamer
> > (GST) tests.
> > Both GST and v4l2-ctl tests were performed using the NV12 format, as
> > these clients do not support the QCOM-specific QC08C format, and all
> > tests passed successfully.
>
> Sorry but this means you didn't test the full decoding and encoding with GST
> and v4l2-ctl using QC08C ?
> So how did you test ?

We've made addition of V4L2/DRM format mapping trivial lately in GStreamer. So
trivial, that my colleague Robert Mader made the changes for you, and this
change is just waiting for someone with the hardware to test.

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8195

With that you can visually test it by rendering through OpenGL or your display
controller if supported. This gives option to use glimagesink, waylandsink, and
possibly kmssink, but not sure for the later.

What would need to work harder would be fluster testing. Going through GL will
mean converting from YUV to RGB back to YUV, which can damage the pictures
slightly, resulting in different MD5.

regards,
Nicolas

>
> Thanks,
> Neil
>
> >
> > During v4l2-ctl testing, a regression was observed when using the NV12
> > color format after adding QC08C support. A fix for this regression has
> > also been posted [1].
> >
> > [1]:
> > https://lore.kernel.org/linux-media/20250918103235.4066441-1-dikshita.agarwal@oss.qualcomm.com/T/#u
> >
> > Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
> > ---
> > Dikshita Agarwal (2):
> >        media: iris: Add support for QC08C format for decoder
> >        media: iris: Add support for QC08C format for encoder
> >
> >   drivers/media/platform/qcom/iris/iris_buffer.c     | 17 ++++--
> >   .../platform/qcom/iris/iris_hfi_gen1_command.c     | 15 ++++--
> >   .../platform/qcom/iris/iris_hfi_gen2_command.c     | 21 +++++++-
> >   .../platform/qcom/iris/iris_hfi_gen2_defines.h     |  1 +
> >   drivers/media/platform/qcom/iris/iris_instance.h   |  7 ++-
> >   .../media/platform/qcom/iris/iris_platform_gen2.c  |  1 +
> >   drivers/media/platform/qcom/iris/iris_utils.c      |  3 +-
> >   drivers/media/platform/qcom/iris/iris_vdec.c       | 61
> > ++++++++++++++++++----
> >   drivers/media/platform/qcom/iris/iris_venc.c       | 59 +++++++++++++++++-
> > ---
> >   9 files changed, 152 insertions(+), 33 deletions(-)
> > ---
> > base-commit: 40b7a19f321e65789612ebaca966472055dab48c
> > change-id: 20250918-video-iris-ubwc-enable-87eac6f41fa4
> >
> > Best regards,
>

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]