Re: [PATCH 1/2] media: iris: Add support for QC08C format for decoder

Dikshita Agarwal
2025-10-01T08:24:10Z

On 9/24/2025 9:53 PM, Dmitry Baryshkov wrote:
> On Wed, Sep 24, 2025 at 04:24:07PM +0530, Dikshita Agarwal wrote:
>>
>>
>> On 9/19/2025 10:24 PM, Dmitry Baryshkov wrote:
>>> On Fri, Sep 19, 2025 at 09:17:16PM +0530, Dikshita Agarwal wrote:
>>>> Introduce handling for the QC08C format in the decoder.
>>>> Update format checks and configuration to enable decoding of QC08C
>>>> streams.
>>>
>>> What is QC08C? Is it supported on all devices?
>>
>> It's qualcomm specific compressed format, it's defined here
>> https://elixir.bootlin.com/linux/v6.17-rc2/source/include/uapi/linux/videodev2.h#L820
>>
>> And Yes, it's supported on all Qualcomm devices supported by iris driver.
>
> Is it going to be supported by all platforms that are going to be
> migrated from Venus to Iris?

Yes, for all hardware which supports UBWC.

>
> Is it just NV12 + UBWC or something else?

Yes it's NV12 + UBWC compression.

>
>>
>>>
>>>>
>>>> Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
>>>> ---
>>>> drivers/media/platform/qcom/iris/iris_buffer.c | 5 +-
>>>> .../platform/qcom/iris/iris_hfi_gen1_command.c | 12 +++--
>>>> .../platform/qcom/iris/iris_hfi_gen2_command.c | 18 ++++++-
>>>> .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 +
>>>> drivers/media/platform/qcom/iris/iris_instance.h | 7 ++-
>>>> .../media/platform/qcom/iris/iris_platform_gen2.c | 1 +
>>>> drivers/media/platform/qcom/iris/iris_utils.c | 3 +-
>>>> drivers/media/platform/qcom/iris/iris_vdec.c | 61 ++++++++++++++++++----
>>>> 8 files changed, 89 insertions(+), 19 deletions(-)
>>>>
>>>> diff --git a/drivers/media/platform/qcom/iris/iris_instance.h b/drivers/media/platform/qcom/iris/iris_instance.h
>>>> index 5982d7adefeab80905478b32cddba7bd4651a691..11134f75c26dd1f6c92ba72fbf4e56e41a72de64 100644
>>>> --- a/drivers/media/platform/qcom/iris/iris_instance.h
>>>> +++ b/drivers/media/platform/qcom/iris/iris_instance.h
>>>> @@ -15,12 +15,17 @@
>>>> #define DEFAULT_WIDTH 320
>>>> #define DEFAULT_HEIGHT 240
>>>>
>>>> -enum iris_fmt_type {
>>>> +enum iris_fmt_type_out {
>>>> IRIS_FMT_H264,
>>>> IRIS_FMT_HEVC,
>>>> IRIS_FMT_VP9,
>>>> };
>>>>
>>>> +enum iris_fmt_type_cap {
>>>> + IRIS_FMT_NV12,
>>>> + IRIS_FMT_UBWC,
>>>
>>> UBWC is not a format on its own, it's a modifier of the format. Please
>>> come up with a better naming.
>>
>> Sure, will rename this to IRIS_FMT_QC08C inline with v4l2 definition.
>
> Ack.
>
>