Re: [PATCH 1/2] media: iris: Add support for QC08C format for decoder

Bryan O'Donoghue
2025-10-01T15:04:34Z

On 01/10/2025 09:36, Neil Armstrong wrote:
> On 9/24/25 15:28, Bryan O'Donoghue wrote:
>> On 19/09/2025 16:47, Dikshita Agarwal wrote:
>>> Introduce handling for the QC08C format in the decoder.
>>> Update format checks and configuration to enable decoding of QC08C
>>> streams.
>>
>> Since QC08C is a Qualcomm specific pixel format, you should detail in your commit log exactly what the packing/ordering of pixels is.
>>
>> In other words tell the reader more about QC08C.
>
> This has been upstreamed 3y ago for venus, which is the same as iris:
> https://lore.kernel.org/all/20220117155559.234026-1-stanimir.varbanov@linaro.org/
>
> No need to re-explain it for iris, the format is the same.
>
> Neil
Yeah no, at a minimum the explanation of NV12 + UBWC should appear in
the commit log for this format.

thx
---
bod