From: Thorsten Blum <thorsten.blum@linux.dev>
To: Eric Biggers <ebiggers@kernel.org>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/crypto: blake2b: Limit frame size workaround to GCC < 12.2 on i386
Date: Sun, 23 Nov 2025 00:23:02 +0100 [thread overview]
Message-ID: <90EF627D-97C7-4CE2-B5CD-80000567F361@linux.dev> (raw)
In-Reply-To: <20251122200402.GD5803@quark>
On 22. Nov 2025, at 21:04, Eric Biggers wrote:
> On Sat, Nov 22, 2025 at 11:55:31AM +0100, Thorsten Blum wrote:
>> The GCC bug only occurred on i386 and has been resolved since GCC 12.2.
>> Limit the frame size workaround to GCC < 12.2 on i386.
>>
>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>> ---
>> [...]
>
> How about we do it without the nested ifeq?
>
> ifeq ($(CONFIG_X86_32)$(CONFIG_CC_IS_GCC)_$(call gcc-min-version, 120200),yy_)
> CFLAGS_blake2b.o := -Wframe-larger-than=4096 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105930
> endif
I considered it and went with the nested ifeq, but I'm fine with both.
> Also, according to the bugreport this was a regression in gcc 12. With
> it having been fixed in 12.2, i.e. within the same gcc release series,
> is this workaround still worth carrying at all?
Not sure - gcc 8.1.0 is still the min version supported by the kernel.
Thorsten
next prev parent reply other threads:[~2025-11-22 23:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-22 10:55 [PATCH] lib/crypto: blake2b: Limit frame size workaround to GCC < 12.2 on i386 Thorsten Blum
2025-11-22 20:04 ` Eric Biggers
2025-11-22 23:23 ` Thorsten Blum [this message]
2025-11-23 1:55 ` kernel test robot
2025-11-23 9:28 ` david laight
2025-11-23 17:00 ` Thorsten Blum
2025-11-23 18:58 ` david laight
2025-11-23 20:26 ` Eric Biggers
2025-11-24 9:08 ` david laight
2025-11-24 17:14 ` Jason A. Donenfeld
2025-11-24 22:40 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90EF627D-97C7-4CE2-B5CD-80000567F361@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox