From: Markus Elfring <Markus.Elfring@web.de>
To: Bernard Zhao <bernard@vivo.com>,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, opensource.kernel@vivo.com,
Krzysztof Kozlowski <krzk@kernel.org>,
Kukjin Kim <kgene@kernel.org>, Lukasz Luba <lukasz.luba@arm.com>
Subject: Re: [PATCH] memory/samsung: reduce unnecessary mutex lock area
Date: Fri, 8 May 2020 20:27:21 +0200 [thread overview]
Message-ID: <90c5ceac-c3dc-3811-a763-bd89173bb2c2@web.de> (raw)
> Maybe dmc->df->lock is unnecessary to protect function
> exynos5_dmc_perf_events_check(dmc). If we have to protect,
> dmc->lock is more better and more effective.
> Also, it seems not needed to protect "if (ret) & dev_warn"
> branch.
I suggest to improve also this commit message.
* Please reduce uncertainty.
* An imperative wording is probably preferred, isn't it?
* Will it be more appropriate to refer to the action “Reduce the lock scope”?
* Would you like to add the tag “Fixes” to the change description?
Regards,
Markus
next reply other threads:[~2020-05-08 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 18:27 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-08 13:13 [PATCH] memory/samsung: reduce unnecessary mutex lock area Bernard Zhao
2020-05-12 6:50 ` Krzysztof Kozlowski
2020-05-12 8:47 ` Lukasz Luba
2020-05-12 9:05 ` Krzysztof Kozlowski
2020-05-12 9:23 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90c5ceac-c3dc-3811-a763-bd89173bb2c2@web.de \
--to=markus.elfring@web.de \
--cc=bernard@vivo.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox