Re: [PATCH v2 5/6] interconnect: qcom: sdm845: Split qnodes into their respective NoCs

Evan Green
2020-02-04T18:22:12Z

On Thu, Jan 9, 2020 at 8:33 PM David Dai <daidavid1@codeaurora.org> wrote:
>
> In order to better represent the hardware and its different Network-On-Chip
> devices, split the sdm845 provider driver into NoC specific providers.
> Remove duplicate functionality already provided by the icc rpmh and
> bcm voter drivers to calculate and commit bandwidth requests to hardware.
>
> Signed-off-by: David Dai <daidavid1@codeaurora.org>
> ---
> drivers/interconnect/qcom/sdm845.c | 1132 ++++++++++--------------
> include/dt-bindings/interconnect/qcom,sdm845.h | 263 +++---
> 2 files changed, 609 insertions(+), 786 deletions(-)
>
> diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c
> index f078cf0..8145612 100644
> --- a/drivers/interconnect/qcom/sdm845.c
> +++ b/drivers/interconnect/qcom/sdm845.c
> @@ -5,283 +5,285 @@
> */
>
> #include <asm/div64.h>

You don't need this header anymore, right?

> -#include <dt-bindings/interconnect/qcom,sdm845.h>
> #include <linux/device.h>
> #include <linux/interconnect.h>
> #include <linux/interconnect-provider.h>
> #include <linux/io.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> -#include <linux/of_platform.h>
> -#include <linux/platform_device.h>
> #include <linux/sort.h>

..or this one.