Re: [PATCH v2 2/6] dt-bindings: interconnect: Add YAML schemas for QCOM bcm-voter

Rob Herring
2020-01-15T14:44:53Z

On Thu, Jan 09, 2020 at 08:33:00PM -0800, David Dai wrote:
> Add YAML schemas for interconnect bcm-voters found on QCOM RPMh-based
> SoCs.
>
> Signed-off-by: David Dai <daidavid1@codeaurora.org>
> ---
> .../bindings/interconnect/qcom,bcm-voter.yaml | 45 ++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml b/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml
> new file mode 100644
> index 0000000..a6bdf6e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interconnect/qcom,bcm-voter.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm BCM-Voter Interconnect
> +
> +maintainers:
> + - David Dai <daidavid1@codeaurora.org>
> +
> +description: |

Don't need '|' unless you need formatting preserved.

> + The Bus Clock Manager (BCM) is a dedicated hardware accelerator
> + that manages shared system resources by aggregating requests
> + from multiple Resource State Coordinators (RSC). Interconnect
> + providers are able to vote for aggregated thresholds values from
> + consumers by communicating through their respective RSCs.

Indent should be 2 spaces.

> +
> +properties:
> + compatible:
> + enum:
> + - qcom,sdm845-bcm-voter
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + apps_rsc: interconnect@179c0000 {

Unit-address should also have 'reg' property.

> + compatible = "qcom,rpmh-rsc";

Note that once this has a schema, it will be checked, so make sure it's
complete.

> +
> + apps_bcm_voter: bcm_voter {
> + compatible = "qcom,sdm845-bcm-voter";
> + };
> + };
> +
> + disp_rsc: interconnect@179d0000 {
> + compatible = "qcom,rpmh-rsc";
> +
> + disp_bcm_voter: bcm_voter {
> + compatible = "qcom,sdm845-bcm-voter";
> + };
> + };
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>