[PATCH 0/4] soc: qcom: Add QCS9100 SoC ID and compatible support

[PATCH 0/4] soc: qcom: Add QCS9100 SoC ID and compatible support

[Tengfei Fan]

Add QCS9100 SoC ID and compatible support. The QCS9100, referencing the
SA8775p, shares the same SoC DTSI and board DTS. The distinction lies in
their unique SoC ID.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
Tengfei Fan (4):
      dt-bindings: arm: qcom,ids: add SoC ID for QCS9100
      soc: qcom: socinfo: add QCS9100 ID
      dt-bindings: arm: qcom: Document QCS9100 compatible
      arm64: dts: qcom: sa8775p-ride: Add QCS9100 compatible

 Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
 arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dts    | 2 +-
 arch/arm64/boot/dts/qcom/sa8775p-ride.dts       | 2 +-
 drivers/soc/qcom/socinfo.c                      | 1 +
 include/dt-bindings/arm/qcom,ids.h              | 1 +
 5 files changed, 6 insertions(+), 2 deletions(-)
---
base-commit: d6dbc9f56c3a70e915625b6f1887882c23dc5c91
change-id: 20240806-add_qcs9100_soc_id-d20ce2a67098

Best regards,
-- 
Tengfei Fan <quic_tengfan@quicinc.com>

[PATCH 1/4] dt-bindings: arm: qcom,ids: add SoC ID for QCS9100

[Tengfei Fan]

Add the ID for the Qualcomm QCS9100 SoC.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 include/dt-bindings/arm/qcom,ids.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index d6c9e9472121..d0396e8c9af6 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -274,6 +274,7 @@
 #define QCOM_ID_QCM8550			604
 #define QCOM_ID_IPQ5300			624
 #define QCOM_ID_IPQ5321			650
+#define QCOM_ID_QCS9100			667
 
 /*
  * The board type and revision information, used by Qualcomm bootloaders and

-- 
2.25.1

Re: [PATCH 1/4] dt-bindings: arm: qcom,ids: add SoC ID for QCS9100

[Krzysztof Kozlowski]

On 06/08/2024 06:19, Tengfei Fan wrote:
> Add the ID for the Qualcomm QCS9100 SoC.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 2/4] soc: qcom: socinfo: add QCS9100 ID

[Tengfei Fan]

Add the ID for the Qualcomm QCS9100 SoC.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 drivers/soc/qcom/socinfo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index d7359a235e3c..6de6afd518c5 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -441,6 +441,7 @@ static const struct soc_id soc_id[] = {
 	{ qcom_board_id(QCM8550) },
 	{ qcom_board_id(IPQ5300) },
 	{ qcom_board_id(IPQ5321) },
+	{ qcom_board_id(QCS9100) },
 };
 
 static const char *socinfo_machine(struct device *dev, unsigned int id)

-- 
2.25.1

Re: [PATCH 2/4] soc: qcom: socinfo: add QCS9100 ID

[Krzysztof Kozlowski]

On 06/08/2024 06:19, Tengfei Fan wrote:
> Add the ID for the Qualcomm QCS9100 SoC.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 3/4] dt-bindings: arm: qcom: Document QCS9100 compatible

[Tengfei Fan]

Add the compatible for QCS9100 SoC.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index f08e13b61172..71368b08eab8 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -43,6 +43,7 @@ description: |
         msm8998
         qcs404
         qcs8550
+        qcs9100
         qcm2290
         qcm6490
         qdu1000
@@ -900,6 +901,7 @@ properties:
               - qcom,sa8775p-ride
               - qcom,sa8775p-ride-r3
           - const: qcom,sa8775p
+          - const: qcom,qcs9100
 
       - items:
           - enum:

-- 
2.25.1

Re: [PATCH 3/4] dt-bindings: arm: qcom: Document QCS9100 compatible

[Krzysztof Kozlowski]

On 06/08/2024 06:19, Tengfei Fan wrote:
> Add the compatible for QCS9100 SoC.

Standard reply: we see that from the diff. Oh wait, no! The diff is
doing something entirely else.

You do much more - change SA8775p bindings.

Commit msg should say why you are doing such invasive change.

Best regards,
Krzysztof

Re: [PATCH 3/4] dt-bindings: arm: qcom: Document QCS9100 compatible

[Tengfei Fan]

On 8/7/2024 3:27 PM, Krzysztof Kozlowski wrote:
> On 06/08/2024 06:19, Tengfei Fan wrote:
>> Add the compatible for QCS9100 SoC.
> 
> Standard reply: we see that from the diff. Oh wait, no! The diff is
> doing something entirely else.
> 
> You do much more - change SA8775p bindings.
> 
> Commit msg should say why you are doing such invasive change.
> 
> Best regards,
> Krzysztof
> 

I will explain the reason why change SA8775p bindings for support 
QCS9100 in the commit message of the next version patch series.

-- 
Thx and BRs,
Tengfei Fan

[PATCH 4/4] arm64: dts: qcom: sa8775p-ride: Add QCS9100 compatible

[Tengfei Fan]

Add QCS9100 compatible in sa8775p ride and sa8775p ride r3 board DTS.
QCS9100 references SA8775p, they share the same SoC DTSI and board DTS.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dts | 2 +-
 arch/arm64/boot/dts/qcom/sa8775p-ride.dts    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dts
index ae065ae92478..14f0cf2f2350 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dts
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dts
@@ -9,7 +9,7 @@
 
 / {
 	model = "Qualcomm SA8775P Ride Rev3";
-	compatible = "qcom,sa8775p-ride-r3", "qcom,sa8775p";
+	compatible = "qcom,sa8775p-ride-r3", "qcom,sa8775p", "qcom,qcs9100";
 };
 
 &ethernet0 {
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
index 2e87fd760dbd..8fdfc3abd51f 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
@@ -9,7 +9,7 @@
 
 / {
 	model = "Qualcomm SA8775P Ride";
-	compatible = "qcom,sa8775p-ride", "qcom,sa8775p";
+	compatible = "qcom,sa8775p-ride", "qcom,sa8775p", "qcom,qcs9100";
 };
 
 &ethernet0 {

-- 
2.25.1

Re: [PATCH 4/4] arm64: dts: qcom: sa8775p-ride: Add QCS9100 compatible

[Krzysztof Kozlowski]

On 06/08/2024 06:19, Tengfei Fan wrote:
> Add QCS9100 compatible in sa8775p ride and sa8775p ride r3 board DTS.
> QCS9100 references SA8775p, they share the same SoC DTSI and board DTS.
> 

I don't understand this. You claim here that QCS9100 references SA8775p
but your diff says other way: SA8775p references QCS9100.

Sorry, that's confusing.

Best regards,
Krzysztof

Re: [PATCH 4/4] arm64: dts: qcom: sa8775p-ride: Add QCS9100 compatible

[Tengfei Fan]

On 8/7/2024 3:28 PM, Krzysztof Kozlowski wrote:
> On 06/08/2024 06:19, Tengfei Fan wrote:
>> Add QCS9100 compatible in sa8775p ride and sa8775p ride r3 board DTS.
>> QCS9100 references SA8775p, they share the same SoC DTSI and board DTS.
>>
> 
> I don't understand this. You claim here that QCS9100 references SA8775p
> but your diff says other way: SA8775p references QCS9100.
> 
> Sorry, that's confusing.
> 
> Best regards,
> Krzysztof
> 

I will update the compatible as follows to indicate that QCS9100 
references SA8775p.

compatible = "qcom,sa8775p-ride", "qcom,qcs9100", "qcom,sa8775p";

-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH 4/4] arm64: dts: qcom: sa8775p-ride: Add QCS9100 compatible

[Krzysztof Kozlowski]

On 07/08/2024 11:17, Tengfei Fan wrote:
> 
> 
> On 8/7/2024 3:28 PM, Krzysztof Kozlowski wrote:
>> On 06/08/2024 06:19, Tengfei Fan wrote:
>>> Add QCS9100 compatible in sa8775p ride and sa8775p ride r3 board DTS.
>>> QCS9100 references SA8775p, they share the same SoC DTSI and board DTS.
>>>
>>
>> I don't understand this. You claim here that QCS9100 references SA8775p
>> but your diff says other way: SA8775p references QCS9100.
>>
>> Sorry, that's confusing.
>>
>> Best regards,
>> Krzysztof
>>
> 
> I will update the compatible as follows to indicate that QCS9100 
> references SA8775p.
> 
> compatible = "qcom,sa8775p-ride", "qcom,qcs9100", "qcom,sa8775p";

Is this still correct, though? sa8775p won't come with qcs9100 SoC.

Best regards,
Krzysztof

Re: [PATCH 4/4] arm64: dts: qcom: sa8775p-ride: Add QCS9100 compatible

[Tingwei Zhang]

On 8/7/2024 5:35 PM, Krzysztof Kozlowski wrote:
> On 07/08/2024 11:17, Tengfei Fan wrote:
>>
>>
>> On 8/7/2024 3:28 PM, Krzysztof Kozlowski wrote:
>>> On 06/08/2024 06:19, Tengfei Fan wrote:
>>>> Add QCS9100 compatible in sa8775p ride and sa8775p ride r3 board DTS.
>>>> QCS9100 references SA8775p, they share the same SoC DTSI and board DTS.
>>>>
>>>
>>> I don't understand this. You claim here that QCS9100 references SA8775p
>>> but your diff says other way: SA8775p references QCS9100.
>>>
>>> Sorry, that's confusing.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> I will update the compatible as follows to indicate that QCS9100
>> references SA8775p.
>>
>> compatible = "qcom,sa8775p-ride", "qcom,qcs9100", "qcom,sa8775p";
> 
> Is this still correct, though? sa8775p won't come with qcs9100 SoC.
We have a new board. Hardware is same as sa877p-ride except sa8775p is 
replaced with qcs9100. We add qcs9100 SoC compatible to sa8775p-ride 
device tree to indicate this board can support both sa8775p SoC and 
qcs9100 SoC.
> 
> Best regards,
> Krzysztof
> 

-- 
Thanks,
Tingwei

Re: [PATCH 4/4] arm64: dts: qcom: sa8775p-ride: Add QCS9100 compatible

[Krzysztof Kozlowski]

On 07/08/2024 13:04, Tingwei Zhang wrote:
> On 8/7/2024 5:35 PM, Krzysztof Kozlowski wrote:
>> On 07/08/2024 11:17, Tengfei Fan wrote:
>>>
>>>
>>> On 8/7/2024 3:28 PM, Krzysztof Kozlowski wrote:
>>>> On 06/08/2024 06:19, Tengfei Fan wrote:
>>>>> Add QCS9100 compatible in sa8775p ride and sa8775p ride r3 board DTS.
>>>>> QCS9100 references SA8775p, they share the same SoC DTSI and board DTS.
>>>>>
>>>>
>>>> I don't understand this. You claim here that QCS9100 references SA8775p
>>>> but your diff says other way: SA8775p references QCS9100.
>>>>
>>>> Sorry, that's confusing.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>>
>>> I will update the compatible as follows to indicate that QCS9100
>>> references SA8775p.
>>>
>>> compatible = "qcom,sa8775p-ride", "qcom,qcs9100", "qcom,sa8775p";
>>
>> Is this still correct, though? sa8775p won't come with qcs9100 SoC.
> We have a new board. Hardware is same as sa877p-ride except sa8775p is 
> replaced with qcs9100. We add qcs9100 SoC compatible to sa8775p-ride 

Does "new board" mean that "old board" disappears? No users to care
about it? Or just the existing board is being changed (like new revision)?

Best regards,
Krzysztof

Re: [PATCH 4/4] arm64: dts: qcom: sa8775p-ride: Add QCS9100 compatible

[Tingwei Zhang]

On 8/8/2024 7:05 PM, Krzysztof Kozlowski wrote:
> On 07/08/2024 13:04, Tingwei Zhang wrote:
>> On 8/7/2024 5:35 PM, Krzysztof Kozlowski wrote:
>>> On 07/08/2024 11:17, Tengfei Fan wrote:
>>>>
>>>>
>>>> On 8/7/2024 3:28 PM, Krzysztof Kozlowski wrote:
>>>>> On 06/08/2024 06:19, Tengfei Fan wrote:
>>>>>> Add QCS9100 compatible in sa8775p ride and sa8775p ride r3 board DTS.
>>>>>> QCS9100 references SA8775p, they share the same SoC DTSI and board DTS.
>>>>>>
>>>>>
>>>>> I don't understand this. You claim here that QCS9100 references SA8775p
>>>>> but your diff says other way: SA8775p references QCS9100.
>>>>>
>>>>> Sorry, that's confusing.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>>
>>>> I will update the compatible as follows to indicate that QCS9100
>>>> references SA8775p.
>>>>
>>>> compatible = "qcom,sa8775p-ride", "qcom,qcs9100", "qcom,sa8775p";
>>>
>>> Is this still correct, though? sa8775p won't come with qcs9100 SoC.
>> We have a new board. Hardware is same as sa877p-ride except sa8775p is
>> replaced with qcs9100. We add qcs9100 SoC compatible to sa8775p-ride
> 
> Does "new board" mean that "old board" disappears? No users to care
> about it? Or just the existing board is being changed (like new revision)?

We will support both boards. Sa8775p-ride board with sa8775p chipset and 
sa8775p-ride board with qcs9100 chipset. Both of them can be used for 
development.
> 
> Best regards,
> Krzysztof
> 

-- 
Thanks,
Tingwei

Re: [PATCH 4/4] arm64: dts: qcom: sa8775p-ride: Add QCS9100 compatible

[Krzysztof Kozlowski]

On 12/08/2024 04:16, Tingwei Zhang wrote:
> On 8/8/2024 7:05 PM, Krzysztof Kozlowski wrote:
>> On 07/08/2024 13:04, Tingwei Zhang wrote:
>>> On 8/7/2024 5:35 PM, Krzysztof Kozlowski wrote:
>>>> On 07/08/2024 11:17, Tengfei Fan wrote:
>>>>>
>>>>>
>>>>> On 8/7/2024 3:28 PM, Krzysztof Kozlowski wrote:
>>>>>> On 06/08/2024 06:19, Tengfei Fan wrote:
>>>>>>> Add QCS9100 compatible in sa8775p ride and sa8775p ride r3 board DTS.
>>>>>>> QCS9100 references SA8775p, they share the same SoC DTSI and board DTS.
>>>>>>>
>>>>>>
>>>>>> I don't understand this. You claim here that QCS9100 references SA8775p
>>>>>> but your diff says other way: SA8775p references QCS9100.
>>>>>>
>>>>>> Sorry, that's confusing.
>>>>>>
>>>>>> Best regards,
>>>>>> Krzysztof
>>>>>>
>>>>>
>>>>> I will update the compatible as follows to indicate that QCS9100
>>>>> references SA8775p.
>>>>>
>>>>> compatible = "qcom,sa8775p-ride", "qcom,qcs9100", "qcom,sa8775p";
>>>>
>>>> Is this still correct, though? sa8775p won't come with qcs9100 SoC.
>>> We have a new board. Hardware is same as sa877p-ride except sa8775p is
>>> replaced with qcs9100. We add qcs9100 SoC compatible to sa8775p-ride
>>
>> Does "new board" mean that "old board" disappears? No users to care
>> about it? Or just the existing board is being changed (like new revision)?
> 
> We will support both boards. Sa8775p-ride board with sa8775p chipset and 
> sa8775p-ride board with qcs9100 chipset. Both of them can be used for 
> development.

Patch does something else then - changes compatibles for the existing
(old) board.

Best regards,
Krzysztof

Re: [PATCH 4/4] arm64: dts: qcom: sa8775p-ride: Add QCS9100 compatible

[Tingwei Zhang]

在 8/12/2024 2:15 PM, Krzysztof Kozlowski 写道:
> On 12/08/2024 04:16, Tingwei Zhang wrote:
>> On 8/8/2024 7:05 PM, Krzysztof Kozlowski wrote:
>>> On 07/08/2024 13:04, Tingwei Zhang wrote:
>>>> On 8/7/2024 5:35 PM, Krzysztof Kozlowski wrote:
>>>>> On 07/08/2024 11:17, Tengfei Fan wrote:
>>>>>>
>>>>>>
>>>>>> On 8/7/2024 3:28 PM, Krzysztof Kozlowski wrote:
>>>>>>> On 06/08/2024 06:19, Tengfei Fan wrote:
>>>>>>>> Add QCS9100 compatible in sa8775p ride and sa8775p ride r3 board DTS.
>>>>>>>> QCS9100 references SA8775p, they share the same SoC DTSI and board DTS.
>>>>>>>>
>>>>>>>
>>>>>>> I don't understand this. You claim here that QCS9100 references SA8775p
>>>>>>> but your diff says other way: SA8775p references QCS9100.
>>>>>>>
>>>>>>> Sorry, that's confusing.
>>>>>>>
>>>>>>> Best regards,
>>>>>>> Krzysztof
>>>>>>>
>>>>>>
>>>>>> I will update the compatible as follows to indicate that QCS9100
>>>>>> references SA8775p.
>>>>>>
>>>>>> compatible = "qcom,sa8775p-ride", "qcom,qcs9100", "qcom,sa8775p";
>>>>>
>>>>> Is this still correct, though? sa8775p won't come with qcs9100 SoC.
>>>> We have a new board. Hardware is same as sa877p-ride except sa8775p is
>>>> replaced with qcs9100. We add qcs9100 SoC compatible to sa8775p-ride
>>>
>>> Does "new board" mean that "old board" disappears? No users to care
>>> about it? Or just the existing board is being changed (like new revision)?
>>
>> We will support both boards. Sa8775p-ride board with sa8775p chipset and
>> sa8775p-ride board with qcs9100 chipset. Both of them can be used for
>> development.
> 
> Patch does something else then - changes compatibles for the existing
> (old) board.

Can you educate us the right way to add the qcs9100 SoC support in 
sa8775p-ride board? We don't want to duplicate whole device tree file 
since all the hardwares are same except the SoC, so we add qcs9100 SoC 
compatible to sa8775p-ride board and still keep sa8775p SoC compatible.
> 
> Best regards,
> Krzysztof
> 


-- 
Thanks,
Tingwei

Re: [PATCH 4/4] arm64: dts: qcom: sa8775p-ride: Add QCS9100 compatible

[Krzysztof Kozlowski]

On 12/08/2024 09:07, Tingwei Zhang wrote:
> 在 8/12/2024 2:15 PM, Krzysztof Kozlowski 写道:
>> On 12/08/2024 04:16, Tingwei Zhang wrote:
>>> On 8/8/2024 7:05 PM, Krzysztof Kozlowski wrote:
>>>> On 07/08/2024 13:04, Tingwei Zhang wrote:
>>>>> On 8/7/2024 5:35 PM, Krzysztof Kozlowski wrote:
>>>>>> On 07/08/2024 11:17, Tengfei Fan wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 8/7/2024 3:28 PM, Krzysztof Kozlowski wrote:
>>>>>>>> On 06/08/2024 06:19, Tengfei Fan wrote:
>>>>>>>>> Add QCS9100 compatible in sa8775p ride and sa8775p ride r3 board DTS.
>>>>>>>>> QCS9100 references SA8775p, they share the same SoC DTSI and board DTS.
>>>>>>>>>
>>>>>>>>
>>>>>>>> I don't understand this. You claim here that QCS9100 references SA8775p
>>>>>>>> but your diff says other way: SA8775p references QCS9100.
>>>>>>>>
>>>>>>>> Sorry, that's confusing.
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>> Krzysztof
>>>>>>>>
>>>>>>>
>>>>>>> I will update the compatible as follows to indicate that QCS9100
>>>>>>> references SA8775p.
>>>>>>>
>>>>>>> compatible = "qcom,sa8775p-ride", "qcom,qcs9100", "qcom,sa8775p";
>>>>>>
>>>>>> Is this still correct, though? sa8775p won't come with qcs9100 SoC.
>>>>> We have a new board. Hardware is same as sa877p-ride except sa8775p is
>>>>> replaced with qcs9100. We add qcs9100 SoC compatible to sa8775p-ride
>>>>
>>>> Does "new board" mean that "old board" disappears? No users to care
>>>> about it? Or just the existing board is being changed (like new revision)?
>>>
>>> We will support both boards. Sa8775p-ride board with sa8775p chipset and
>>> sa8775p-ride board with qcs9100 chipset. Both of them can be used for
>>> development.
>>
>> Patch does something else then - changes compatibles for the existing
>> (old) board.
> 
> Can you educate us the right way to add the qcs9100 SoC support in 
> sa8775p-ride board? We don't want to duplicate whole device tree file 
> since all the hardwares are same except the SoC, so we add qcs9100 SoC 
> compatible to sa8775p-ride board and still keep sa8775p SoC compatible.

Split board DTS into shared DTSI (just don't forget about proper
-M/-C/-B arguments for format-patch) and include it in relevant boards.
You also need new SoC DTSI. This will be unusual code, but it matches
what you want to achieve.

Best regards,
Krzysztof

Re: [PATCH 4/4] arm64: dts: qcom: sa8775p-ride: Add QCS9100 compatible

[Aiqun Yu (Maria)]

On 8/13/2024 4:34 PM, Krzysztof Kozlowski wrote:
> On 12/08/2024 09:07, Tingwei Zhang wrote:
>> 在 8/12/2024 2:15 PM, Krzysztof Kozlowski 写道:
>>> On 12/08/2024 04:16, Tingwei Zhang wrote:
>>>> On 8/8/2024 7:05 PM, Krzysztof Kozlowski wrote:
>>>>> On 07/08/2024 13:04, Tingwei Zhang wrote:
>>>>>> On 8/7/2024 5:35 PM, Krzysztof Kozlowski wrote:
>>>>>>> On 07/08/2024 11:17, Tengfei Fan wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 8/7/2024 3:28 PM, Krzysztof Kozlowski wrote:
>>>>>>>>> On 06/08/2024 06:19, Tengfei Fan wrote:
>>>>>>>>>> Add QCS9100 compatible in sa8775p ride and sa8775p ride r3 board DTS.
>>>>>>>>>> QCS9100 references SA8775p, they share the same SoC DTSI and board DTS.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> I don't understand this. You claim here that QCS9100 references SA8775p
>>>>>>>>> but your diff says other way: SA8775p references QCS9100.
>>>>>>>>>
>>>>>>>>> Sorry, that's confusing.
>>>>>>>>>
>>>>>>>>> Best regards,
>>>>>>>>> Krzysztof
>>>>>>>>>
>>>>>>>>
>>>>>>>> I will update the compatible as follows to indicate that QCS9100
>>>>>>>> references SA8775p.
>>>>>>>>
>>>>>>>> compatible = "qcom,sa8775p-ride", "qcom,qcs9100", "qcom,sa8775p";
>>>>>>>
>>>>>>> Is this still correct, though? sa8775p won't come with qcs9100 SoC.
>>>>>> We have a new board. Hardware is same as sa877p-ride except sa8775p is
>>>>>> replaced with qcs9100. We add qcs9100 SoC compatible to sa8775p-ride
>>>>>
>>>>> Does "new board" mean that "old board" disappears? No users to care
>>>>> about it? Or just the existing board is being changed (like new revision)?
>>>>
>>>> We will support both boards. Sa8775p-ride board with sa8775p chipset and
>>>> sa8775p-ride board with qcs9100 chipset. Both of them can be used for
>>>> development.
>>>
>>> Patch does something else then - changes compatibles for the existing
>>> (old) board.
>>
>> Can you educate us the right way to add the qcs9100 SoC support in 
>> sa8775p-ride board? We don't want to duplicate whole device tree file 
>> since all the hardwares are same except the SoC, so we add qcs9100 SoC 
>> compatible to sa8775p-ride board and still keep sa8775p SoC compatible.
> 
> Split board DTS into shared DTSI (just don't forget about proper
> -M/-C/-B arguments for format-patch) and include it in relevant boards.
> You also need new SoC DTSI. This will be unusual code, but it matches
> what you want to achieve.

If we create two additional DTSs, a total of four DTBs will be generated.
Should we update the current board DTSs (sa8775p-ride-r3.dts and
sa8775p-ride.dts) to support the pin-to-pin compatible QCS9100 and
SA8775p SoCs?

Considering the higher usage of QCS9100 boards in IoT compared to
SA8775p in automotive for these DTBs, perhaps we should prioritize the
'qcom,qcs9100' compatibility before 'qcom,sa8775p'.
> 
> Best regards,
> Krzysztof
> 

-- 
Thx and BRs,
Aiqun(Maria) Yu

Re: [PATCH 4/4] arm64: dts: qcom: sa8775p-ride: Add QCS9100 compatible

[Krzysztof Kozlowski]

On 13/08/2024 10:59, Aiqun Yu (Maria) wrote:
>>>>>> Does "new board" mean that "old board" disappears? No users to care
>>>>>> about it? Or just the existing board is being changed (like new revision)?
>>>>>
>>>>> We will support both boards. Sa8775p-ride board with sa8775p chipset and
>>>>> sa8775p-ride board with qcs9100 chipset. Both of them can be used for
>>>>> development.
>>>>
>>>> Patch does something else then - changes compatibles for the existing
>>>> (old) board.
>>>
>>> Can you educate us the right way to add the qcs9100 SoC support in 
>>> sa8775p-ride board? We don't want to duplicate whole device tree file 
>>> since all the hardwares are same except the SoC, so we add qcs9100 SoC 
>>> compatible to sa8775p-ride board and still keep sa8775p SoC compatible.
>>
>> Split board DTS into shared DTSI (just don't forget about proper
>> -M/-C/-B arguments for format-patch) and include it in relevant boards.
>> You also need new SoC DTSI. This will be unusual code, but it matches
>> what you want to achieve.
> 
> If we create two additional DTSs, a total of four DTBs will be generated.
> Should we update the current board DTSs (sa8775p-ride-r3.dts and
> sa8775p-ride.dts) to support the pin-to-pin compatible QCS9100 and
> SA8775p SoCs?

I don't know, I don't have such device. Decision should be based on real
life, real events happening, real products, not on feelings.

> 
> Considering the higher usage of QCS9100 boards in IoT compared to
> SA8775p in automotive for these DTBs, perhaps we should prioritize the
> 'qcom,qcs9100' compatibility before 'qcom,sa8775p'.

Prioritize in what way? What does it mean?

Best regards,
Krzysztof