The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Marco Elver <elver@google.com>, Thomas Richter <tmricht@linux.ibm.com>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-perf-users@vger.kernel.org>, <acme@kernel.org>,
	<svens@linux.ibm.com>, <gor@linux.ibm.com>,
	<sumanthk@linux.ibm.com>, <hca@linux.ibm.com>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] perf test: Test 73 Sig_trap fails on s390
Date: Mon, 17 Jan 2022 15:39:10 +0000	[thread overview]
Message-ID: <90efb5a9-612a-919e-cf2f-c528692d61e2@huawei.com> (raw)
In-Reply-To: <CANpmjNNMWtjcKa961SjEvRbbPXyw5M5SkrXbb3tnyL3_XyniCw@mail.gmail.com>

On 16/12/2021 15:48, Marco Elver wrote:

+

> On Thu, 16 Dec 2021 at 16:15, Thomas Richter<tmricht@linux.ibm.com>  wrote:
>> In Linux next kernel
>> Commit 5504f67944484 ("perf test sigtrap: Add basic stress test for sigtrap handling")
>> introduced the new test which uses breakpoint events.
>> These events are not supported on s390 and PowerPC and always fail:
>>
>>   # perf test -F 73
>>   73: Sigtrap                                                         : FAILED!
>>   #
>>
>> Fix it the same way as in the breakpoint tests in file
>> tests/bp_account.c where these type of tests are skipped on
>> s390 and PowerPC platforms.
>>
>> With this patch skip this test on both platforms.
>>
>> Output after:
>>   # ./perf test -F 73
>>   73: Sigtrap
>>
>> Fixes: 5504f67944484 ("perf test sigtrap: Add basic stress test for sigtrap handling")
>>
>> Cc: Marco Elver<elver@google.com>
>> Signed-off-by: Thomas Richter<tmricht@linux.ibm.com>
> Acked-by: Marco Elver<elver@google.com>
> 
> Thanks, and sorry for missing this case!
> 

I am finding that this test hangs on my arm64 machine:

john@debian:~/kernel-dev2/tools/perf$ sudo ./perf test -vvv 73
  73: Sigtrap:
--- start ---
test child forked, pid 45193

And fails on my x86 broadwell machine:

john@localhost:~/kernel-dev2/tools/perf> sudo ./perf test -v 73
73: Sigtrap                                                         :
--- start ---
test child forked, pid 22255
FAILED sys_perf_event_open(): Argument list too long
test child finished with -1
---- end ----
Sigtrap: FAILED!
john@localhost:~/kernel-dev2/tools/perf>

Are there more architectures+platforms for which we need to skip this test?

Thanks,
John

  reply	other threads:[~2022-01-17 15:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 15:14 [PATCH] perf test: Test 73 Sig_trap fails on s390 Thomas Richter
2021-12-16 15:48 ` Marco Elver
2022-01-17 15:39   ` John Garry [this message]
2022-01-18  9:18     ` Leo Yan
2022-01-18 10:20       ` John Garry
2022-01-18 11:18         ` Leo Yan
2022-01-18 11:40       ` Marco Elver
2022-01-18 12:43         ` Leo Yan
2022-01-24  9:19           ` Test 73 Sig_trap fails on arm64 (was Re: [PATCH] perf test: Test 73 Sig_trap fails on s390) John Garry
2022-01-31 17:55             ` Test 73 Sig_trap fails on arm64 Dmitry Vyukov
2022-02-01 10:03               ` Dmitry Vyukov
2022-02-15 11:16             ` Test 73 Sig_trap fails on arm64 (was Re: [PATCH] perf test: Test 73 Sig_trap fails on s390) John Garry
2022-02-15 14:35               ` Will Deacon
2022-02-16 11:46                 ` John Garry
2022-02-16 11:54                   ` Dmitry Vyukov
2022-02-16 13:13                     ` Leo Yan
2022-02-17  9:53                       ` John Garry
2022-02-17 11:04                         ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90efb5a9-612a-919e-cf2f-c528692d61e2@huawei.com \
    --to=john.garry@huawei.com \
    --cc=acme@kernel.org \
    --cc=elver@google.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=sumanthk@linux.ibm.com \
    --cc=svens@linux.ibm.com \
    --cc=tmricht@linux.ibm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox