Re: [PATCH v3 07/16] x86/virt/tdx: Add tdx_alloc/free_page() helpers

Edgecombe, Rick P
2025-09-26T22:42:03Z

On Mon, 2025-09-22 at 11:27 +0000, Huang, Kai wrote:
> > +
> > + /*
> > + * It might have come from 'prealloc', but this is
> > an error
> > + * path. Don't be fancy, just free them.
> > TDH.PHYMEM.PAMT.ADD
> > + * only modifies RAX, so the encoded array is
> > still in place.
> > + */
> > + __free_page(phys_to_page(pa_array[i]));
> >
>
> This comment shouldn't be in this patch?  The 'prealloc' concept
> doesn't
> exist yet until patch 12 AFAICT.

Oh, yep. The comment should be added when prealloc starts getting used.