From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF5E639E19C for ; Thu, 26 Feb 2026 22:08:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772143722; cv=none; b=QScqs3HnzdG576exKAkHhsVaYrTLuPS+AsyPhLBQM/PbCrcs4nSp7+qO1NzC7m4eXrOKxnOvmgoZnd2jDGvVENa2aZd7l/FbmgADQyTgUxW6EWrqBVmlE+1bYXOX349XS8ZQQn8aB/QbbS2Qmt5FQYmpS3iXWH41PToJnFenr1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772143722; c=relaxed/simple; bh=Yle4mxjwNm8c2OsCYIKG7Mgd78VdSdFX2+WRfvaTnuM=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References; b=sH59h+4qRw0k43UXKCrWiVlH4lpzL7mfIDkoOt2L3JTJnsVTyrwmhhjxj0OxzrHwsl/CYAArpqZwwIxifwYcAmFyj1U625VmopB16FTAauBoPcqjPiozXFuKE0J8COSvJia4uBxXb9BoNKrBYNNS5IXlofMiJZHp6kf2O1OsQFQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NAwbjgEE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NAwbjgEE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C62FC19422; Thu, 26 Feb 2026 22:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772143722; bh=Yle4mxjwNm8c2OsCYIKG7Mgd78VdSdFX2+WRfvaTnuM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NAwbjgEEhg8VmLcqt+nhfgDBCI8et0VModrCS6FgQBWqRdOwMFiOks135AVmRajig SDTvVFbllGZ324Yv4xzdpYQ9p6MEGM0FMU7SOcwOOgjBUfKGNjvYQN66P/uiQauObD JM+2mYwdAsSkd7DmIEOt6u8dffjcG+8O0rPVQIchE6NsmksWhu/I9YaESe1C41pMm3 PVkU1s59hbXbVNCmtxgrQGtFBnAV2IwKZD2lDzFhPlDI7LTacY9H3s+zjEQw0kq+VN 0r2d/XEs4o1Ycl4pVcfO9oWTAimRQrQjsNl496yjmUsU47ZVV4CySnpnzHwUtMVPOn vp7WijGVpCZig== Date: Thu, 26 Feb 2026 12:08:41 -1000 Message-ID: <910584a388b5647dbccc2807bc2aa234@kernel.org> From: Tejun Heo To: David Carlier , David Vernet Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched_ext: add unlikely() hints in do_enqueue_task() hot path In-Reply-To: <20260226175019.40449-1-devnexen@gmail.com> References: <20260226175019.40449-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Hello, It looks like the patch accidentally includes a CLAUDE.md file creation. Could you drop that and resend? Also, for the PF_EXITING and migration_disabled checks, the original code intentionally places unlikely() only on the runtime condition (e.g. p->flags & PF_EXITING). Moving it to wrap the entire condition loses that precision. It'd be better to keep those as they are and only add unlikely() to the scx_rq_online() and scx_rq_bypassing() checks. Thanks. -- tejun