public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: James Chiang <cpchiang1@nuvoton.com>,
	Stanley Chu <yschu@nuvoton.com>,
	linux-i3c@lists.infradead.org, openbmc@lists.ozlabs.org,
	devicetree@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Joseph Liu <kwliu@nuvoton.com>,
	Tomer Maimon <tomer.maimon@nuvoton.com>
Subject: Re: [PATCH 2/2] i3c: master: Add Nuvoton npcm845 i3c master driver
Date: Thu, 1 Aug 2024 11:06:21 +0200	[thread overview]
Message-ID: <910f96b4-509d-445e-8749-ee4240849b0b@web.de> (raw)
In-Reply-To: <20240801071946.43266-3-yschu@nuvoton.com>

…
> +++ b/drivers/i3c/master/npcm845-i3c-master.c
> @@ -0,0 +1,2364 @@
> +static int npcm_i3c_master_probe(struct platform_device *pdev)
> +{
> +	return 0;
> +
> +	debugfs_remove_recursive(master->debugfs);
> +
> +err_disable_clks:
…

Please avoid non-reachable code here.

Regards,
Markus

  parent reply	other threads:[~2024-08-01  9:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-01  7:19 [PATCH v1 0/2] Add Nuvoton NPCM845 i3c master driver Stanley Chu
2024-08-01  7:19 ` [PATCH v1 1/2] dt-bindings: i3c: Add NPCM845 i3c controller Stanley Chu
2024-08-01 14:53   ` Krzysztof Kozlowski
2024-08-01 23:06     ` Alexandre Belloni
2024-08-05  5:37       ` Stanley Chu
2024-08-05  6:04     ` Stanley Chu
2024-08-01 14:57   ` Krzysztof Kozlowski
2024-08-01  7:19 ` [PATCH v1 2/2] i3c: master: Add Nuvoton npcm845 i3c master driver Stanley Chu
2024-08-01  8:42   ` [PATCH " Markus Elfring
2024-08-01 15:02     ` Krzysztof Kozlowski
2024-08-01  9:06   ` Markus Elfring [this message]
2024-08-01 15:02   ` [PATCH v1 " Krzysztof Kozlowski
2024-08-05  6:27     ` Stanley Chu
2024-08-02 16:16   ` Frank Li
2024-08-05  7:19     ` Stanley Chu
2024-08-05 15:17       ` Frank Li
2024-08-06  0:47         ` Stanley Chu
2024-08-06  3:08           ` Frank Li
2024-08-02 21:53   ` kernel test robot
2024-08-02 23:25   ` kernel test robot
2024-08-03  2:12   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=910f96b4-509d-445e-8749-ee4240849b0b@web.de \
    --to=markus.elfring@web.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=cpchiang1@nuvoton.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kwliu@nuvoton.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh@kernel.org \
    --cc=tomer.maimon@nuvoton.com \
    --cc=yschu@nuvoton.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox