From: "lihuisong (C)" <lihuisong@huawei.com>
To: Sudeep Holla <sudeep.holla@arm.com>, Mark Brown <broonie@kernel.org>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Aishwarya TCV <Aishwarya.TCV@arm.com>,
<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mailbox: pcc: Remove spurious IRQF_ONESHOT usage
Date: Sat, 17 Jan 2026 10:12:11 +0800 [thread overview]
Message-ID: <9111d052-ea4f-443b-ba94-126b9c4262f5@huawei.com> (raw)
In-Reply-To: <aWpK-dMK3t0VVqFY@bogus>
On 1/16/2026 10:28 PM, Sudeep Holla wrote:
> On Fri, Jan 16, 2026 at 02:07:40PM +0000, Mark Brown wrote:
>> The PCC code currently specifies IRQF_ONESHOT if the interrupt could
>> potentially be shared but doesn't actually use request_threaded_irq() and
>> the interrupt handler does not use IRQ_WAKE_THREAD so IRQF_ONESHOT is
>> never relevant. Since commit aef30c8d569c ("genirq: Warn about using
>> IRQF_ONESHOT without a threaded handler") specifying it has resulted in a
>> WARN_ON(), fix this by removing IRQF_ONESHOT.
>>
> Looking back, can't think of any reason why we retained IRQF_ONESHOT
> when we added IRQF_SHARED. Thanks for spotting and fixing it.
>
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
The interrupt status of channel is cleared by bit first in pcc_mbox_irq.
And it is a hard irq handler.
Rmoving IRQF_ONESHOT looks good to me. Thanks for fixing it.
Acked-by: lihuisong@huawei.com
>
next prev parent reply other threads:[~2026-01-17 2:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 14:07 [PATCH] mailbox: pcc: Remove spurious IRQF_ONESHOT usage Mark Brown
2026-01-16 14:28 ` Sudeep Holla
2026-01-17 2:12 ` lihuisong (C) [this message]
2026-01-18 20:55 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9111d052-ea4f-443b-ba94-126b9c4262f5@huawei.com \
--to=lihuisong@huawei.com \
--cc=Aishwarya.TCV@arm.com \
--cc=broonie@kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox