public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Milton Miller <miltonm@bga.com>
To: "Grant Likely" <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
	"Jeremy Kerr" <jk@ozlabs.org>
Subject: Re: [RFC,PATCH] scripts/package: add powerpc images to tarball
Date: Sat, 26 Jul 2008 12:20:39 -0500	[thread overview]
Message-ID: <913573e2092839fbe37a0bfa37119eb6@bga.com> (raw)
In-Reply-To: <fa686aa40807252155l4f785920qdb14d117067b30f4@mail.gmail.com>

On Jul 25, 2008, at 11:55 PM, Grant Likely wrote:
> On Thu, Jul 24, 2008 at 9:08 PM, Milton Miller <miltonm@bga.com> wrote:
>>> Add support for powerpc builds in the buildtar script, to include
>>> a few default images.
>>> ---
>>> RFC: any requests for more/less boot images?
>> ..
>>> +             for img in zImage zImage.pseries zImage.iseries \
>>> +                             dtbImage dtbImage.ps3
>>
>> Yes.  How about all dtbImage, zImage, cuboot, treeboot, etc
>> that are newer than vmlinux?
>
> dtbImage is not a buildable image.  Neither is cuImage, treeImage or
> simpleImage.  All of those targets embed a device tree which is
> specified by adding the .dts filename to the target name.

I intended "all dtbImage" as a wildcard for dtbImage.*, etc.

> so, for example, 'make cuImage' fails.  Instead you do 'make
> cuImage.lite5200b' which pulls in dts/lite5200b.dts.

The user does make zImage which makes cuImage.lite5200b based on 
Kconfig.   Or it was that way until your change in 2.6.25 to allow the 
later, but they can still do the former.

Hmm, we really need to fix our calls to make boot images with make -j.  
Something for my todo list.

> Also, zImage is a 'meta' target that builds all the default image
> targets (the $image-y list).  The zImage is actually just a symlink to
> the first file in the list of default images.  So zImage can actually
> point to any kind of kernel image depending on how the kernel is
> configured.  I wonder if we should just remove the zImage file
> entirely, or at least make it always linked to one particular image
> type.

I think its fine as it is.   It says "make what is configured" that 
lets cross-platform building scripts be dumb and not need to know 
specificially what image makes sense to make.  Perhaps we should make 
it default to our additional target in Kconfig if specified, this 
allowing the user to specify which version he gets.

milton


  reply	other threads:[~2008-07-26 17:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24  8:17 [RFC,PATCH] scripts/package: add powerpc images to tarball Jeremy Kerr
2008-07-25  1:08 ` Milton Miller
2008-07-25  1:11   ` Jeremy Kerr
2008-07-26  3:59     ` Milton Miller
2008-07-26  4:55   ` Grant Likely
2008-07-26 17:20     ` Milton Miller [this message]
2008-07-26 17:53       ` Grant Likely
2008-07-28 16:34         ` T Ziomek
2008-07-28 16:49           ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=913573e2092839fbe37a0bfa37119eb6@bga.com \
    --to=miltonm@bga.com \
    --cc=grant.likely@secretlab.ca \
    --cc=jk@ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox