* 2.4.9 new min/max definitions are buggy
@ 2001-08-22 3:38 Keith Owens
0 siblings, 0 replies; only message in thread
From: Keith Owens @ 2001-08-22 3:38 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds
Leaving aside the question of whether the new min/max functions are
sane or not, the 2.4.9 definitions are buggy. If type is a pointer
like char *, __x takes pointer type, __y takes base type, splat!
Index: 9.1/include/linux/kernel.h
--- 9.1/include/linux/kernel.h Tue, 21 Aug 2001 16:48:26 +1000 kaos (linux-2.4/g/b/11_kernel.h 1.1.1.5 644)
+++ 9.1(w)/include/linux/kernel.h Wed, 22 Aug 2001 13:33:28 +1000 kaos (linux-2.4/g/b/11_kernel.h 1.1.1.5 644)
@@ -113,9 +113,9 @@ static inline void console_verbose(void)
((unsigned char *)&addr)[0]
#define min(type,x,y) \
- ({ type __x = (x), __y = (y); __x < __y ? __x: __y; })
+ ({ type __x = (x); type __y = (y); __x < __y ? __x: __y; })
#define max(type,x,y) \
- ({ type __x = (x), __y = (y); __x > __y ? __x: __y; })
+ ({ type __x = (x); type __y = (y); __x > __y ? __x: __y; })
#endif /* __KERNEL__ */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2001-08-22 3:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-08-22 3:38 2.4.9 new min/max definitions are buggy Keith Owens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox