Re: [BUG] rtc uie emulation deadlocks

Andrew Morton
2008-08-19T20:16:42Z

On Tue, 19 Aug 2008 10:12:04 -0700 (PDT)
David Brownell <david-b@pacbell.net> wrote:

>
> --- Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Mon, 11 Aug 2008 14:43:39 +0100 Russell King
> > <rmk+lkml@arm.linux.org.uk> wrote:
> >
> > > The locking looks a rather random in there, so I'm not going to try to
> > > create a patch.
> > >
> >
> > Looks like this was caused by
> >
> > commit 5ad31a575157147b43fa84ef1e21471661653878
> > Author: David Brownell <david-b@pacbell.net>
> > Date: Wed Jul 23 21:30:33 2008 -0700
> >
> > rtc: remove BKL for ioctl()
>
> I'm sure I saw someone else's fixup patch for that a couple weeks ago.
> (Looks). Yes:
>
> http://groups.google.com/group/rtc-linux/browse_thread/thread/ad65b883739f8c92#

argh, so a fix for a serious regression has been languishing in the
backwaters of the rtc list for two weeks.

Guys, please: regressions are serious, top-priority emergencies. We
drop everything and run around with our hair on fire when we hear about
one (don't we?). Please, if you have a report of a regression or a fix
for one, Cc: everyone in the world on it.

I'd prefer not to go fishing through HTML to piece that patch together,
but as my hair is on fire I guess I'd better do so.