Re: [PATCH v4 05/19] x86/resctrl: Introduce resctrl_file_fflags_init to initialize fflags

Reinette Chatre
2024-06-14T00:57:36Z

Hi Babu,

Shortlog: "Introduce resctrl_file_fflags_init() ..."

On 5/24/24 5:23 AM, Babu Moger wrote:
> The functions thread_throttle_mode_init() and mbm_config_rftype_init()

You can drop "The functions".

> both initialize fflags for resctrl files. Adding the new files will

"Adding the new files" -> "Adding new files"? (this should be in new
paragraph)

> involve adding another function to initialize the fflags. All of this

Solution should be in new paragraph and written in imperative mood.

> can be simplified by adding a new function resctrl_file_fflags_init()
> and passing the file name and flags to be initialized.
>
> Consolidate multiple fflags initialization into resctrl_file_fflags_init()
> and remove thread_throttle_mode_init() and mbm_config_rftype_init().
>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---

Patch looks good.

Reinette