Re: [PATCH v4 07/19] x86/resctrl: Add support to enable/disable ABMC feature

Moger, Babu
2024-06-21T15:45:09Z

Hi Reinette,

On 6/20/2024 5:02 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 6/19/24 8:37 AM, Moger, Babu wrote:
>> On 6/13/24 19:59, Reinette Chatre wrote:
>>> On 5/24/24 5:23 AM, Babu Moger wrote:
>
>>>> +     * Reset the internal counters so that it is not considered as
>>>> +     * an overflow in next update.
>>>
>>> For the first time the term "internal counters" is introduced. What
>>> does it
>>> mean?
>>
>> How about "mbm counters"?
>
> I think it refers to the state resctrl maintains to be able to catch
> overflows,
> so how about just "architectural state" with matching change of
> something like:
>
>     Reset the architectural state so that reading of hardware counter
>     is not considered as an overflow in next update.

Sure. Looks good. thanks

--
- Babu Moger