From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: thor.thayer@linux.intel.com, Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: altera-a10sr: constify gpio_chip structure
Date: Sun, 16 Jul 2017 23:14:31 -0500 [thread overview]
Message-ID: <9167407f-ce82-72dc-e2b2-585fb4ea5b67@embeddedor.com> (raw)
In-Reply-To: <b9982b12-1836-8623-c4e0-c0f3c82361b0@linux.intel.com>
On 07/13/2017 12:41 PM, Thor Thayer wrote:
> On 07/11/2017 05:15 PM, Gustavo A. R. Silva wrote:
>> This structure is only used to copy into another structure, so declare
>> it as const.
>
> <snip>
>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>> drivers/gpio/gpio-altera-a10sr.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpio-altera-a10sr.c
>> b/drivers/gpio/gpio-altera-a10sr.c
>> index 16a8951..6b11f13 100644
>> --- a/drivers/gpio/gpio-altera-a10sr.c
>> +++ b/drivers/gpio/gpio-altera-a10sr.c
>> @@ -71,7 +71,7 @@ static int altr_a10sr_gpio_direction_output(struct
>> gpio_chip *gc,
>> return -EINVAL;
>> }
>> -static struct gpio_chip altr_a10sr_gc = {
>> +static const struct gpio_chip altr_a10sr_gc = {
>> .label = "altr_a10sr_gpio",
>> .owner = THIS_MODULE,
>> .get = altr_a10sr_gpio_get,
>>
> Reviewed-by: Thor Thayer <thor.thayer@linux.intel.com>
Thank you, Thor.
--
Gustavo A. R. Silva
next prev parent reply other threads:[~2017-07-17 4:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 22:15 [PATCH] gpio: altera-a10sr: constify gpio_chip structure Gustavo A. R. Silva
2017-07-13 17:41 ` Thor Thayer
2017-07-17 4:14 ` Gustavo A. R. Silva [this message]
2017-08-02 8:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9167407f-ce82-72dc-e2b2-585fb4ea5b67@embeddedor.com \
--to=garsilva@embeddedor.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thor.thayer@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox