From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B15795223 for ; Fri, 21 Feb 2025 19:23:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740165801; cv=none; b=c88mG6K/qFsphejWutGhn1kijLEqFC8anmKpuj85an28VIJoInRINlYdp0Y1Ai61YbHSh8as8Gx/BcgGCFbgzZIKBczc3pY/M3+DSDd8VgJTfSE1X5VXNyPuliEF90nkozIJy32dlOvUl6oaGhorg0eZITZlY+MG0pvz2grs3iU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740165801; c=relaxed/simple; bh=WylaHPl7kQFGmSp8WXjj7W2gvI+NBOhDbeMQbmwatU0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ypfk0ulPfucfRw0YbO00cPGWAI9jBq9PfR3Kc2DXlNJrMXThAwDgdjKB/Rpyf7GWegIdKksLhbma9y/kaPRR3Q6ggGQ163+rp5AVow+IfAuNxHmnSlR2IXieZuhWSfBQi2n/Nr3e1Pmcxx8W4577zNby22WRsvn+ZQT20R5fEn0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CPaCY9zx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CPaCY9zx" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51LDXJ6V018834 for ; Fri, 21 Feb 2025 19:23:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Km9ahlx1nwdQ8uA3tj/aNXPGPboPCEVKF4XebUprYcE=; b=CPaCY9zx7jOEU+h4 KxzFB0N3q1cHyfn0Y81LZCvGWDuOGwfstj5bjhSW0Xfqk4Z7tklRUZ1snaJyPYHH JYc4d6Wf2yQ5rsok+WGulQn2Iw/yLc44CQWRO6zcQN0s9mg7q5Xz0yRqbVl1gajx YDimZf+ZtQaBxmDDOjSlZvxaOINafDvbhGF7ALQFyXYwKsRybv95G7B/4uMbW0F6 Wvfxx/m/f3BsZ4kPVM5nZYEwth68Ew56GQ6KoIgIyh5RlKz0AwGCHdYEI3i7xbB8 ADfbTPyTPyyW0IQu2fX8UzrkL33KWid8QvcRcwxCBrnh79l1KQSY2fdYQ8WsKSFG kt9zrg== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44xm3rjat1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 21 Feb 2025 19:23:18 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6e66ba99599so3643526d6.3 for ; Fri, 21 Feb 2025 11:23:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740165798; x=1740770598; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Km9ahlx1nwdQ8uA3tj/aNXPGPboPCEVKF4XebUprYcE=; b=Dzx03iRfmd0vwIgbnYYATaSoSWFiBXBboT9vBOI0XDMBo/NTjGa8TAenSHNAYsMqdU oc7kphoMo7rAB+7Y+hTQtITiYWkCQ3Vn5jM0Op1/Kk8vDRTR/x1Iob76sUVW1tjakO9n 4l6Ph4Lhlf3xzXtqll5/F7bwB8Cf5FFTCeexNCmkOsnwhuiHwLKLCGgdtvJcwCfpNkgY 1fDdZ40qnuPyS0zxUx7Nz3U7slOp6zirnr4MS1LjizMfioSnc3sBUst3WMKapY3zvlgg boc2oHFPnuumPZ+hf0fTp7NXnPO3LkCXRbDJVZ059nU63Ff7Sh8YQFOmmQM6xWWjJB02 am1w== X-Forwarded-Encrypted: i=1; AJvYcCVF6qoooNXsjBsSZXT1auJtZqVw0FOEoUojBpEU6mgaGYMVrr31X23v7mDqOWYvY/yKATAL9pvkgBx7fUY=@vger.kernel.org X-Gm-Message-State: AOJu0YyAxvN7JZfjS4Q4EgM74YTtSv3ZdHNu++20bWKMSDwnuO1gWeVV aAM/WocjNcIYIVMVUdg3zs061B4E5lSkhOm+b8hzlghQIM0QeOF0fGAR/JMCRS6R8YzE0dZ115V H8pp5dhxhcmDuf4qJV57E+ydUqoGNYbG25S8QdbtXAlH1ElgWCaQCm0TcL57JfhQ= X-Gm-Gg: ASbGncsjFxEJGXHQVLAwElh5VWnWuSqErudB9+vsRfWS24nQPCNA0oeGatYkYUJPlYm 83jN4DXZZqaLK77mauDhTbXMPficleky+2z4gYnPjqPF0x/TYyrKHLxqK4FUubhScUWRXCIjbKF yaT07GtL6eyYDtIOiAaaYN9eLtBSuYIsEFDtjRhLp+Q/5wKi1haPoJlPafLZ0QoK4Um00vDRFCu PEFvAEPm1owwxN8zG9iYVhYT6T0O60dT+zYG1E8V7TXqFSBay/cfaMqOEKwvKY+Ychz4pcdnKNR S7K5+ATgoWfAIeH37QmfDVr6OZ25Ji9goqG1SOxZX4Y23w2qCJ+L6DHdXQLZ+j9VoX0Q5A== X-Received: by 2002:ad4:5be2:0:b0:6d4:2db5:e585 with SMTP id 6a1803df08f44-6e6ae7d85e7mr22638826d6.1.1740165797728; Fri, 21 Feb 2025 11:23:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IEhe3D2pb35rVzYTf0irYbfcNunEhouF+kKjaEaBYD9eenWOnmtYKYr2TVvZBWUT1AJ8DrVIQ== X-Received: by 2002:ad4:5be2:0:b0:6d4:2db5:e585 with SMTP id 6a1803df08f44-6e6ae7d85e7mr22638616d6.1.1740165797364; Fri, 21 Feb 2025 11:23:17 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abb7f766313sm1255261366b.142.2025.02.21.11.23.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Feb 2025 11:23:16 -0800 (PST) Message-ID: <916d3d13-acf1-4ae9-81f3-7539172ee8aa@oss.qualcomm.com> Date: Fri, 21 Feb 2025 20:23:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] PCI: dwc: pcie-qcom-ep: enable EP support for SAR2130P To: Dmitry Baryshkov , Manivannan Sadhasivam Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Mrinmay Sarkar , Bjorn Andersson , Konrad Dybcio , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250217-sar2130p-pci-v1-0-94b20ec70a14@linaro.org> <20250217-sar2130p-pci-v1-4-94b20ec70a14@linaro.org> <20250220072310.kahf4w4u43slbwke@thinkpad> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Cixw1ifO2ubJKrgVwMNrM6BjO2fD44Ci X-Proofpoint-GUID: Cixw1ifO2ubJKrgVwMNrM6BjO2fD44Ci X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-21_07,2025-02-20_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502210133 On 20.02.2025 11:50 AM, Dmitry Baryshkov wrote: > On Thu, Feb 20, 2025 at 12:53:10PM +0530, Manivannan Sadhasivam wrote: >> On Mon, Feb 17, 2025 at 08:56:16PM +0200, Dmitry Baryshkov wrote: >>> Enable PCIe endpoint support for the Qualcomm SAR2130P platform. >>> >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c >>> index c08f64d7a825fa5da22976c8020f96ee5faa5462..dec5675c7c9d52b77f084ae139845b488fa02d2c 100644 >>> --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c >>> +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c >>> @@ -933,6 +933,7 @@ static const struct of_device_id qcom_pcie_ep_match[] = { >>> { .compatible = "qcom,sa8775p-pcie-ep", .data = &cfg_1_34_0}, >>> { .compatible = "qcom,sdx55-pcie-ep", }, >>> { .compatible = "qcom,sm8450-pcie-ep", }, >>> + { .compatible = "qcom,sar2130p-pcie-ep", }, >> >> Could you please use a fallback? I'd prefer to not add compatible to the driver >> unless it requires special config. > > This is a tough question, I have been thinking about it too. But granted > the differences in clocks used by the controller I opted to use > different compat strings without a fallback. I think it would be hard to > describe the schema otherwise. You could use if-else ordering or is: instead of contains: but I don't mind Konrad