From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D1A12F5485 for ; Thu, 11 Jun 2026 04:54:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781153696; cv=none; b=H4uZliOGCBio97olzGVT59kYPsGUrdouhJrz/2WoS3oNc2bYD6l283fLyeNcSbrhy0l9rgQuCSPRQAs2tfyPaXDzY9BkKPACJgJJg5Wz5+Jbge1zIdStabXRO3LrDh7p2DPwgviK1NdWrEfnv2zt6kNWM6Kt2XCAgCjeWvNX0VM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781153696; c=relaxed/simple; bh=eZTJpv0lWzXAbqYFtSH4R/r3awGM3N6CDGmuQF90vUc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ThzBWU+Se59gtiBpM+GxAxnPV8MoyFRU0D5XvUoEzLWKYeAwud8DckkpvmX+tllUQdG/run0rbMsh5j5x07SbwY5Qu31VXs/z5plluCqgO8XaTWKVc0D/Ug8qPijEmZPIWcYksr66aFy1WM0HuxodfG4UaLnJXSNE8a38snb7jY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=h0kAO2XZ; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="h0kAO2XZ" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65AJu58E4146558; Thu, 11 Jun 2026 04:54:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=H+z6az S+N00F6ldHNHxBN5F0o4OUi+zrHlSCZxmylkg=; b=h0kAO2XZGRZC4AcT0d5/4t EnvSGuCp9AcyIggGAeZG+FWT/ACWXn3UGKn+RRu5Qe62HNgfPTKOOgfxmqXedskM KK+EY9r7KbELkhiwBanx5zSSCElDWpdm7oPVJM6d5MaqXNnEHVJ4DWx/HBGdeHk6 xUKQDrEpUfXR6qcY8dCw4g72PtTyLRJhUP2S2CbbotOhxt0B2mMxH8sW7k9ogooK GQaCxMKPRnh34W5/jgk+Gd9S7ParOlfzzcG2jm15Y5b+9ags4OaHF6/70RSKaTku AVuRevQTf7nly7xAJCKQifdxfoRB2k/SPDhRKq/meeQD+tFpr3ME8xvEtSK2BISA == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4eqe8c1ft3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Jun 2026 04:54:39 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 65B4nhdm006049; Thu, 11 Jun 2026 04:54:38 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4eqe09sp7j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Jun 2026 04:54:38 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 65B4scJ954657328 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Jun 2026 04:54:38 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DD95858043; Thu, 11 Jun 2026 04:54:37 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 78E5558055; Thu, 11 Jun 2026 04:54:34 +0000 (GMT) Received: from [9.43.60.77] (unknown [9.43.60.77]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 11 Jun 2026 04:54:34 +0000 (GMT) Message-ID: <917afe98-75bc-4237-a9fa-7888b37dd3f6@linux.ibm.com> Date: Thu, 11 Jun 2026 10:24:32 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/15] nvme: add Clang context annotations for nvme_queue::cq_poll_lock To: Keith Busch Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, hch@lst.de, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, elver@google.com, gjoyce@linux.ibm.com References: <20260610142743.115898-1-nilay@linux.ibm.com> <20260610142743.115898-13-nilay@linux.ibm.com> Content-Language: en-US From: Nilay Shroff In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDA0MiBTYWx0ZWRfX8Gyq2GVo8TmG WQg0jUms+Ep1kxJoSi+ZMO4QEF/4FP4ZW8AqX5gjWgmNcPTWqPdZLcURvLGHSGIxCxzyVn0St/A mTUjDSQX4e1/LNyFrjgz4bnnnmIyE4g= X-Authority-Analysis: v=2.4 cv=AYCB2XXG c=1 sm=1 tr=0 ts=6a2a3f90 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=-BXssvoQmy4FsglJak8A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: IyGLlf64j6KKPiQPbeE38_IdVS3IxvKP X-Proofpoint-ORIG-GUID: ARVgYIszUWeUNbeRqIPJgq7xh3VJqXvG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDA0MiBTYWx0ZWRfX3QRfjROrcstS LqS8WZkM2WxYv3amGdX9vLLZxvJtoPgnXqg6MSdDGR5BoegzE2W7vUXSdilJxGQ4MuBDranHypj 8sXPm8YQb0Bi8dbJ7Tn72HW8Mv7M/gRAVUA9pnpCekvPjQABCCMYUkAYjLPaVijcsZgLUVbpgs2 9L3LSdLe310iQi+g9KzflTvb+LoDdhUOELRtMsQPB0fGR95vX4QicET6f99VtMTuj1fD72T69d8 rkps/j9KkMEV5L2k+nvB8T5L2cTinN3SU3pBp1KxeA9y3YwS5O73ESwMWT3bYgkoXa1nRm7dA3F U0p60hBLjc2LuGG0Rbfr0WzrVSUUofpPAe+Pn8ylzK1fvUM4YdFVSopvE7lqufZx1+1bOxWn9sM cYBv2UoXuspXXuDkEIidtwGOx/QgLBxMYQ4B3SxTO6d4bARN5SbN2naOH/aPtYFWYEPCMr4sdv2 xEGk/yFrjAPqHWuiM3g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_01,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110042 On 6/10/26 10:16 PM, Keith Busch wrote: > On Wed, Jun 10, 2026 at 07:57:32PM +0530, Nilay Shroff wrote: >> Fix the warning by acquiring nvme_queue::cq_poll_lock before invoking >> nvme_cqe_pending() in nvme_poll(). > > The check outside the lock was done on purpose, though. Oh okay, I didn't know that. In that case we could skip the locking around nvme_cqe_pending() and silence the compiler warning using context_unsafe(). Thanks, --Nilay