From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753044AbcC1ANl (ORCPT ); Sun, 27 Mar 2016 20:13:41 -0400 Received: from gloria.sntech.de ([95.129.55.99]:49910 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752037AbcC1ANk convert rfc822-to-8bit (ORCPT ); Sun, 27 Mar 2016 20:13:40 -0400 From: Heiko Stuebner To: Xing Zheng Cc: linux-rockchip@lists.infradead.org, huangtao@rock-chips.com, jay.xu@rock-chips.com, elaine.zhang@rock-chips.com, dianders@chromium.org, Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 4/4] clk: rockchip: add clock controller for the RK3399 Date: Mon, 28 Mar 2016 02:13:34 +0200 Message-ID: <9181730.v9nyazlRXy@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1458974276-10325-5-git-send-email-zhengxing@rock-chips.com> References: <1458974276-10325-1-git-send-email-zhengxing@rock-chips.com> <1458974276-10325-5-git-send-email-zhengxing@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xing, Am Samstag, 26. März 2016, 14:37:56 schrieb Xing Zheng: > Add the clock tree definition for the new RK3399 SoC. > > Signed-off-by: Xing Zheng > --- [...] > + /* > + * We use pclkin_cifinv by default GRF_SOC_CON20[9] (GSC20_9) setting in > system, + * so we ignore the mux and make clocks nodes as following, > + * > + * pclkin_cifinv --|-------\ > + * |GSC20_9|-- pclkin_cifmux > + * pclkin_cif --|-------/ > + */ > + GATE(PCLK_ISP1_WRAPPER, "pclkin_isp1_wrapper", "pclkin_cifmux", please name that source clock pclkin_cif as in the TRM. pclkin_cif is the actual input clock - if I'm reading the TRM correctly and the inverter is part of the soc or so? That we currently hide / hardcode the phase-handling should not be part of our outside connection - which should be stable even if we implement this later. Heiko