From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754478AbdEEN5v (ORCPT ); Fri, 5 May 2017 09:57:51 -0400 Received: from mout.web.de ([212.227.15.3]:64349 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837AbdEEN5t (ORCPT ); Fri, 5 May 2017 09:57:49 -0400 Subject: [PATCH 5/5] drm/sti: Adjust two checks for null pointers in sti_hqvdp_probe() From: SF Markus Elfring To: dri-devel@lists.freedesktop.org, Benjamin Gaignard , David Airlie , Fabien Dessenne , Vincent Abriou Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <918229e6-80fe-629f-8fec-bf60ac15275f@users.sourceforge.net> Date: Fri, 5 May 2017 15:57:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:ek5AiG9n12MOYO5vqXIKb1yFqy3HjtYbUzsoiTC1GLd2EzWAHOx rWnkDqiM5gI7W+tSAITCvEB9TxysCL5Lo6lgfUjkM4LMrkmGtgs1uSWcJBZXO7mxxzV1ElQ P6vgxuUqAq5mM5C3rNIYGYuZBQLdTxzCMQHySZy19uSVwGZFwffizsSePG/3Qrhy0CL4FDw 2XpBvIJ9RzciBmghADUZQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:yV9navpzm2A=:pRUFRKOaHVnrkdH0tgBj45 MUOXN5zfT+6qzFr5CQ8r70jrmWZZ1OnESFcRDkrExu6+26PkPSl4qDkcJan8NQ77ZtVqaEhlY Vfq9cOo0YPdl4pCiMR7TOMA2n2FyxxLQJN69g0s2el/bSRANOhe3Lv5983qBX6/OIFUaOsF03 wk8uxVSm0sDrTdd/VciH+ANtz0Pya57FvH/oVPIkYuikl5+mN5I++/V6aQ/LP50IRmzveS+7y ECm2c3Ws2YQ0BBhUL8SVJRUtkrfhcRKDkL2zZVvaY33PcrVTCSI8LA7sDS2H79ZrUe3JbmtGi 2QDZVK5NP+JYCD04W/nnlIW1H4vetDDyTFc1tvvRWROt17Z1+I5z4ChRLNbYE3sPe8QF51ANd EC3nswD3WBLJI9OsS9SINKJEIEuDpQGVZcnqsAFPE8EjWi4K7NraIbQ3O+CWxGev9NDwYXJK3 akhAWGglWP0yW9pbIBolbtx7IqqhFiaIjUuQbSkHf5zWap8oyOPJcHwx+vJ6iygSqc2nvuCMZ djoCegedKweNtX6WlQ/c9TrkzhSa2w8KATTVTAGMX5Otpe92mVGhQS/i/iZDwVWLn672+PAnX EcU4fVoPXnabegvWhgGiZ940aafrHkmvkxiPMwxigEFvfPUiayAurX8j7S+5HH3QiDMtin/Z+ B0cmagJ1ED4S0cwI2nuhX7D73KmACwezhPgmaDGuCWkzEBzLsQBWyRfEA4JyQCnS2cWD7yr2S yzEiNDDDM31G4EdV13wDWPSRnGJ5QpJuJkh7D8/gtwaVQ478C/bUt4Sxvrzoly1O5RMrccnFS 9gVN4c5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 5 May 2017 15:33:19 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/gpu/drm/sti/sti_hqvdp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c index 372ea294da80..a1c161f77804 100644 --- a/drivers/gpu/drm/sti/sti_hqvdp.c +++ b/drivers/gpu/drm/sti/sti_hqvdp.c @@ -1356,12 +1356,12 @@ static int sti_hqvdp_probe(struct platform_device *pdev) /* Get Memory resources */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (res == NULL) { + if (!res) { DRM_ERROR("Get memory resource failed\n"); return -ENXIO; } hqvdp->regs = devm_ioremap(dev, res->start, resource_size(res)); - if (hqvdp->regs == NULL) { + if (!hqvdp->regs) { DRM_ERROR("Register mapping failed\n"); return -ENXIO; } -- 2.12.2