From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Richard Weinberger <richard@nod.at>, <linux-mtd@lists.infradead.org>
Cc: <david@sigma-star.at>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH 1/4] ubifs: Correctly set inode size in ubifs_link()
Date: Sat, 23 Jan 2021 10:35:56 +0800 [thread overview]
Message-ID: <91b23161-db4a-4d64-db30-e42e2eaade1e@huawei.com> (raw)
In-Reply-To: <20210122212229.17072-2-richard@nod.at>
在 2021/1/23 5:22, Richard Weinberger 写道:
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
> index 9a6b8660425a..04912dedca48 100644
> --- a/fs/ubifs/dir.c
> +++ b/fs/ubifs/dir.c
> @@ -693,7 +693,7 @@ static int ubifs_link(struct dentry *old_dentry, struct inode *dir,
> struct inode *inode = d_inode(old_dentry);
> struct ubifs_inode *ui = ubifs_inode(inode);
> struct ubifs_inode *dir_ui = ubifs_inode(dir);
> - int err, sz_change = CALC_DENT_SIZE(dentry->d_name.len);
> + int err, sz_change;
> struct ubifs_budget_req req = { .new_dent = 1, .dirtied_ino = 2,
> .dirtied_ino_d = ALIGN(ui->data_len, 8) };
> struct fscrypt_name nm;
> @@ -731,6 +731,8 @@ static int ubifs_link(struct dentry *old_dentry, struct inode *dir,
> if (inode->i_nlink == 0)
> ubifs_delete_orphan(c, inode->i_ino);
>
> + sz_change = CALC_DENT_SIZE(fname_len(&nm));
> +
> inc_nlink(inode);
> ihold(inode);
> inode->i_ctime = current_time(inode);
>
next prev parent reply other threads:[~2021-01-23 2:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 21:22 [PATCH 0/4] Assorted UBIFS fixes Richard Weinberger
2021-01-22 21:22 ` [PATCH 1/4] ubifs: Correctly set inode size in ubifs_link() Richard Weinberger
2021-01-23 2:35 ` Zhihao Cheng [this message]
2021-01-22 21:22 ` [PATCH 2/4] ubifs: Don't add fscrypt context to xattrs Richard Weinberger
2021-01-22 21:22 ` [PATCH 3/4] ubifs: Update directory size when creating whiteouts Richard Weinberger
2021-01-23 2:45 ` Zhihao Cheng
2021-01-23 10:05 ` Richard Weinberger
2021-01-25 1:05 ` Zhihao Cheng
2021-01-25 7:55 ` Richard Weinberger
2021-01-25 9:31 ` Zhihao Cheng
2021-01-22 21:22 ` [PATCH 4/4] ubifs: Harden ubifs_jnl_write_inode() Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91b23161-db4a-4d64-db30-e42e2eaade1e@huawei.com \
--to=chengzhihao1@huawei.com \
--cc=david@sigma-star.at \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox