Re: [PATCH v3 2/2] x86/resctrl: Simply call convention for MSR update functions

Reinette Chatre
2024-02-27T22:05:23Z

Hi Tony,

On 2/22/2024 10:50 AM, Tony Luck wrote:
> The per-resource MSR update functions cat_wrmsr(), mba_wrmsr_intel(),
> and mba_wrmsr_amd() all take three arguments:
>
> (struct rdt_domain *d, struct msr_param *m, struct rdt_resource *r)
>
> But struct msr_param has always contained the rdt_resource, and now
> contains the rdt_domain too.
>
> Change to just pass struct msr_param as a single parameter. Clean
> up formatting and fix some firtree parameter ordering.

Please stick to imperative tone. For example (feel free to improve):
struct msr_param contains pointers to both struct rdt_resource
and struct rdt_domain, thus only struct msr_param is necessary.

Pass struct msr_param as a single parameter. Clean
up formatting and fix some fir tree declaration ordering.

The patch looks good to me, thank you.

Reinette