From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753106AbdLYROI (ORCPT ); Mon, 25 Dec 2017 12:14:08 -0500 Received: from mout.web.de ([212.227.17.12]:60275 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbdLYROD (ORCPT ); Mon, 25 Dec 2017 12:14:03 -0500 To: linux-gpio@vger.kernel.org, James Hogan , Linus Walleij Cc: LKML , kernel-janitors@vger.kernel.org, Grant Likely , Rob Herring , Rob Landley From: SF Markus Elfring Subject: [PATCH] pinctrl: tz1090: Delete an error message for a failed memory allocation in two functions Message-ID: <91c76055-bba2-8a6e-4294-1dae0daf1363@users.sourceforge.net> Date: Mon, 25 Dec 2017 18:13:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:pGpqIss9MsrdIH5TsgnWAeGMI2QNohCDTGZ02mpMUuIIiaaFafk RKsPJMyv5dw5qqgqZHEeQS+c+lIT2CNxgtbgPLGkA+Br3utSweEhnZ4kR8QVajN968dz4HN bSW6EC9XCfUmraIReZXiDhuKP2t4NKkU0/d+SY+WDiJmhNPzY+050wdQTDVRAhkEA8+cR7t BfYXCFXiXUqLeXbVzGETQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:QfdJ5NuAp2I=:dXg5F5x7E1CJJEt6G2wu3r aHEx6g+W97ozhqivVO8SvgYInhjp52LU+4xKHfgtTAS5PUUBYmHOGmGyXjWzFpFYQThisc3Ty G65qXtJFvTX/H5b1yEs+bMp8WELVPXw46q0RPDhluUm+G/jJond/eNwPtP4rtw1G8JW6Ssb8f c7FrrOhujujCjuHL7FexHnmtBBYkHCmlnYvu9BlMuJZv59xT2oImYqoc806JIykTFjSnI6UKL 9z2A5ZCaONJxuzfKtTB1OY1BgvT3U4nWlxJUddiPDQOrYWkhVNUJCR+5IvX3a9EpgUC/T89Yu UHHP9gy9nwyxQoRKXqfAF2eER7CiQqbvqTDAhZDEVfNSOa0jJ0LLs0xpQr2qBmdJKe+g7vDJd bYyauo/VdG8PfoTQrKZZHEzbTL7eMTEzF2yQziJiGOB3kDCgds0M6o5iW+ABzP82uZdDhefBl 2gKgT46nJU2meEL/EwIo0+aHm/Rus8tfrZ2tS22rZwBMSRW9wew2rydqzB7zO02xX89ngSFrf 2dVJaHxWHv5pH3f3BRByZtSVAITaUPFI+nyZcajgLXcT1bxW57vLcZKA5b8s2mEE4fmm2EoPR 62RgJoxGwvK+i++XscbrdzkHFgy9TVGICiOtPokhd8YHDLg5LtKdoZ7daQEBGnH6P/aZW3W6H FJmQUTkdMLnZkH8pBurVj4Bl0UIAH3SjQzskDq0y6e27mNvHEc9HfLjgkCz2XxCeH5EtyV/V3 txrxvmreIzu0KYKFytTPY0UWEHi8HoCsTjCFgk0Wt6AXBEcUMz1ZEfKDwSPW1WfnhMWXH2S85 eCvBAmcidz8p1p1UgmMI72bcYQWBz1xFM4S+nVjaBLURjY///w= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 25 Dec 2017 17:55:48 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/pinctrl-tz1090.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-tz1090.c b/drivers/pinctrl/pinctrl-tz1090.c index 74d1ffcc2199..2379ce2be365 100644 --- a/drivers/pinctrl/pinctrl-tz1090.c +++ b/drivers/pinctrl/pinctrl-tz1090.c @@ -1082,10 +1082,8 @@ static int add_map_configs(struct device *dev, dup_configs = kmemdup(configs, num_configs * sizeof(*dup_configs), GFP_KERNEL); - if (!dup_configs) { - dev_err(dev, "kmemdup(configs) failed\n"); + if (!dup_configs) return -ENOMEM; - } (*map)[*num_maps].type = PIN_MAP_TYPE_CONFIGS_GROUP; (*map)[*num_maps].data.configs.group_or_pin = group; @@ -1946,10 +1944,9 @@ static int tz1090_pinctrl_probe(struct platform_device *pdev) struct resource *res; pmx = devm_kzalloc(&pdev->dev, sizeof(*pmx), GFP_KERNEL); - if (!pmx) { - dev_err(&pdev->dev, "Can't alloc tz1090_pmx\n"); + if (!pmx) return -ENOMEM; - } + pmx->dev = &pdev->dev; spin_lock_init(&pmx->lock); -- 2.15.1