public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nathan Morrisson <nmorrisson@phytec.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	catalin.marinas@arm.com, will@kernel.org,
	quic_bjorande@quicinc.com, geert+renesas@glider.be,
	konrad.dybcio@linaro.org, shawnguo@kernel.org,
	neil.armstrong@linaro.org, arnd@arndb.de,
	m.szyprowski@samsung.com, nfraprado@collabora.com,
	u-kumar1@ti.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, upstream@lists.phytec.de,
	w.egorov@phytec.de
Subject: Re: [PATCH] arm64: defconfig: Enable TI LP873X PMIC
Date: Thu, 6 Jun 2024 16:38:07 -0700	[thread overview]
Message-ID: <91d65552-a5ad-4daa-be0d-7a3544ec9fec@phytec.com> (raw)
In-Reply-To: <1bc38042-7034-4937-a2e6-2dcfd8c2d609@linaro.org>


On 6/5/24 12:15 AM, Krzysztof Kozlowski wrote:
> On 05/06/2024 01:38, Nathan Morrisson wrote:
>> Enable the TI LP873X PMIC configs.
> Why? No user of this, sorry. Please explain in commit msg why this
> should be done, e.g. which upstream user needs it.

This will be used by the phytec am642-phyboard-electra, but the patch 
[1] has not been accepted yet. I will fix the other issues in a v2 as well.


[1] 
https://lore.kernel.org/lkml/aac6a41f-a384-43c5-8eb0-722cda74b4ea@phytec.de/


Regards,

Nathan

>
>> Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
>> ---
>>   arch/arm64/configs/defconfig | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 57a9abe78ee4..24ea62a8fdbf 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -745,6 +745,7 @@ CONFIG_MFD_SEC_CORE=y
>>   CONFIG_MFD_SL28CPLD=y
>>   CONFIG_RZ_MTU3=y
>>   CONFIG_MFD_TI_AM335X_TSCADC=m
>> +CONFIG_MFD_TI_LP873X=y
> Why this cannot be m?
>
>>   CONFIG_MFD_TPS65219=y
>>   CONFIG_MFD_TPS6594_I2C=m
>>   CONFIG_MFD_ROHM_BD718XX=y
>> @@ -760,6 +761,7 @@ CONFIG_REGULATOR_FAN53555=y
>>   CONFIG_REGULATOR_GPIO=y
>>   CONFIG_REGULATOR_HI6421V530=y
>>   CONFIG_REGULATOR_HI655X=y
>> +CONFIG_REGULATOR_LP873X=y
> Why this cannot be m?
>
>>   CONFIG_REGULATOR_MAX77620=y
>>   CONFIG_REGULATOR_MAX8973=y
>>   CONFIG_REGULATOR_MAX20411=m
> Best regards,
> Krzysztof
>

      reply	other threads:[~2024-06-06 23:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04 23:38 [PATCH] arm64: defconfig: Enable TI LP873X PMIC Nathan Morrisson
2024-06-05  7:15 ` Krzysztof Kozlowski
2024-06-06 23:38   ` Nathan Morrisson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91d65552-a5ad-4daa-be0d-7a3544ec9fec@phytec.com \
    --to=nmorrisson@phytec.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=geert+renesas@glider.be \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=neil.armstrong@linaro.org \
    --cc=nfraprado@collabora.com \
    --cc=quic_bjorande@quicinc.com \
    --cc=shawnguo@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=upstream@lists.phytec.de \
    --cc=w.egorov@phytec.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox