From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C78C72F26 for ; Sun, 24 Nov 2024 17:28:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732469321; cv=none; b=hA7o2XvGpF1X6n4TrvxljOX7hPoMpwiY2+dT3DCyT9r3isP5/5KnfyYkwj1l6yqBe+z+dunUqxAz4Sj64glLZUAphd/7O8j3XfNSYc4K3MnDkYbofxq2Q6aR/EyXYikmw1l05xKHVFg8Ry1zzv5bNVQ1ZtHd/sX+Zt6KiI2A8jw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732469321; c=relaxed/simple; bh=Lrh/VMhFsmPsXghhCugJTmIbIcEhYH7n6mKX8kHDUsw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fKYUMH/DPnn43/lohdRm3fhID3qkbCkh/X6wMFrUqTZbWKsMpNVdA/pWfJ0PKhjzvsB6cxoeMYDMnQ1cUWqHEOtUSY0y24Y0rDotevqagO6MISh/2S2J72o3yIERcSt6ZT59u4rgMT8aii5sdt+c8P5o+QHGZsmdmgn1Ppru0Tg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=phE1bnRu; arc=none smtp.client-ip=91.218.175.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="phE1bnRu" Message-ID: <91dcbf49-fcef-44e9-aa78-415fd70cba9d@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1732469317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QMREzF/1nhtk4WfzOZ1mGniS/0dmFZlSzW3aXWHoBpI=; b=phE1bnRulaAKiria+VyImMr1gIR7wOSPIJlNXqT2zOSwZojGAOhTdXZZM5jFgPpE++Dwwl S6ESS442uh9mlyppRXM0AjhI/YkwhyAibW4HY4Pcvot5Pvt/QiUZ135jDNwB1YsBAVgM1N 9aEUmRndK19xV562KCHKql0ik9vsYws= Date: Sun, 24 Nov 2024 22:58:10 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 5/7] drm/tidss: Clear the interrupt status for interrupts being disabled To: Tomi Valkeinen , Devarsh Thakkar , Jyri Sarha Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jonathan Cormier , stable@vger.kernel.org References: <20241021-tidss-irq-fix-v1-0-82ddaec94e4a@ideasonboard.com> <20241021-tidss-irq-fix-v1-5-82ddaec94e4a@ideasonboard.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Aradhya Bhatia In-Reply-To: <20241021-tidss-irq-fix-v1-5-82ddaec94e4a@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 10/21/24 19:37, Tomi Valkeinen wrote: > From: Devarsh Thakkar > > The driver does not touch the irqstatus register when it is disabling > interrupts. This might cause an interrupt to trigger for an interrupt > that was just disabled. > > To fix the issue, clear the irqstatus registers right after disabling > the interrupts. > > Fixes: 32a1795f57ee ("drm/tidss: New driver for TI Keystone platform Display SubSystem") > Cc: stable@vger.kernel.org > Reported-by: Jonathan Cormier > Closes: https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1394222/am625-issue-about-tidss-rcu_preempt-self-detected-stall-on-cpu/5424479#5424479 > Signed-off-by: Devarsh Thakkar > [Tomi: mostly rewrote the patch] > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Aradhya Bhatia Regards Aradhya [...]