public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Balakrishna Godavarthi <bgodavar@codeaurora.org>
To: Harish Bandi <c-hbandi@codeaurora.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Matthias Kaehlcke <mka@chromium.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org,
	linux-arm-msm@vger.kernel.org,
	linux-bluetooth-owner@vger.kernel.org
Subject: Re: [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts
Date: Wed, 24 Apr 2019 12:38:44 +0530	[thread overview]
Message-ID: <91deac040a35235e52079cdbdef2f425@codeaurora.org> (raw)
In-Reply-To: <96d661afb42cd4c6605cf7e2fbec7478@codeaurora.org>

Hi Harish,

On 2019-04-24 12:34, Harish Bandi wrote:
> Hi Balakrishna,
> 
> On 2019-04-23 22:05, Marcel Holtmann wrote:
>> Hi Balakrishna,
>> 
>>> When flag HCI_QUIRK_USE_BDADDR_PROPERTY is set, we will read the
>>> bluetooth address from dts. If the bluetooth address node is missing
>>> from the dts we will enable it controller UNCONFIGURED state.
>>> This patch enables the normal flow even if the BD address is missing
>>> from the dts tree.
>>> 
>>> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
>>> ---
>>> net/bluetooth/hci_core.c | 2 --
>>> 1 file changed, 2 deletions(-)
>> 
>> can I get an ACK for this one?
>> 
>> Regards
>> 
>> Marcel
> 
> nit: it would be better if we print error message, if bd address 
> missing in dts.
> 
> tested 20 times with bd address missing in dts.
> tested 20 times with bd address available in dts.
> 
> Tested-by: Harish Bandi <c-hbandi@codeaurora.org>
> 
> 
> Thanks,
> Harish

Thanks for testing will note this improvement and send an incremental 
patch.

-- 
Regards
Balakrishna.

  reply	other threads:[~2019-04-24  7:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 13:21 [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts Balakrishna Godavarthi
2019-04-23 16:35 ` Marcel Holtmann
2019-04-24  7:04   ` Harish Bandi
2019-04-24  7:08     ` Balakrishna Godavarthi [this message]
2019-04-24  7:13 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91deac040a35235e52079cdbdef2f425@codeaurora.org \
    --to=bgodavar@codeaurora.org \
    --cc=c-hbandi@codeaurora.org \
    --cc=hemantg@codeaurora.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth-owner@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mka@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox