From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00D491FCD05 for ; Tue, 14 Jan 2025 20:37:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736887050; cv=none; b=jG5GHw8pr4CB3h/QtLzkRfxEnqN2hgOhI4v239niS6/ZtidllLShMWuoQVhWrAIfylWjNGIGuOH2nndXn2Xit06e/5iG5CEmajyHFPrh43oK3ev6rVg1FMg58M8i5MHfsyqYHdqfiR5F4PIHvSSBEfyalJ4X1Ihch1KN4nDe8x0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736887050; c=relaxed/simple; bh=1yIXschKcFgfPqf4mQndcTi+ghzJQWk9Ao057RSgy9U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TsNUYxdB06UJhIlb+SeMgPYE6U/NZQ9KzR9e83t6o1NMMo/35TdOO0b+1IGD8kB8Dq3WnKtyJJWpXRWdcHgR7dKTcQo7FDkOSgKycDwkJoUxmTzN3MXECyXLRjfdszTCEppoo79oOG+nRhhrsbO6jbsJ5Tsao+96dF6u+0aDF10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FX+WO0yf; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FX+WO0yf" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-ab322ecd75dso31559266b.0 for ; Tue, 14 Jan 2025 12:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736887044; x=1737491844; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=TM+Uv2rAwVXzhOGxP6KAZNgm9EHUs0viW3Tg49mr9j0=; b=FX+WO0yfoxJKDMYE0498uJMItTVAUIYtD4n3xbChwzflDAqKXF9kceVdJyGqjuRJtr /UOU4uq1TMs/htuW8FjSr0sXoKbuGT0l+646U3O5F7tdprU73FeSNyoHJ0rmtuMGRyTZ GKfKF6w0JrLTF7Aftx4OkMW9rJtR8O7V50aj+cuy1YdQ1P29oxr5eA3EPfuyb+g1Br0+ VJvFq+uZ4+0494mtIwYvCTLfZGZn8Mq+CWFnbSSwUvjJDlVYv5KDW2Q6x7FkLtWBXgPX E5oAQrf1A+PDZaZq32ISecCV4qbB0xAkZsXCcp2pDoihoyhuDqY9akfLD6y3g2Avx0aU DDYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736887044; x=1737491844; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TM+Uv2rAwVXzhOGxP6KAZNgm9EHUs0viW3Tg49mr9j0=; b=Rkr7Z8jWoY9slxKiAhMdAvFqweGnqgi06rkTsojaCURsYtywgXgSE7f+52MLx2+ajz GYBRu+ZOviR5Ljia93JbrIIwyC7L7vfAX/VpF12xMX7e+XYjdQrycwHaTuNgdZ3FQs/v 8ZM+5QZI2oJUQlVixLKydq2gAt3DFJzmMWSXIv8/Ms51eZ1HAKqet+aZSGEfPJJfjKIE Jkcyqdl/zZHjDItHWcEIu8k6H2mjEAJIyChxXhUx1b2rqdXV+2OkDDE8B2GVrMp6H79q 1pM+i0GVUiKIcKD/KW0cEoFWq0yPoyJcB1aFSX2G0Vna4C7yEaQuaq3MkVmJxHOYf9N4 rQHA== X-Forwarded-Encrypted: i=1; AJvYcCV13MWij5DyyKC0wSQmI+UUCtV1kHjXOiSPdyQk2NfQuyCVlQjJICN+J1Hk7oX6yCuw8ji/44+OKtExYOY=@vger.kernel.org X-Gm-Message-State: AOJu0YzdOvdrspHOmYlQnab17frydU/3NdkOiw3gnoqu2gCxnCoUwUPO NX3tagmI8w0SGa+HamFZXhpyGJCfMuyJsKTtgTsHO4KmRlj2H/sO X-Gm-Gg: ASbGncuNhTxIoZ8THgn0RLp6R19FQoL+otSnvkdrEtGYqBVxT0r8LaK4lK/ko2/VFZS omqimAGLMO9DCbXxJyA1qBlkR1z4aIKlZfUojg0AXinZQ7sSzvgd78Nq+QisCSdFaWtPzh6757u hWXNz4j7ov9OVJyrCFuelTLbpiw2gSBWnvz0wXr3PPbl9jhcGzDYa294YnU4zQHstOfdQDFyQHk LDYlOZnENefoj2G2nVtdURfXO4aJDAc6qHd5HCtq/XDxKWhHQf4fUP4L5vqB4ybIaZDVH2nqn9h yw9+z3d69e5iMlWnZg1r/s/WiZotxZ8= X-Google-Smtp-Source: AGHT+IFQEXml/UJ1SmO7RTz8cpqU1evb6c+nigxt0ziAHVC34T7jXKhSq8MBqe+UKpQJZTg3WhWgHA== X-Received: by 2002:a17:906:dc92:b0:aa6:7c8e:808c with SMTP id a640c23a62f3a-ab2c3cb6e09mr2218493566b.17.1736887043902; Tue, 14 Jan 2025 12:37:23 -0800 (PST) Received: from ?IPV6:2a00:f41:900e:91ba:e7d6:162b:2195:d63b? ([2a00:f41:900e:91ba:e7d6:162b:2195:d63b]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c9060bccsm663468466b.22.2025.01.14.12.37.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 12:37:23 -0800 (PST) Message-ID: <91e2bd5b-71fa-402a-82cb-e68d3295804a@gmail.com> Date: Tue, 14 Jan 2025 21:37:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] spmi: Fix controller->node != parent->node breakage To: Stephen Boyd , AngeloGioacchino Del Regno , Joe Hattori , Konrad Dybcio , Matthias Brugger , Mauro Carvalho Chehab Cc: Marijn Suijten , linux-kernel@vger.kernel.org, Bjorn Andersson , Abel Vesa , Johan Hovold , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Konrad Dybcio References: <20250113-topic-spmi_node_breakage-v2-1-dd35a3a6daa6@oss.qualcomm.com> <5b139af8d639e20a14c8bd00e8e03a4a.sboyd@kernel.org> <58cb6c37-0ea0-4866-a2b1-92cb0f0391a7@gmail.com> <305d7cf5f0a66efc01181f24d3a288d3.sboyd@kernel.org> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konradybcio@gmail.com; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzSVLb25yYWQgRHli Y2lvIDxrb25yYWR5YmNpb0BnbWFpbC5jb20+wsGRBBMBCAA7AhsDBQsJCAcCBhUKCQgLAgQW AgMBAh4BAheAFiEEU24if9oCL2zdAAQVR4cBcg5dfFgFAmQ5btACGQEACgkQR4cBcg5dfFhw JBAAp7+SFJq0oGQ21dulLrJZx1s1RfNi35SKegi+ueLOezipsfD9s2weu37/xE+PQ9ONDm39 Uq+plABz8grTgy19N5RZnY2gQNcN335fQWq31wk6OEhr3E04hBx94eejKI9ynXJUXOddwjCm blrqUnAhWCq0lM2Dsj1d1qUKF2wSTiQW4aNkc6izUgmGuY26WNfD52T5RHvGi8XtCNAKI1yK cCTmRY0zXIdR3bp+FnJHetjwy1ScbDiruhnaad31plRy4a+CxNeplUjWecufnWYCR3xFypNE TZm+z23CgUVmYQPNZZGO4h0SaRxnHhsewtlC9+DSaKm+7RzfbNbGRg6kxL2YG9PEqA64LAQI Vl0zkuF8xyGFcPioJ5Bg9UaN8M81xPuPwrN+Sb/PXgC/RKQ59hXI6fNAHoP9XwAAus5j0oRg BJb/+pXX9PQGtmIKJMp9l337VuCkXk/iaZ6HNWDumdeiUDA7m3vUHWVvsF5Xna+suUOSXPZ9 kwlbfHvfFpbuqr/VNN6qRpipx0vSvuDo5Ar4PoCuNDcHkmSlxMqqp8GG9oDi4cnl0XzirQpQ /rve1X50GUA7nVNagxQzvjRyZlcldVKHNIQXOR+XqEAwIGLRwqYo+iUOBZXFKHAS5EFooBJj 7QuEwSEWg7QYvOdXZOcmZGzGQa0Iq22KJgddx+DOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <305d7cf5f0a66efc01181f24d3a288d3.sboyd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/14/25 19:30, Stephen Boyd wrote: > Quoting Konrad Dybcio (2025-01-13 14:12:28) >> >> On 1/13/25 22:52, Stephen Boyd wrote: >>> Quoting Konrad Dybcio (2025-01-13 05:02:58) >>>> >>>> Make controller->node specifiable to both benefit from Joe's refcount >>>> improvements and un-break the aforementioned platforms. >>> >>> How is it broken? I see spmi_pmic_arb_bus_init() calls >>> devm_spmi_controller_alloc() which sets the of_node to the parent device >>> and then spmi_pmic_arb_bus_init() overwrites that with >>> 'ctrl->dev.of_node = node' later on in the same function. That will >>> cause one more of_node_put() than is expected. I don't see that removed >>> in this patch though, so the leak is still there? >>> >>>> >>>> Fixes: 821b07853e32 ("spmi: hisi-spmi-controller: manage the OF node reference in device initialization and cleanup") >>> >>> I've dropped this patch from my queue. I don't know if we're really >>> doing anything better by managing the of_node lifetime in that function >>> vs. letting the callers assign the node they want and manage the >>> lifetime themselves. Maybe we don't need to do anything? Presumably the >>> parent device driver will unregister the controller anyway, so the >>> lifetime of the of_node will be ensured regardless. For subnodes like >>> qcom SPMI, the subnodes are child nodes of the parent device so they >>> won't be removed. If they are dynamic nodes, then the caller can manage >>> the lifetime. >> >> Stephen, the wrong node gets assigned in the qcom driver with >> multi-master controllers, resulting in probe failures. >> >> Since the introduction of the commit referenced in fixes, >> of_spmi_register_devices() sees the controller's subnodes >> (which describe each of the two masters) as slave devices >> - meaning no "real" devices ever get to probe >> > > Ok, I see that I was reading the already reverted state of the tree > where the 'ctrl->dev.of_node = node' assignment came back. So there's > nothing to do besides drop the patch in fixes, which I already did. We > can then apply this patch to drop the duplicate assignment as a cleanup > and to avoid a refcount bump on the of_node that isn't needed. > > ----8<--- > diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c > index 3cafdf22c909..122140b97579 100644 > --- a/drivers/spmi/hisi-spmi-controller.c > +++ b/drivers/spmi/hisi-spmi-controller.c > @@ -300,9 +300,6 @@ static int spmi_controller_probe(struct platform_device *pdev) > > spin_lock_init(&spmi_controller->lock); > > - ctrl->dev.parent = pdev->dev.parent; > - ctrl->dev.of_node = of_node_get(pdev->dev.of_node); > - > /* Callbacks */ > ctrl->read_cmd = spmi_read_cmd; > ctrl->write_cmd = spmi_write_cmd; That works for me, thank you Konrad