From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751257AbeEDLZx (ORCPT ); Fri, 4 May 2018 07:25:53 -0400 Received: from foss.arm.com ([217.140.101.70]:52402 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbeEDLZv (ORCPT ); Fri, 4 May 2018 07:25:51 -0400 Subject: Re: [PATCH v1 03/13] drm/kms/mode/exynos-dsi: using helper func drm_display_mode_to_videomode for calculating timing parameters To: Satendra Singh Thakur , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Kukjin Kim , Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: madhur.verma@samsung.com, sst2005@gmail.com, Hemanshu Srivastava References: <00b4a624-d2b6-dc6a-71c0-9c7642480a44@arm.com> <1525421726-2817-1-git-send-email-satendra.t@samsung.com> From: Robin Murphy Message-ID: <920ac8d1-8d2d-1332-256d-21472f69fca5@arm.com> Date: Fri, 4 May 2018 12:25:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1525421726-2817-1-git-send-email-satendra.t@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/05/18 09:15, Satendra Singh Thakur wrote: > To avoid duplicate logic for the same > > Reviewed-by: Robin Murphy Please read section 13 of Documentation/process/submitting-patches.rst for what this tag means; specifically, it is definitely not "this guy read my patch". FWIW, in my case the patches I give trivial coding style comments on tend to be the ones I'm specifically *not* in a position to review in a technical capacity - the reason I'm looking at them in the first place is out of interest to learn more about how the relevant subsystems work. Robin. > Signed-off-by: Satendra Singh Thakur > Acked-by: Madhur Verma > Cc: Hemanshu Srivastava > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > index 7904ffa..7fe84fd 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > @@ -1490,17 +1490,8 @@ static void exynos_dsi_mode_set(struct drm_encoder *encoder, > struct drm_display_mode *adjusted_mode) > { > struct exynos_dsi *dsi = encoder_to_dsi(encoder); > - struct videomode *vm = &dsi->vm; > - struct drm_display_mode *m = adjusted_mode; > - > - vm->hactive = m->hdisplay; > - vm->vactive = m->vdisplay; > - vm->vfront_porch = m->vsync_start - m->vdisplay; > - vm->vback_porch = m->vtotal - m->vsync_end; > - vm->vsync_len = m->vsync_end - m->vsync_start; > - vm->hfront_porch = m->hsync_start - m->hdisplay; > - vm->hback_porch = m->htotal - m->hsync_end; > - vm->hsync_len = m->hsync_end - m->hsync_start; > + > + drm_display_mode_to_videomode(adjusted_mode, &dsi->vm); > } > > static const struct drm_encoder_helper_funcs exynos_dsi_encoder_helper_funcs = { >