From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756810AbbGQGkr (ORCPT ); Fri, 17 Jul 2015 02:40:47 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:45236 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbbGQGkp (ORCPT ); Fri, 17 Jul 2015 02:40:45 -0400 X-AuditID: cbfee68f-f793b6d000005f66-f5-55a8a36b1d43 Date: Fri, 17 Jul 2015 06:40:43 +0000 (GMT) From: MyungJoo Ham Subject: Re: [RFC PATCH 0/2] thermal: Add generic devfreq cooling device To: =?utf-8?Q?=EC=B5=9C=EC=B0=AC=EC=9A=B0?= , "edubezval@gmail.com" , "rui.zhang@intel.com" , =?utf-8?Q?=EB=B0=95=EA=B2=BD=EB=AF=BC?= Cc: "ulf.hansson@linaro.org" , "khilman@linaro.org" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , =?utf-8?Q?=EB=8C=80=EC=9D=B8=EA=B8=B0?= , Lukasz Majewski , =?utf-8?Q?=EA=B9=80=EA=B5=AD=EC=A7=84?= , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20150717064026156@myungjoo.ham Msgkey: 20150717064026156@myungjoo.ham X-EPLocale: ko_KR.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20150717064026156@myungjoo.ham X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <921188645.36001437115238708.JavaMail.weblogic@epmlwas08c> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsWyRsSkRDd78YpQg1ULzSwu75rD5sDo8XmT XABjFJdNSmpOZllqkb5dAldGx/bVzAVLOCo6TzWwNzC2cHQxcnIICahLLFpykg3ElhAwkXjw dhsrhC0mceHeeqA4F1DNUkaJw7vnMcMUnZ+wjxEiMYdRYtWxbWDdLAKqEvO6eoC6OTjYBPQk Zn5OBgkLC3hIrHh6kQmkXkTgDaPEuVOzwQYxC8xjlVj0wRfiCiWJNftesYDYvAKCEidnPmGB WKYqsef3RGaIuJrEpM03oC4Vl7gw9xI7hM0rMaP9KVS9nMS0r2ugDpWWOD9rAyPMN4u/P4aK 80scu72DCcIWkJh65iBUjZbEm9n9UDV8EmsWvmWBqd91ajkzzK77W+ZC9UpIbG15wgrxi6LE lO6H7CC/MwtoSqzfpY/uFV4BN4mHPxeDA1RCYCKHxIPW64wTGJVmIambhWTULIRRyEoWMLKs YhRNLUguKE5KLzLWK07MLS7NS9dLzs/dxAhMDKf/PevfwXj3gPUhRgEORiUe3kbXFaFCrIll xZW5hxhNgbE0kVlKNDkfmH7ySuINjc2MLExNTI2NzC3NlMR5F0r9DBYSSE8sSc1OTS1ILYov Ks1JLT7EyMTBKdXAWNh+42tsxqI9CnPectjnCezdL+8/mffkRS4LixjbrVP5Dr1l8Njj4eR3 7XR95hu+qVdOvg1/dDv9eKbawuMBpTZdtmv/BUtXs7h++rg4IfHh2SR9vhZlBT67uLypGddW q/8KZLk2v8j5+Dm5959ZI/6w6CjwBGroL9/m+8TKXk4pN+Dl4U1FSizFGYmGWsxFxYkApoFP KQcDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKKsWRmVeSWpSXmKPExsVy+t/tPt3sxStCDQ4v0re4vGsOmwOjx+dN cgGMUWk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUBD lRTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2StGG5kZ6RgZ6pkZ6hsaxVoYGBkamQDUJaRkd 21czFyzhqOg81cDewNjC0cXIySEkoC6xaMlJNhBbQsBE4vyEfYwQtpjEhXvrgeJcQDVzGCVW HdsGVsQioCoxr6uHtYuRg4NNQE9i5udkkLCwgIfEiqcXmUDqRQTeMEqcOzWbGSTBLDCPVWLR B1+IZUoSa/a9YgGxeQUEJU7OfMICsUxVYs/vicwQcTWJSZtvQB0kLnFh7iV2CJtXYkb7U6h6 OYlpX9cwQ9jSEudnbYA7evH3x1Bxfoljt3cwQdgCElPPHISq0ZJ4M7sfqoZPYs3Ctyww9btO LWeG2XV/y1yoXgmJrS1PWCF+UZSY0v2QHeR3ZgFNifW79NG9wivgJvHw52K2CYyys5CkZiHp noXQjaxkASPLKkbR1ILkguKk9ApDveLE3OLSvHS95PzcTYzgJPRs4Q7GL+etDzEKcDAq8fA2 uK4IFWJNLCuuzD3EKMHBrCTC+7waKMSbklhZlVqUH19UmpNafIjRFBhnE5mlRJPzgQkyryTe 0NjYxMzE1NLEwsDUXEmc9/+53BAhgfTEktTs1NSC1CKYPiYOTqkGxjNagkHmHy0XT4xoyzz8 +ty1yDwvk53uLAn2hTXHFScds+/XD4le+IZzn2NsxNlLDAyKvv8soz4xTbIX+19ylOeMvsAX vZ1OHZIVz+y6hW4sPRCQcjpF/ruXeZ15m8y7V367vmuvmHVuxdy/MvMaa19ULfv2vbv2xVzX 4Hoj491FlzR+BX+boMRSnJFoqMVcVJwIADRm/PpYAwAA DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6H6eqig016120 > > This patchset introduce the generic devfreq cooling device for generic thermal > framework. The devfreq devices are used ad cooling device to reduce the > overheating temperature. This patch is based on drivers/thermal/cpu_cooling.c. > The devfreq cooling device can change the ragne of the frequency table of > devfreq device according to cooling level in device tree file. Hi, 1. You've exported "update_devfreq()" in 1/2 and didn't use it anywhere. 2. If you've added "update_devfreq()" to notify devfreq driver when a new max/min is defined, you'll need to add it at set_state, OR You may do it with opp_enable()/opp_disable() function and let opp notifiers do the homework for you. (no need to update_devfreq(). Cheers, MyungJoo {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I