From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59E4937E31E for ; Mon, 11 May 2026 19:55:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778529315; cv=none; b=XSx+UTJ0ocMiQyaQ9633xbeilvCvXk3EDbHxSM4KgxI0O6GuXYAKL2yp7RUYfmiMli1NrPT2uWV1XiTLe1PUlw2Mgvfqsx9Wz9bcukdaQzgdgyabj3yPl98eOnI4nqg+WTDlIMD/ZMF0V1J5+JuhNcH4luFRiW+9SHQfc9SIb9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778529315; c=relaxed/simple; bh=y7RyIjZ5lQwaXinf+QCKIdAlERDihfdqXGl92iysSAc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ocg91pFe7X+bfceV2LfXygsz2gcogP/zEpywprZfURQN6XUv3vLrqtgqmKQww4qE2mXDjUQ99fStNgwe+LgGpOnhaQX0ti+fUkfJNAJeVx8nO3zSoUZVMAfhnUZ0oMOKYU0gSWUTl6BS7c6rci1xrT2wYAV/ZFqQlA64i7166eE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wkennington.com; spf=none smtp.mailfrom=wkennington.com; dkim=pass (2048-bit key) header.d=wkennington-com.20251104.gappssmtp.com header.i=@wkennington-com.20251104.gappssmtp.com header.b=01J05Fpy; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wkennington.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=wkennington.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wkennington-com.20251104.gappssmtp.com header.i=@wkennington-com.20251104.gappssmtp.com header.b="01J05Fpy" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-12c19d23b19so7964656c88.0 for ; Mon, 11 May 2026 12:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wkennington-com.20251104.gappssmtp.com; s=20251104; t=1778529313; x=1779134113; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pjKeLWgjHBQTkmJ6p6z8OY+FQ1KX7+7BPlZYS7zHpNw=; b=01J05Fpy/eIg2sLwC3qpMLB+5cguVkBhcoyWqa5m+Ne2JMy3gQOI3txe6p278NvM+d MRECLXAASzAeP5PB91W1gDFHBcN8g7WHvnR15E4Ri2yIaphguzFhKk5SakZwjwWKIxuN Ls87baKlTOewhi57iBaqckNwTiHcO9z8pFeMpKNvn6P1HrQakjG5zS4H7YuNPtS8f05f a8Dtw/YxWlM+ZEojU6FouJzK+mQ8eia37wauFVByMmmXt1pwUeg1FIQbxLv80JiK0vlH Iqn+EENPNbHH+zf1Q9P9IZe+fIqzEvbDw8dfq+TOKreK7PYIpxLQWYkd9ZLElEWikLIu 2Wbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778529313; x=1779134113; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pjKeLWgjHBQTkmJ6p6z8OY+FQ1KX7+7BPlZYS7zHpNw=; b=CbchdaCjpRuxjJsMieRAJieUN286RNJbhHytB6IRmXxu3vwXYVPRljpqzB3NcKpn+M taxFJYnywhU0ypvDLJ7BtpIRQXGHzN5tR5vfpHGbrfmeglVQdLhFkHlYvSCka0SXj3DU Hr2S6JBXTB9I49ChDwnBsK+++pP8Ja6svdCARxGwH6cO6H0y04Zr1vUWiFOmAdTsLd2y M9J4INHu4phuuzmcOml1SLrob1jqyGVW8VIC0vcd5P/J9rMS/k4I+986ArSnAXlq28sQ DhjvQVGm/sN/qqZCqDg5uIJkhrJc1POzlN4sQ2UOrgV+SwcnE11BiN9wnqWwK9aM0NoQ Lh0Q== X-Forwarded-Encrypted: i=1; AFNElJ/tVQvZ1C7O7luZ2xVtjBzgu1K3cdorfgjRJ6ubBhFkIw9AQBpuMDEgz8xGZ5w1W/qfDe5g/gA4SWivQOI=@vger.kernel.org X-Gm-Message-State: AOJu0YxEry0DS+FGr5MFRKR9Z+2nc2E819qCGFS0RJqxxdVhoUyzru9J 6bgqTVLNffOky13JQ5E85+4uA+DItGpaQ/EEqhY8va+wbuPoHmNIQad+uI+34PcLIRc= X-Gm-Gg: Acq92OFZ2PLmFFWO3hJCrTb4ixpnmg1qU33P/UVp1JHRGSrj5nzTF7U0aZjDPHAU6Tw +WdqZzVqema01SjPHVTB8RSI8P6+COHZvAAlZAyq+qjz33p1ztsNkGbuTdoThJcgkmJlM6ydnnr S4gP7NRA69Ro1J2YNq9tuRuuGrXFuXemfVPLDuZK/j/i4MG7pqKlg0Wf8xiPgwDwAF5QRooqQ2d eB28tUPkX2yNlZSQbq8YBdtgNm8Om3QL1r3Ia4XrPArLkzB6wEyIiuTQaCCq4xpb1HlYbSjYAZm 6jr007LVnhRkLp2nfTY0RxR0AQH0MkiK81ReOCw2Dmrr8bSNJaJYTwKV1LzamMR2PN0lGgXAq/O f3vltpeTejAnsS8HE7N4Dny4Hu5Z49b89NfmYAC3VcLyMX/R1FGdVTFkuP2YLxrkSwtkK/iCAAB rmb/lIXYWUa9XVePnlCT+a8z1+SOF4fXwGUJ74Py/IutfvsGACEcFUjfsIGikRkQKhW7vPLSfLQ nR05XJU2FBT5GoW6PdHEiTAMBZbY9sQ3EWtC0Gg9d5+s49aSYJX5w== X-Received: by 2002:a05:7022:6899:b0:132:5e72:43d3 with SMTP id a92af1059eb24-1325e724784mr9414388c88.29.1778529313040; Mon, 11 May 2026 12:55:13 -0700 (PDT) Received: from ?IPV6:2a00:79e1:2e00:d201:e58:7bff:fe94:34ed? ([2a00:79e1:2e00:d201:e58:7bff:fe94:34ed]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1327865700asm15837620c88.9.2026.05.11.12.55.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2026 12:55:12 -0700 (PDT) Message-ID: <92459fea-da73-4e16-890a-6e6f42621c0e@wkennington.com> Date: Mon, 11 May 2026 12:55:11 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/4] i2c: designware: Convert PCI driver to use shutdown hook To: Andy Shevchenko Cc: Mika Westerberg , Jan Dabros , Andi Shyti , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260507-dw-i2c-v4-0-9a447b23bfdf@wkennington.com> <20260507-dw-i2c-v4-2-9a447b23bfdf@wkennington.com> Content-Language: en-US From: "William A. Kennington III" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/8/26 01:15, Andy Shevchenko wrote: > On Thu, May 07, 2026 at 08:05:16PM +0000, William A. Kennington III wrote: >> Convert the PCI driver to use the new i2c_dw_shutdown() hook, allowing >> the controller to gracefully NACK master requests during system shutdown. > ... Done > >> +static void i2c_dw_pci_shutdown(struct pci_dev *pdev) >> +{ >> + struct dw_i2c_dev *i_dev; >> + >> + i_dev = pci_get_drvdata(pdev); >> + if (!i_dev) >> + return; >> + >> + pm_runtime_disable(&pdev->dev); >> + if (!pm_runtime_status_suspended(&pdev->dev)) > There is a difference between pm_runtime_status_suspended() and > pm_runtime_suspended(). Are you sure you use the proper call here? > (Please, double check.) pm_runtime_suspend() would always return false after pm_runtime_disable() > >> + i2c_dw_shutdown(i_dev); >> +}