From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752186AbcELAS0 (ORCPT ); Wed, 11 May 2016 20:18:26 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:34793 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbcELASY (ORCPT ); Wed, 11 May 2016 20:18:24 -0400 Subject: Re: [RFC PATCH 5/8] KEYS: Provide software public key query function [ver 3] To: Mat Martineau , David Howells References: <20160511142152.4743.14414.stgit@warthog.procyon.org.uk> <20160511142230.4743.12500.stgit@warthog.procyon.org.uk> Cc: tadeusz.struk@intel.com, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, dwmw2@infradead.org From: Tadeusz Struk Message-ID: <92771fa9-e5a8-2721-519b-f91da21deb3e@gmail.com> Date: Wed, 11 May 2016 17:17:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2016 04:50 PM, Mat Martineau wrote: > >> + len = crypto_akcipher_maxsize(tfm); >> + info->key_size = len * 8; >> + info->max_data_size = len; >> + info->max_sig_size = len; >> + info->max_enc_size = len; >> + info->max_dec_size = len; > > If len > UINT16_MAX, should UINT16_MAX be reported as the max size? Similar question for len*8 and key_size. Hi Mat, Since all the operations performed are mod key->n the output will never be bigger than size of pkey->n, which is the return value from crypto_akcipher_maxsize(tfm) for a given key. Thanks, -- TS