From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751782AbdHPJE5 (ORCPT ); Wed, 16 Aug 2017 05:04:57 -0400 Received: from mail-lf0-f48.google.com ([209.85.215.48]:36670 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751500AbdHPJEy (ORCPT ); Wed, 16 Aug 2017 05:04:54 -0400 Subject: Re: [PATCH] sata: ahci-da850: Fix some error handling paths in 'ahci_da850_probe()' To: Christophe JAILLET , tj@kernel.org Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20170816053103.19773-1-christophe.jaillet@wanadoo.fr> From: Sergei Shtylyov Message-ID: <928002bb-9f1c-d7df-e04f-fcd5dc5dd73e@cogentembedded.com> Date: Wed, 16 Aug 2017 12:04:52 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170816053103.19773-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 8/16/2017 8:31 AM, Christophe JAILLET wrote: > 'rc' is known to be 0 at this point. > If 'platform_get_resource()' or 'devm_ioremap()' fail, return -ENOMEM > instead of 0 which means success. > > Signed-off-by: Christophe JAILLET > --- > drivers/ata/ahci_da850.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/ahci_da850.c b/drivers/ata/ahci_da850.c > index 1a50cd3b4233..eb46cad4d514 100644 > --- a/drivers/ata/ahci_da850.c > +++ b/drivers/ata/ahci_da850.c > @@ -216,12 +216,16 @@ static int ahci_da850_probe(struct platform_device *pdev) > return rc; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - if (!res) > + if (!res) { > + rc = -ENOMEM; -ENODEV would fit better here. [...] MBR, Sergei