From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762761AbdJQOGr (ORCPT ); Tue, 17 Oct 2017 10:06:47 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52390 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754244AbdJQOGn (ORCPT ); Tue, 17 Oct 2017 10:06:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0779B6074E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [PATCH v5 1/2] acpi: apei: remove the unused dead-code for SEA/NMI notification type To: Dongjiu Geng , bp@suse.de, james.morse@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, lenb@kernel.org, robert.moore@intel.com, lv.zheng@intel.com, mark.rutland@arm.com, kristina.martsenko@arm.com, mingo@kernel.org, punit.agrawal@arm.com, stephen.boyd@linaro.org, kamensky@cisco.com, prarit@redhat.com, shiju.jose@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.or References: <1508227341-15651-1-git-send-email-gengdongjiu@huawei.com> From: Tyler Baicar Message-ID: <9287b646-7673-bf5d-bcde-933c8c98a0dd@codeaurora.org> Date: Tue, 17 Oct 2017 10:06:39 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1508227341-15651-1-git-send-email-gengdongjiu@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/17/2017 4:02 AM, Dongjiu Geng wrote: > For the SEA notification, the two functions ghes_sea_add() and > ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA > is defined. If not, it will return errors in the ghes_probe() > and not continue. If the probe is failed, the ghes_sea_remove() > also has no chance to be called. Hence, remove the unnecessary > handling when CONFIG_ACPI_APEI_SEA is not defined. > > For the NMI notification, it has the same issue as SEA notification, > so also remove the unused dead-code for it. > > Cc: Tyler Baicar > Cc: James Morse > Signed-off-by: Dongjiu Geng Tested-by: Tyler Baicar I've verified v5 of this series testing the SEA path. Thanks, Tyler