From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0444C04EBD for ; Tue, 16 Oct 2018 18:16:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B491921477 for ; Tue, 16 Oct 2018 18:16:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B491921477 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727565AbeJQCIb (ORCPT ); Tue, 16 Oct 2018 22:08:31 -0400 Received: from smtprelay0188.hostedemail.com ([216.40.44.188]:54529 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727006AbeJQCIa (ORCPT ); Tue, 16 Oct 2018 22:08:30 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id B7ACE18033236; Tue, 16 Oct 2018 18:16:49 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: pin24_7585ef7e4865b X-Filterd-Recvd-Size: 2768 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf15.hostedemail.com (Postfix) with ESMTPA; Tue, 16 Oct 2018 18:16:47 +0000 (UTC) Message-ID: <928f615f2a25f821e785f2db96f90df009d2fa34.camel@perches.com> Subject: Re: [PATCH] staging: iio: adc: Add comments to prevent checks corrections From: Joe Perches To: Slawomir Stepien , Gabriel Capella Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, apw@canonical.com Date: Tue, 16 Oct 2018 11:16:46 -0700 In-Reply-To: <20181016180631.GA6085@x220.localdomain> References: <20181015212521.GA24512@mantaray> <20181016180631.GA6085@x220.localdomain> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-10-16 at 20:06 +0200, Slawomir Stepien wrote: > On paź 15, 2018 18:25, Gabriel Capella wrote: > > This patch adds 3 comments in 2 different files. > > These comments warn to don't correct the checks of type: > > "CHECK: spaces preferred around that '-'" > > > > Signed-off-by: Gabriel Capella > > --- > > drivers/staging/iio/adc/ad7192.c | 1 + > > drivers/staging/iio/adc/ad7280a.c | 2 ++ > > 2 files changed, 3 insertions(+) > > I have this simpler solution...let's focus our efforts on moving the two drivers > out of staging. This will prevent the CHK to appear: > > Cut from checkpatch.pl: > > if ($realfile =~ m@^(?:drivers/net/|net/|drivers/staging/)@) { > $check = 1; > > Existing driver out of staging, with this "problem": > $ ./scripts/checkpatch.pl --types SPACING --file drivers/iio/adc/ad7793.c > total: 0 errors, 0 warnings, 827 lines checked > > drivers/iio/adc/ad7793.c has no obvious style problems and is ready for submission. > > NOTE: Used message types: SPACING > > In my opinion it would stop this incorrect patches. - > > I have also this changes to checkpatch.pl: > https://github.com/s-stepien/linux-1/commit/c976a31b392393fb417f2d9e2ec9639bc226ad0b > and usage: > https://github.com/s-stepien/linux-1/commit/1adc0428b496f44f6a931637084bb619ddd9992d > but I'm not that sure it is the best way to go. > > What do you all think? I think the suggested form is somewhat cryptic /* checkpatch- */ and the new checkpatch code is somewhat balky. It also allows only a single type to ignore per line.