From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753259AbcFBMcy (ORCPT ); Thu, 2 Jun 2016 08:32:54 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:49463 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753172AbcFBMcu (ORCPT ); Thu, 2 Jun 2016 08:32:50 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Tomasz Nowicki , rafael@kernel.org, linux-pci@vger.kernel.org, will.deacon@arm.com, okaya@codeaurora.org, wangyijing@huawei.com, andrea.gallo@linaro.org, Lorenzo.Pieralisi@arm.com, linaro-acpi@lists.linaro.org, ddaney@caviumnetworks.com, linux-acpi@vger.kernel.org, robert.richter@caviumnetworks.com, helgaas@kernel.org, liudongdong3@huawei.com, catalin.marinas@arm.com, Liviu.Dudau@arm.com, jcm@redhat.com, msalter@redhat.com, cov@codeaurora.org, mw@semihalf.com, jchandra@broadcom.com, dhdang@apm.com, linux-kernel@vger.kernel.org, jeremy.linton@arm.com, hanjun.guo@linaro.org, Suravee.Suthikulpanit@amd.com Subject: Re: [RFC PATCH 1/3] pci, acpi: Match PCI config space accessors against platfrom specific ECAM quirks. Date: Thu, 02 Jun 2016 14:32:33 +0200 Message-ID: <9294389.sZPDtyjoUs@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <5750218F.9030406@semihalf.com> References: <1464856864-18049-1-git-send-email-tn@semihalf.com> <4347711.qDrKz2s8lr@wuerfel> <5750218F.9030406@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:/3VkpA2PB9ZrGfqX7zFWaGjma3sPZG+97a7wIN+Yb7sMlgepFgV CjjjGrZIlMPnpr/w/RQtFONwzMCpr6sf7fxtsYfJpvPoGwe1YWWHaxIWIH8hJOjX7ZhP5s0 mwNSJkkdDALCjKSmsiySYJqwrQjEXDTaBZp0aiAqnH36dI3DfuFnoDIIVaTRjHE7I9m9Iu4 wuqVrBjdj7fF0+3ZiyGjg== X-UI-Out-Filterresults: notjunk:1;V01:K0:mkeSv0G2dYE=:X4bikOZXpQ8SyXFmO2iqYt k+KnRiX7GdyTZOkJz1+EKznCUBbxOrTH3ziTQFV72HDEVmj5OpJW6WlE/2kWfGWPzU09vMy70 wlWGW6DOX3genS8V6X7+Q/snvc1cD2i7qjSpTIDKdE8zZMYy/S+TYjfUByU49W5OdIeb/BrHV pXV2T4yo659dZiFAzUJ5+uqz3Q/ek1Q5nHh16MbHzNU1RwSeUPb0TNkzkKRrJTJov+8rPvSNl 1AFO6FbT6A1A3m4+2/5kiavE1MudHv9LmlVKrdbxBtGq6SNl4b8mQIRtSnIu7xUhWeBxio85o hbhFZYn8SPZqWHpfX+r3HRNaT+Js6L1E/Z6cCuHZpgJXHdtr74TaDMBDG/dlSpSRk6/UVLPSj GwjFi3fUAqa/yIJ5KLKMLRyqlf+5ZSANzdonvvrwO478OAp2pPVgSL3kiq+Y7WeTCRHBF+WWZ 9Kof/0WMi9Cr4fkDa74drkF7XyLtuBWcveEXEpIVrQ/+IHV+y0w0tIY66Rfkxa9lbWzalV4ip j8iK2crLEttpCg3YdALYKyQaXcvyiF7U2WTS/KjZtV2HzGweQVO85GjA0XDJqYYFv3DoAtEzi +fsfZDKMUsDfmiAH8K7kfrcXVWbVwu/34Md4rR5Gdfg3j96HE8lUW8IspOpOb3/VCcwKXF193 D4tvAaAzjkaQZfr2VfpTITZ9KLrbgNwqWPKulsgWj1IzCqiKTwosVc6zb6Ryzg6io+6KexZJ8 1sWT9bYZbTqQSEKJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, June 2, 2016 2:07:43 PM CEST Tomasz Nowicki wrote: > On 02.06.2016 13:42, Arnd Bergmann wrote: > > On Thursday, June 2, 2016 10:41:01 AM CEST Tomasz Nowicki wrote: > >> +struct pci_ecam_ops *pci_mcfg_get_ops(struct acpi_pci_root *root) > >> +{ > >> + int bus_num = root->secondary.start; > >> + int domain = root->segment; > >> + struct pci_cfg_fixup *f; > >> + > >> + if (!mcfg_table) > >> + return &pci_generic_ecam_ops; > >> + > >> + /* > >> + * Match against platform specific quirks and return corresponding > >> + * CAM ops. > >> + * > >> + * First match against PCI topology then use OEM ID and > >> + * OEM revision from MCFG table standard header. > >> + */ > >> + for (f = __start_acpi_mcfg_fixups; f < __end_acpi_mcfg_fixups; f++) { > >> + if ((f->domain == domain || f->domain == PCI_MCFG_DOMAIN_ANY) && > >> + (f->bus_num == bus_num || f->bus_num == PCI_MCFG_BUS_ANY) && > >> + (!strncmp(f->oem_id, mcfg_table->header.oem_id, > >> + ACPI_OEM_ID_SIZE)) && > >> + (f->oem_revision == mcfg_table->header.oem_revision)) > >> + return f->ops; > >> + } > >> + /* No quirks, use ECAM */ > >> + return &pci_generic_ecam_ops; > >> +} > >> + > >> int pci_mcfg_lookup(struct acpi_pci_root *root) > > > > Can you explain the use of pci_ecam_ops instead of pci_ops here? > > > > I wanted to get associated bus_shift and use it to setup configuration > region properly before calling pci_ecam_create. Please see next patch. > I see. It feels really odd to do it this way though, since having a nonstandard bus_shift essentially means not using anything resembling ECAM to start with. I realize that a lot of the host bridges are not ECAM, but because of this, it would be more logical to have their own pci_ops instead of pci_ecam_ops. Arnd