From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97A81C433F5 for ; Fri, 4 Mar 2022 14:12:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239854AbiCDONd (ORCPT ); Fri, 4 Mar 2022 09:13:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239855AbiCDON0 (ORCPT ); Fri, 4 Mar 2022 09:13:26 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18EBB1BB720; Fri, 4 Mar 2022 06:12:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1646403145; x=1677939145; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=Is/ItGtQqugXnrksFzi3WsWP524rFjNifUTd7uJUz1g=; b=DiKyJwskLewUD2olshfuXVKC7yrABrXVT+VLzlrIaSmvtxa3DJXJBLCV 4003+ziwQeOnWUioBfjPONVyOx4C5xse0Dh6UJSHBuHgasF7FJlxhzu5O 1wyrmEZhUnggsSBpaMokx5vJ0Lo0he2Qqb6AdJVx1PXxCE2mBclxW9o57 nIhVGQ9oGSXgO4Y3iBi3UR1uu1vRqU/sLMyZhKQFqD6wiclGoHV/KF7Xt pTKLT0ljADYyq7D6K7qDK2sRntMTJ1q6Ye4PH9x4+2UtxcxS7lSGCqHJH qu3nqq4/UVLImLB9F5TGs0YCxngvZiH7t5/jkNylhWLV9FP3WWOdEfQMy g==; X-IronPort-AV: E=Sophos;i="5.90,155,1643698800"; d="scan'208";a="148102473" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 04 Mar 2022 07:12:24 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Fri, 4 Mar 2022 07:12:22 -0700 Received: from [10.12.73.230] (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Fri, 4 Mar 2022 07:12:20 -0700 Message-ID: <92c78eb4-bdc2-4240-4eb7-dc8b2b736cac@microchip.com> Date: Fri, 4 Mar 2022 15:12:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] ARM: dts: at91: sama7g5: Add NAND support Content-Language: en-US From: Nicolas Ferre To: Tudor Ambarus - M18064 , Stephen Boyd CC: "alexandre.belloni@bootlin.com" , "Ludovic Desroches - M43218" , "robh+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20220111130556.905978-1-tudor.ambarus@microchip.com> <2fa34fae-7736-670a-1d31-7928fbcf95bd@microchip.com> <3cd1fd6b-d3a4-5ac5-22fa-c854e2f25a65@microchip.com> <647e801b-88d3-6169-0354-ba1cdff8d807@microchip.com> <3cc35822-cbfb-28e5-5fdb-76ceb1eebd27@microchip.com> Organization: microchip In-Reply-To: <3cc35822-cbfb-28e5-5fdb-76ceb1eebd27@microchip.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/02/2022 at 11:28, Nicolas Ferre wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 24/02/2022 at 19:26, Tudor Ambarus - M18064 wrote: >> On 2/24/22 19:44, Nicolas Ferre wrote: >>> Hi Tudor, >> >> Hi, >> >>> >>> On 24/02/2022 at 16:49, Tudor Ambarus - M18064 wrote: >>>> On 2/24/22 17:04, Nicolas Ferre wrote: >>>>> On 11/01/2022 at 14:05, Tudor Ambarus wrote: >>>>>> Add NAND support. The sama7g5's SMC IP is the same as sama5d2's with >>>>>> a slightly change: it provides a synchronous clock output (SMC clock) >>>>>> that is dedicated to FPGA usage. Since this doesn't interfere with the SMC >>>>>> NAND configuration, thus code will not be added in the current nand driver >>>>>> to address the FPGA usage, use the sama5d2's compatible and choose not to >>>>>> introduce dedicated compatibles for sama7g5. >>>>>> Tested with Micron MT29F4G08ABAEAWP NAND flash. >>>>>> >>>>>> Signed-off-by: Tudor Ambarus >>>>> >>>>> Acked-by: Nicolas Ferre >>>>> >>>>>> --- >>>>>> The patch depends on the following patch: >>>>>> https://lore.kernel.org/linux-clk/20220111125310.902856-1-tudor.ambarus@microchip.com/T/#u >>>>> >>>>> Patch seems taken, so I add this one to at91-dt branch for 5.18 merge window. >>>>> >>>> >>>> I think it depends on who gets to next first. If at91 gets before clk, >>>> there will be a build error, isn't it? >>> >> >> Sorry, not linux-next, but whose PR gets first applied by Linus. >> >>> Clk patch is already in linux-next, so no worries. >>> Moreover, I don't get why there could be a build error as there is no build dependency between DT changes and C changes. >>> Sorry but I'm puzzled... Or I'm not looking at the right patch. >>> >> >> You would see this kind of error: >> Error: arch/arm/boot/dts/sama7g5.dtsi:102.21-22 syntax error >> FATAL ERROR: Unable to parse input tree >> make[1]: *** [scripts/Makefile.lib:346: arch/arm/boot/dts/at91-sama7g5ek.dtb] Error 1 >> make[1]: *** Waiting for unfinished jobs.... >> make: *** [Makefile:1385: dtbs] Error 2 >> make: *** Waiting for unfinished jobs.... >> >> This patch uses "PMC_MCK1" which is defined in: >> https://lore.kernel.org/linux-clk/20220111125310.902856-1-tudor.ambarus@microchip.com/T/#u >> >> If Linus applies the arm-soc PR before the clk PR, it will see the same error, no? > > Yes, absolutely. > So I need to have an immutable branch from Stephen then. I'm removing > the patch from the at91-dt branch for now. I didn't hear from Setphen so I'm adding the missing piece in the patch and queue it in my next DT pull-request to arm-soc (target: 5.18). I verified that there is no conflict when merging with linux-next which already contains this chunk. Best regards, Nicolas > Thanks for the insight and sorry not having overlooked at that crucial > piece of header file ;-) > > Best regards, > Nicolas > > -- > Nicolas Ferre > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Nicolas Ferre