Re: [PATCH 0/2] ublk: specify io_cmd_buf pointer type

Jens Axboe
2025-03-28T23:04:11Z

On 3/28/25 1:42 PM, Caleb Sander Mateos wrote:
> io_cmd_buf points to an array of ublksrv_io_desc structs but its type is
> char *. Indexing the array requires an explicit multiplication and cast.
> The compiler also can't check the pointer types.
>
> Change io_cmd_buf's type to struct ublksrv_io_desc * so it can be
> indexed directly and the compiler can type-check the code.
>
> Make the same change to the ublk selftests.

Looks good to me, nice cleanup, more readable now.

--
Jens Axboe