Re: [PATCH 5/7] dt-bindings: remoteproc: qcom,pas: Add hwlocks

Chris Lew
2024-05-21T04:09:24Z

On 5/19/2024 10:36 AM, Krzysztof Kozlowski wrote:
> On 17/05/2024 00:58, Chris Lew wrote:
>> Add hwlocks property to describe the hwspinlock that remoteproc can try
>> to bust on behalf of the remoteproc's smem.
>
> Sorry, as you wrote, the lock is part of smem, not here. Drivers do not
> crash, so if your crashes as you imply in the cover letter, then first
> fix the driver.
>

Hi Krzysztof,

Sorry for the confusion, I dont think I meant that the smem driver will
ever crash. The referred to crash in the cover letter is a crash in the
firmware running on the remoteproc. The remoteproc could crash for any
unexpected reason, related or unrelated to smem, while holding the tcsr
mutex. I want to ensure that all resources that a remoteproc might be
using are released as part of remoteproc stop.

The SMEM driver manages the lock/unlock operations on the tcsr mutex
from the Linux CPU's perspective. This case is for cleaning up from the
remote side's perspective.

In this case it's the hwspinlock used to synchronize SMEM, but it's
conceivable that firmware running on the remoteproc has additional locks
that need to be busted in order for the system to continue executing
until the firmware is reinitialized.

We did consider tying this to the SMEM instance, but the entitiy
relating to firmware is the remoteproc instance.

> Best regards,
> Krzysztof
>