From: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>,
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,
Oded Gabbay <ogabbay@kernel.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Krystian Pradzynski <krystian.pradzynski@linux.intel.com>,
dri-devel@lists.freedesktop.org, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] accel/ivpu: avoid duplciate assignment
Date: Tue, 31 Jan 2023 15:00:05 +0100 [thread overview]
Message-ID: <92f5faec-7fd5-4205-0b0f-1ed15626c30b@linux.intel.com> (raw)
In-Reply-To: <20230126163804.3648051-2-arnd@kernel.org>
Applied to drm-misc-next. Thanks.
On 26.01.2023 17:37, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With extra warnings enabled, gcc warns about two assignments
> of the same .mmap callback:
>
> In file included from drivers/accel/ivpu/ivpu_drv.c:10:
> include/drm/drm_accel.h:31:27: error: initialized field overwritten [-Werror=override-init]
> 31 | .mmap = drm_gem_mmap
> | ^~~~~~~~~~~~
> drivers/accel/ivpu/ivpu_drv.c:360:9: note: in expansion of macro 'DRM_ACCEL_FOPS'
> 360 | DRM_ACCEL_FOPS,
> | ^~~~~~~~~~~~~~
>
> Remove the unused local assignment.
>
> Fixes: 20709aa9435b ("accel: Add .mmap to DRM_ACCEL_FOPS")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/accel/ivpu/ivpu_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
> index 2bc2f1b90671..a29e8ee0dce6 100644
> --- a/drivers/accel/ivpu/ivpu_drv.c
> +++ b/drivers/accel/ivpu/ivpu_drv.c
> @@ -356,7 +356,6 @@ int ivpu_shutdown(struct ivpu_device *vdev)
>
> static const struct file_operations ivpu_fops = {
> .owner = THIS_MODULE,
> - .mmap = drm_gem_mmap,
> DRM_ACCEL_FOPS,
> };
>
next prev parent reply other threads:[~2023-01-31 14:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 16:37 [PATCH 1/2] accep/ivpu: PM: remove broken ivpu_dbg() statements Arnd Bergmann
2023-01-26 16:37 ` [PATCH 2/2] accel/ivpu: avoid duplciate assignment Arnd Bergmann
2023-01-26 17:10 ` Jeffrey Hugo
2023-01-31 14:00 ` Jacek Lawrynowicz [this message]
2023-02-01 10:37 ` Thomas Zimmermann
2023-01-26 17:08 ` [PATCH 1/2] accep/ivpu: PM: remove broken ivpu_dbg() statements Jeffrey Hugo
2023-01-27 9:16 ` Stanislaw Gruszka
2023-01-31 9:22 ` Jacek Lawrynowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92f5faec-7fd5-4205-0b0f-1ed15626c30b@linux.intel.com \
--to=jacek.lawrynowicz@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=krystian.pradzynski@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=stanislaw.gruszka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox