From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fra-out-009.esa.eu-central-1.outbound.mail-perimeter.amazon.com (fra-out-009.esa.eu-central-1.outbound.mail-perimeter.amazon.com [3.64.237.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C79A038F244; Fri, 6 Mar 2026 12:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=3.64.237.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772801329; cv=none; b=eLWs/Yys7miASR9VEw+yWKT925EoLZdAExanmiOSrZOZKOMqMXL9BFFpYE7tfqU+oaJlRGiLclwkD4hftMMTH08L7jTRPMtg9KVgzyQIJohAAkSV1yyiIpv5h2WD2PjjERFPodlWL62d2Ys77tyv1YC/Niz+ydh7CfpzFayCN1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772801329; c=relaxed/simple; bh=A4w55fhkSP5SYqH4itJWFNtaO6TtNfPXoavYXd9Qto0=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Yi76rrrboO7WgW+mkJGTWkZNVm4h33Iokc2cd6VqXVFDDsjMll4LgnJVaWs0enkXuQyEbW6ZA3LeNwhs8OF0lHexOE6UICt5I6VXiu0nwxEzikmjDBJJjp2PNJ9gykIPwsOrwLY4w4NCSe8tD8NeWX+mj2mm9CVAG8iFc5nuWhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.uk; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=qJl9tLI6; arc=none smtp.client-ip=3.64.237.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="qJl9tLI6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1772801327; x=1804337327; h=message-id:date:mime-version:reply-to:subject:to:cc: references:from:in-reply-to:content-transfer-encoding; bh=bMQYOYMXLfYYqfrzv9J2aTP1fDeqWn0su8Gslng5WAw=; b=qJl9tLI6Hmyo/cvynocC/dXRUh6jTzwgUewXZHe5Qx3AqbGjsC/cvgHe GYoZXOO1tUCAOOHHOfR+Q9AO0pYhzUQCBYe4g8OUwMtZPU8+mNmklmL1X 6ifSEp2IHSGmA2Hzq1YxFJfLl2A+gzoDp+LWtP932fRUaBKSdIqSocb7K 84GfU5suoK6/w2pac4s/CoUj/ce6Ack1D+uodCJsgwqOeAIYjB1rhzA9+ qzT/ArGvxWtrLw4J9sxk/meMNDwTYlRwRB4OPeH2VvkKNXhOJR9KrmMA6 eSITT6cdyNGNGTSbyS0SKMWH7iodhFgbkfXgOsA0VYTtMtQ+ZlqoTB+Nl w==; X-CSE-ConnectionGUID: Yx/EHmQHRFy5mQfbcc7SOQ== X-CSE-MsgGUID: vFI11kARTzO+6Dwqg0rWgg== X-IronPort-AV: E=Sophos;i="6.23,104,1770595200"; d="scan'208";a="10334043" Received: from ip-10-6-3-216.eu-central-1.compute.internal (HELO smtpout.naws.eu-central-1.prod.farcaster.email.amazon.dev) ([10.6.3.216]) by internal-fra-out-009.esa.eu-central-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2026 12:48:42 +0000 Received: from EX19MTAEUB002.ant.amazon.com [54.240.197.224:9741] by smtpin.naws.eu-central-1.prod.farcaster.email.amazon.dev [10.0.16.189:2525] with esmtp (Farcaster) id 782955b1-d49c-41df-ab22-e29b6a3853bb; Fri, 6 Mar 2026 12:48:42 +0000 (UTC) X-Farcaster-Flow-ID: 782955b1-d49c-41df-ab22-e29b6a3853bb Received: from EX19D005EUB003.ant.amazon.com (10.252.51.31) by EX19MTAEUB002.ant.amazon.com (10.252.51.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 6 Mar 2026 12:48:41 +0000 Received: from [192.168.2.180] (10.106.83.26) by EX19D005EUB003.ant.amazon.com (10.252.51.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 6 Mar 2026 12:48:36 +0000 Message-ID: <92fcec4f-43f9-4207-8472-eb94874f2efd@amazon.com> Date: Fri, 6 Mar 2026 12:48:35 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Subject: Re: [PATCH v10 01/15] set_memory: set_direct_map_* to take address To: "David Hildenbrand (Arm)" , "Kalyazin, Nikita" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "kernel@xen0n.name" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "loongarch@lists.linux.dev" CC: "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oupton@kernel.org" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "seanjc@google.com" , "tglx@kernel.org" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "lorenzo.stoakes@oracle.com" , "vbabka@suse.cz" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "song@kernel.org" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jolsa@kernel.org" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "shuah@kernel.org" , "riel@surriel.com" , "ryan.roberts@arm.com" , "jgross@suse.com" , "yu-cheng.yu@intel.com" , "kas@kernel.org" , "coxu@redhat.com" , "kevin.brodsky@arm.com" , "ackerleytng@google.com" , "maobibo@loongson.cn" , "prsampat@amd.com" , "mlevitsk@redhat.com" , "jmattson@google.com" , "jthoughton@google.com" , "agordeev@linux.ibm.com" , "alex@ghiti.fr" , "aou@eecs.berkeley.edu" , "borntraeger@linux.ibm.com" , "chenhuacai@kernel.org" , "dev.jain@arm.com" , "gor@linux.ibm.com" , "hca@linux.ibm.com" , "palmer@dabbelt.com" , "pjw@kernel.org" , "shijie@os.amperecomputing.com" , "svens@linux.ibm.com" , "thuth@redhat.com" , "wyihan@google.com" , "yang@os.amperecomputing.com" , "Jonathan.Cameron@huawei.com" , "Liam.Howlett@oracle.com" , "urezki@gmail.com" , "zhengqi.arch@bytedance.com" , "gerald.schaefer@linux.ibm.com" , "jiayuan.chen@shopee.com" , "lenb@kernel.org" , "osalvador@suse.de" , "pavel@kernel.org" , "rafael@kernel.org" , "vannapurve@google.com" , "jackmanb@google.com" , "aneesh.kumar@kernel.org" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Itazuri, Takahiro" , "Manwaring, Derek" , "Cali, Marco" References: <20260126164445.11867-1-kalyazin@amazon.com> <20260126164445.11867-2-kalyazin@amazon.com> <90058ff2-9dea-4090-b2e6-da4c3cdba81b@kernel.org> Content-Language: en-US From: Nikita Kalyazin In-Reply-To: <90058ff2-9dea-4090-b2e6-da4c3cdba81b@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EX19D002EUA002.ant.amazon.com (10.252.50.7) To EX19D005EUB003.ant.amazon.com (10.252.51.31) On 05/03/2026 17:23, David Hildenbrand (Arm) wrote: > On 1/26/26 17:46, Kalyazin, Nikita wrote: >> From: Nikita Kalyazin >> >> This is to avoid excessive conversions folio->page->address when adding >> helpers on top of set_direct_map_valid_noflush() in the next patch. >> >> Signed-off-by: Nikita Kalyazin >> --- >> arch/arm64/include/asm/set_memory.h | 7 ++++--- >> arch/arm64/mm/pageattr.c | 19 +++++++++---------- >> arch/loongarch/include/asm/set_memory.h | 7 ++++--- >> arch/loongarch/mm/pageattr.c | 25 ++++++++++++------------- >> arch/riscv/include/asm/set_memory.h | 7 ++++--- >> arch/riscv/mm/pageattr.c | 17 +++++++++-------- >> arch/s390/include/asm/set_memory.h | 7 ++++--- >> arch/s390/mm/pageattr.c | 13 +++++++------ >> arch/x86/include/asm/set_memory.h | 7 ++++--- >> arch/x86/mm/pat/set_memory.c | 23 ++++++++++++----------- >> include/linux/set_memory.h | 9 +++++---- >> kernel/power/snapshot.c | 4 ++-- >> mm/execmem.c | 6 ++++-- >> mm/secretmem.c | 6 +++--- >> mm/vmalloc.c | 11 +++++++---- >> 15 files changed, 90 insertions(+), 78 deletions(-) > > [...] > >> --- a/arch/loongarch/mm/pageattr.c >> +++ b/arch/loongarch/mm/pageattr.c >> @@ -198,32 +198,31 @@ bool kernel_page_present(struct page *page) >> return pte_present(ptep_get(pte)); >> } >> >> -int set_direct_map_default_noflush(struct page *page) >> +int set_direct_map_default_noflush(const void *addr) >> { >> - unsigned long addr = (unsigned long)page_address(page); >> - >> - if (addr < vm_map_base) >> + if ((unsigned long)addr < vm_map_base) >> return 0; >> >> - return __set_memory(addr, 1, PAGE_KERNEL, __pgprot(0)); >> + return __set_memory((unsigned long)addr, 1, PAGE_KERNEL, __pgprot(0)); >> } >> >> -int set_direct_map_invalid_noflush(struct page *page) >> +int set_direct_map_invalid_noflush(const void *addr) >> { >> - unsigned long addr = (unsigned long)page_address(page); >> + unsigned long addr = (unsigned long)addr; > > Are you sure you want a local variable with the exact same name > You're right. Thanks for spotting that. > ... > >> >> - if (addr < vm_map_base) >> + if ((unsigned long)addr < vm_map_base) >> return 0; >> >> - return __set_memory(addr, 1, __pgprot(0), __pgprot(_PAGE_PRESENT | _PAGE_VALID)); >> + return __set_memory((unsigned long)addr, 1, __pgprot(0), >> + __pgprot(_PAGE_PRESENT | _PAGE_VALID)); > > And cast it to (unsigned long) even though not required two times? :) > > I assume you wanted to get rid of the local varable. Yes, that's what I meant. > >> } >> >> -int set_direct_map_valid_noflush(struct page *page, unsigned nr, bool valid) >> +int set_direct_map_valid_noflush(const void *addr, unsigned long numpages, >> + bool valid) > > > > Nothing else jumped at me. > > Acked-by: David Hildenbrand (Arm) Thanks! > > It would be good to get some ACK from some arch people that are CCed :) > > -- > Cheers, > > David