From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02C562D7813 for ; Thu, 12 Feb 2026 09:23:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770888198; cv=none; b=OAeIrokr4g3Vwi0EgUToqig3PmFJ81kYSlH5efMW3X4vOQIgDB4NhIZ7pB3r81r7KONRV1DT+H1YSHlxqqWNkRQ/JWbyiCXHkeCvBDA4nrRuRBOLCuybHbcWahyRydm+DGtvZ/6xygwBOBGFbyjhLPX8gO9npksoms0J0/QL1D0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770888198; c=relaxed/simple; bh=ZhiMTHRn9zJu2lrX5+uOW7rcWa+9/2xEdqrmmvgHRvo=; h=MIME-Version:Date:Content-Type:From:Message-ID:Subject:To:Cc: In-Reply-To:References; b=RwGO/4Bzt62nKi9Jc/94U1fqDU1//kMWo0S+UAncoyo5jriqilIZddDhM10HqXeNwF+Lf8xJhBGmZAPyzWd/HBCX9pTg5i+fESUm/Xf7Bv6clhFBqGtirwc+Uv44QCT7A12Z7cNvbJq7/MdJUS768K6wAF+gHiJ1Lsojb7cvrQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=nvPqHxHr; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="nvPqHxHr" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770888184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MOtwOaawqm5YCOOGpYlVVEXa/IipPl5Ioo0RNIEb2Qg=; b=nvPqHxHr0KgdC09FjroI0w+XrWY/hJ68UL4/0rh2ftPJh5s8PEVk6tHapWR7m/Ri5dxtnv nNQ0yX2uF46GhiKFyKQsKJbEln8+aTnsFZAO98AyIIXUrkhEn4mrYuzBh7bi7l7Nsdwoo+ gniHvShoHs+8GogwC2C38z+MWvWD6r0= Date: Thu, 12 Feb 2026 09:23:00 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: hui.zhu@linux.dev Message-ID: <9302f6e6d89af6b68d673a2f90e366ebcf947e29@linux.dev> TLS-Required: No Subject: Re: [PATCH bpf-next 1/3] selftests/bpf: Check bpf_mem_cgroup_page_state return value To: bot+bpf-ci@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, zhuhui@kylinos.cn, inwardvessel@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net, martin.lau@kernel.org, eddyz87@gmail.com, yonghong.song@linux.dev, clm@meta.com, ihor.solodrai@linux.dev In-Reply-To: <0d926bdc5b5e030fafc82de73c3f3e5412c051fc6763f77da9ea6aa316bd8f13@mail.kernel.org> References: <042df9438d9e78bcd66f1fa0e7043b9ea8cda96c.1770883926.git.zhuhui@kylinos.cn> <0d926bdc5b5e030fafc82de73c3f3e5412c051fc6763f77da9ea6aa316bd8f13@mail.kernel.org> X-Migadu-Flow: FLOW_OUT 2026=E5=B9=B42=E6=9C=8812=E6=97=A5 16:50, bot+bpf-ci@kernel.org mailto:bo= t+bpf-ci@kernel.org =E5=86=99=E5=88=B0: >=20 >=20>=20 >=20> diff --git a/tools/testing/selftests/bpf/prog_tests/cgroup_iter_mem= cg.c b/tools/testing/selftests/bpf/prog_tests/cgroup_iter_memcg.c > > --- a/tools/testing/selftests/bpf/prog_tests/cgroup_iter_memcg.c > > +++ b/tools/testing/selftests/bpf/prog_tests/cgroup_iter_memcg.c > >=20 >=20[ ... ] >=20 >=20>=20 >=20> @@ -170,6 +180,8 @@ static void test_pgfault(struct bpf_link *link,= struct memcg_query *memcg_query) > > if (!ASSERT_OK(read_stats(link), "read stats")) > > goto cleanup; > >=20 >=20> + ASSERT_NEQ(memcg_query->pgfault, (unsigned long)-1, > > + "bpf_mem_cgroup_page_state PGFAULT"); > >=20 >=20 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ >=20 >=20The assertion message references bpf_mem_cgroup_page_state(), but the= BPF > program actually uses bpf_mem_cgroup_vm_events() to retrieve the pgfaul= t > value: >=20 >=20tools/testing/selftests/bpf/progs/cgroup_iter_memcg.c: > memcg_query.pgfault =3D bpf_mem_cgroup_vm_events(memcg, PGFAULT); >=20 >=20Should the message be "bpf_mem_cgroup_vm_events PGFAULT" instead? Good catch! I will fix it in the next version. Best, Hui >=20 >=20--- > AI reviewed your patch. Please fix the bug or email reply why it's not = a bug. > See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/REA= DME.md >=20 >=20CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21= 939182103 >=20 >=20AI-authorship-score: low > AI-authorship-explanation: The commit message uses first-person narrati= ve describing a real back-porting scenario, and the code changes are simp= le repetitive assertions typical of human-written test improvements. > issues-found: 1 > issue-severity-score: low > issue-severity-explanation: Minor documentation issue where an assertio= n message references the wrong BPF function name; does not affect test co= rrectness or system behavior. >