From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA95C4332F for ; Mon, 14 Nov 2022 05:48:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233909AbiKNFst (ORCPT ); Mon, 14 Nov 2022 00:48:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233166AbiKNFsp (ORCPT ); Mon, 14 Nov 2022 00:48:45 -0500 Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51C8B15732 for ; Sun, 13 Nov 2022 21:48:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1668404923; x=1699940923; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=v1sR2mwFH9dmYdHzu0koJ50qxkQ0XF8GxeWMZxBQMlk=; b=EDr+TqkqJW2ooW7yADe8MLzU/RdM+freQMPq6imSGruYhZV0YCuyTBOD aSB3mlZKp+df4W5zbVd9UREPCFROmjq2o+rg274VJalXkXo6pbno42asr fYuXsKrJSgq2iQmkrwV9VB1oj0ePeGTJf4OorYoI2s4/C3NaTNLRcmf7t +Kt1qsiRwkgW4MqcuuDqTjEbv8ALAtFJajEENadERonsC8Kf97KPUB5LA M835529BvYcWDw83Mjxuc1Q9BR4UBkVI+clhIpTEqv+O9Pkb+TfjRH5+4 A2/INtGzgkpPLsGqBeqZ8N1ConIBsQWuwP863nmg8x/ZDB+EjQN9gGHsY w==; X-IronPort-AV: E=Sophos;i="5.96,161,1665417600"; d="scan'208";a="320535393" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 14 Nov 2022 13:48:38 +0800 IronPort-SDR: oqObsUuMEPmwgWaURRjwbkW6qLJINxFFlC+LC7DnUsFgbW5G3GSOqdXam7jHbEaK1A2KeG+O1m l5hvSyqZAJWKB1mt5E0609JmnGY80YW8vVe9LFeRDzYPE+eY5dpO4nINATJfokKvH7/0zEFVAJ h11YOtPVRxgSlque0TuTQsDtEwyubE/93utF6Ge67YRjnYmydNJ3JTmsklxGCe9S8dVPFm0Mm5 MFvpGcR+vtjmtmldMVNFQ9ThcMXTADokneKdDIcDewFh96MGynVKKIaSML+Y1Kz1mO1kmYHrvD tGE= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Nov 2022 21:01:52 -0800 IronPort-SDR: /UHzO+QBlXQEp8ZYUN0ehMrKlRetz5aNadWKGyxjRU5G9Vrm7zpooXQdZWokRGveiYp45+Nxeg 5Ayj2hftxkd7wAnrXDRUKiJRABsoZihe48mtpqNtmWw76YHw4/sxSeYBmQ9IVTQ6OP2ucr2oe2 YNEKll84HsvwVHeU4OTO4I4muiC5rF7dpaTjnVFuF90COORkds0rhfuWJnoBj5JQmvgzHMIi+m Zcr8sx2x4fmAFf0iAzr/BfewUQKLvyIYfTKGV53upSLU3bRR1g84CMBp+LjGTLoMzLWNgijz/1 Zyo= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Nov 2022 21:48:39 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4N9ddx6tf1z1RvTp for ; Sun, 13 Nov 2022 21:48:37 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:references:to:from:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1668404916; x=1670996917; bh=v1sR2mwFH9dmYdHzu0koJ50qxkQ0XF8GxeW MZxBQMlk=; b=rutv4KCi7M1XNlfMkfPzY2SpJEPEarCExPjjAQg1a3KAjHnhK94 trp1G8GWC5pRuCQv0tsgeAXq5uvuxcPjJd9Cx0MAwarnFJLiH7gVn5CR79lAGZ1Z AcPRc3qyda2iR5HANJTIe5KLAgmK+8KyBy/yqNckoRhNQKsLGE1H0iQesm2nfqA8 8HY8zXzj0qILcdTi8YssJxMqozJdMYudpIwBN32TQOoOCnFXdri8Makww4uhn6De 2uJX6l3qsifBFkCOZ0GogE+1zWy8Oaqo8DhTIhc6H6CBJrXbEzWo99uaHjNH1KVb 0RgREcX1ffQYZv2mTbD7CJl/Y2vfYjj1Gtw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NeO2-WWVPphr for ; Sun, 13 Nov 2022 21:48:36 -0800 (PST) Received: from [10.225.163.46] (unknown [10.225.163.46]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4N9ddp5cqHz1RvLy; Sun, 13 Nov 2022 21:48:30 -0800 (PST) Message-ID: <93079aba-362e-5d1e-e9b4-dfe3a84da750@opensource.wdc.com> Date: Mon, 14 Nov 2022 14:48:29 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: Deprecating and removing SLOB Content-Language: en-US From: Damien Le Moal To: Conor Dooley , Vlastimil Babka Cc: Pasha Tatashin , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Matthew Wilcox , Roman Gushchin , Linus Torvalds , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Catalin Marinas , Rustam Kovhaev , Andrew Morton , Josh Triplett , Arnd Bergmann , Russell King , Alexander Shiyan , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Yoshinori Sato , Rich Felker , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "linux-arm-kernel@lists.infradead.org" , openrisc@lists.librecores.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, Geert Uytterhoeven , Conor.Dooley@microchip.com, Paul Cercueil References: Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/14/22 10:55, Damien Le Moal wrote: > On 11/12/22 05:46, Conor Dooley wrote: >> On Fri, Nov 11, 2022 at 11:33:30AM +0100, Vlastimil Babka wrote: >>> On 11/8/22 22:44, Pasha Tatashin wrote: >>>> On Tue, Nov 8, 2022 at 10:55 AM Vlastimil Babka wrote: >>>>> >>>>> Hi, >>>>> >>>>> as we all know, we currently have three slab allocators. As we discussed >>>>> at LPC [1], it is my hope that one of these allocators has a future, and >>>>> two of them do not. >>>>> >>>>> The unsurprising reasons include code maintenance burden, other features >>>>> compatible with only a subset of allocators (or more effort spent on the >>>>> features), blocking API improvements (more on that below), and my >>>>> inability to pronounce SLAB and SLUB in a properly distinguishable way, >>>>> without resorting to spelling out the letters. >>>>> >>>>> I think (but may be proven wrong) that SLOB is the easier target of the >>>>> two to be removed, so I'd like to focus on it first. >>>>> >>>>> I believe SLOB can be removed because: >>>>> >>>>> - AFAIK nobody really uses it? It strives for minimal memory footprint >>>>> by putting all objects together, which has its CPU performance costs >>>>> (locking, lack of percpu caching, searching for free space...). I'm not >>>>> aware of any "tiny linux" deployment that opts for this. For example, >>>>> OpenWRT seems to use SLUB and the devices these days have e.g. 128MB >>>>> RAM, not up to 16 MB anymore. I've heard anecdotes that the performance >>>>> SLOB impact is too much for those who tried. Googling for >>>>> "CONFIG_SLOB=y" yielded nothing useful. >>>> >>>> I am all for removing SLOB. >>>> >>>> There are some devices with configs where SLOB is enabled by default. >>>> Perhaps, the owners/maintainers of those devices/configs should be >>>> included into this thread: >>>> >>>> tatashin@soleen:~/x/linux$ git grep SLOB=y >> >>>> arch/riscv/configs/nommu_k210_defconfig:CONFIG_SLOB=y >>>> arch/riscv/configs/nommu_k210_sdcard_defconfig:CONFIG_SLOB=y >>>> arch/riscv/configs/nommu_virt_defconfig:CONFIG_SLOB=y >> >>> >>> Turns out that since SLOB depends on EXPERT, many of those lack it so >>> running make defconfig ends up with SLUB anyway, unless I miss something. >>> Only a subset has both SLOB and EXPERT: >>> >>>> git grep CONFIG_EXPERT `git grep -l "CONFIG_SLOB=y"` >> >>> arch/riscv/configs/nommu_virt_defconfig:CONFIG_EXPERT=y >> >> I suppose there's not really a concern with the virt defconfig, but I >> did check the output of `make nommu_k210_defconfig" and despite not >> having expert it seems to end up CONFIG_SLOB=y in the generated .config. >> >> I do have a board with a k210 so I checked with s/SLOB/SLUB and it still >> boots etc, but I have no workloads or w/e to run on it. > > I sent a patch to change the k210 defconfig to using SLUB. However... > > The current default config using SLOB gives about 630 free memory pages > after boot (cat /proc/vmstat). Switching to SLUB, this is down to about > 400 free memory pages (CONFIG_SLUB_CPU_PARTIAL is off). > > This is with a buildroot kernel 5.19 build including a shell and sd-card > boot. With SLUB, I get clean boots and a shell prompt as expected. But I > definitely see more errors with shell commands failing due to allocation > failures for the shell process fork. So as far as the K210 is concerned, > switching to SLUB is not ideal. > > I would not want to hold on kernel mm improvements because of this toy > k210 though, so I am not going to prevent SLOB deprecation. I just wish > SLUB itself used less memory :) Did further tests with kernel 6.0.1: * SLOB: 630 free pages after boot, shell working (occasional shell fork failure happen though) * SLAB: getting memory allocation for order 7 failures on boot already (init process). Shell barely working (high frequency of shell command fork failures) * SLUB: getting memory allocation for order 7 failures on boot. I do get a shell prompt but cannot run any shell command that involves forking a new process. So if we want to keep the k210 support functional with a shell, we need slob. If we reduce that board support to only one application started as the init process, then I guess anything is OK. -- Damien Le Moal Western Digital Research