From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754651AbbLJJHV (ORCPT ); Thu, 10 Dec 2015 04:07:21 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:49299 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754610AbbLJJHJ (ORCPT ); Thu, 10 Dec 2015 04:07:09 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Paul Gortmaker , Alexandre Courbot , Stephen Warren , Vinod Koul , linux-kernel@vger.kernel.org, Haojian Zhuang , dmaengine@vger.kernel.org, Laxman Dewangan , Thierry Reding , Daniel Mack , linux-tegra@vger.kernel.org, Dan Williams , Robert Jarzmik Subject: Re: [PATCH 0/6] drivers/dma: drop modular code from non modular drivers Date: Thu, 10 Dec 2015 10:01:44 +0100 Message-ID: <9314789.uFZ258Jr2D@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151210001741.GT22885@windriver.com> References: <1449703322-17762-1-git-send-email-paul.gortmaker@windriver.com> <7162994.ydt4N8UgZZ@wuerfel> <20151210001741.GT22885@windriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:nM8b5E3YclIzGUZHHMFrFKiIOMDd2F862KPXt979eGtrQPX8IOj 6pJ23Vg7roMFGU5gCOLwt+3+/TKBz4L0snVJJHRH/1Jw9wxU41V4TGoE6GgYCiky1ARFqPN ijNZGwCBGINsSpBnf3ea8a2EhIrjl5r/B970jYU2IXJFG3GVoe5z2Pq+wgJuxTQ2ZWzyLyJ kasFS3X/apGQv91B2ZgbA== X-UI-Out-Filterresults: notjunk:1;V01:K0:IzvZNXg2dZI=:NHfKGGlKLMEi4ct7FNgYPU 35/K/8zh/Ttg9l7+nRBVlHfVusggWJ14d2/qJgUv5fuRRMq/yQdQV81A/qqGcW2YkwWZdO1pr P+5EfV90gt5ImQmJ84mqK8w+cD9PnkTkVic7r1cF9c/SbGJVW7d1CaJpgoVEuZrnbTCAv0v/c 0P0FR0ZT+ATNo4JzOqeYOZ6Z1iRYh+OIWlYYj6HzjFn4KIlGDn9yGvWjUBZAwyu+WYoJgaWtD q4FeMcqSUVjhXKbTweKgW4HiPbmlbkldZOH+PYy3ax8qA5x5NTBsGo4KThLv7It4Utid/UauE IpWRmbGwlYJloww8ZXDF/GwdSpmlGiLwSOOdTAyzynHCdouCauXBF3KaSKtk2xpWs1jGSn2kF Uv1XzSW9fk8zMBiONOb0cXUDYZg2E/ea/mNIdrzG7/LY2IBiXDJv5yEaYiF5m0yidfiLrErzi BLFDS5b7alufa4B+7/GV1gDDfskyMI2gdwnDl7aJGiMxSvJ71rNsg27Wk1nJA94/JMDcj8Dcu +Vj92XJgLQskSxIoTQs1DsgNxOqUHCh/XzHojNsONCtEcsYLQ+XO6sr7d/Uevvb+DpSNcG07+ Ec38TlGBjkinbhtnu56DBKkWEbHQ852JPRTtk+OI8nRWJnKUyEB7UWrKeKhRBb17FF/kYS+Ax DIcxAt9bsdUSXuPYgA+qCkFyQ6TP5LrB0tf3r/95ukNB4h9Ro4hond25l/ENGzuJWgJ9V8KaD WtH2MkEDkSF0WVdo Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 09 December 2015 19:17:42 Paul Gortmaker wrote: > [Re: [PATCH 0/6] drivers/dma: drop modular code from non modular drivers] On 10/12/2015 (Thu 00:29) Arnd Bergmann wrote: > > > On Wednesday 09 December 2015 18:21:56 Paul Gortmaker wrote: > > > This series of commits is a slice of a larger project to ensure > > > people don't have dead code for module removal in non-modular > > > drivers. Overall there is roughly 5k lines of dead code in the > > > kernel due to this. > > > > > > There is a quasi-separate theme, in that some of the drivers were > > > allowing an unbind implicitly since it is enabled by default. But > > > for core DMA infrastructure drivers, this doesn't seem useful -- so > > > we also disable that here which allows us to delete any ".remove" > > > functions from the drivers that would otherwise be called during the > > > (impossible to trigger) module removal. > > > > > > Since ARM covers these files the best of all architectures, each > > > file was build tested for allmodconfig on ARM, which at the same > > > time confirms that the files are not built with "CC [M]" -- hence > > > genuinely non-modular. > > > > > > My testing and the larger patch series in general has been done > > > against the latest linux-next tree. > > > > > > > > > > We are in the process of changing the DMA drivers to a new way of > > passing the "filter" function around. We can soon build them > > all as loadable modules again. > > Hi Arnd, > > Thanks for the feedback -- just to clarify, you are suggesting I hold > on the series until I see what emerges in the next merge window? > > It may take a few cycles, but I think we'll get there and should not remove the unload logic from any of these drivers. When we're done, there is no reason for a dmaengine driver to be built-in. Arnd