From: David Howells <dhowells@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: dhowells@redhat.com, George Law <glaw@redhat.com>,
Jeff Layton <jlayton@kernel.org>,
linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfs: Fix missing xas_retry() calls in xarray iteration
Date: Fri, 04 Nov 2022 15:34:25 +0000 [thread overview]
Message-ID: <931865.1667576065@warthog.procyon.org.uk> (raw)
In-Reply-To: <Y2SJw7w1IsIik3nb@casper.infradead.org>
Matthew Wilcox <willy@infradead.org> wrote:
> "unsigned int" assumes that the number of bytes isn't going to exceed 32
> bits. I tend to err on the side of safety here and use size_t.
Not unreasonable.
> > + pgpos = (folio_index(folio) - start_page) * PAGE_SIZE;
> > + pgend = pgpos + folio_size(folio);
>
> What happens if start_page is somewhere inside folio? Seems to me
> that pgend ends up overhanging into the next folio?
Yeah, I think my maths is dodgy. I should probably use folio_pos() and/or
offset_in_folio().
David
prev parent reply other threads:[~2022-11-04 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 21:33 [PATCH] netfs: Fix missing xas_retry() calls in xarray iteration David Howells
2022-11-04 3:40 ` Matthew Wilcox
2022-11-04 15:34 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=931865.1667576065@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=glaw@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox