From: Like Xu <like.xu@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, peterz@infradead.org,
Jim Mattson <jmattson@google.com>
Cc: rkrcmar@redhat.com, sean.j.christopherson@intel.com,
vkuznets@redhat.com, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
ak@linux.intel.com, wei.w.wang@intel.com, kan.liang@intel.com,
like.xu@intel.com, ehankland@google.com, arbel.moshe@oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] KVM: x86/vPMU: Reuse perf_event to avoid unnecessary pmc_reprogram_counter
Date: Mon, 21 Oct 2019 16:16:02 +0800 [thread overview]
Message-ID: <931ebe53-48c8-669d-72a6-9bd8da78b095@linux.intel.com> (raw)
In-Reply-To: <5020e826-e461-c28a-0b40-6e00aaa28163@redhat.com>
Hi Paolo,
On 2019/10/21 16:12, Paolo Bonzini wrote:
> Just a naming tweak:
>
> On 13/10/19 11:15, Like Xu wrote:
>> + /* the exact requested config to create perf_event */
>> + u64 programed_config;
>
> /*
> * eventsel value for general purpose counters, ctrl value for
> * fixed counters.
> */
> u64 current_config;
>
>
It looks good to me and I'll apply this.
Is there more need for improvement？
next prev parent reply other threads:[~2019-10-21 8:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 9:15 [PATCH v2 0/4] KVM: x86/vPMU: Efficiency optimization by reusing last created perf_event Like Xu
2019-10-13 9:15 ` [PATCH v2 1/4] perf/core: Provide a kernel-internal interface to recalibrate event period Like Xu
2019-10-13 9:15 ` [PATCH v2 2/4] perf/core: Provide a kernel-internal interface to pause perf_event Like Xu
2019-10-14 11:51 ` Peter Zijlstra
2019-10-15 1:47 ` Like Xu
2019-10-13 9:15 ` [PATCH v2 3/4] KVM: x86/vPMU: Reuse perf_event to avoid unnecessary pmc_reprogram_counter Like Xu
2019-10-21 8:12 ` Paolo Bonzini
2019-10-21 8:16 ` Like Xu [this message]
2019-10-13 9:15 ` [PATCH v2 4/4] KVM: x86/vPMU: Add lazy mechanism to release perf_event per vPMC Like Xu
2019-10-21 8:45 ` Paolo Bonzini
2019-10-21 14:04 ` Like Xu
2019-10-21 15:28 ` Paolo Bonzini
2019-10-21 10:55 ` [PATCH] KVM: x86/vPMU: Declare kvm_pmu->reprogram_pmi field using DECLARE_BITMAP Like Xu
2019-10-22 11:40 ` Paolo Bonzini
2019-10-21 2:26 ` [PATCH v2 0/4] KVM: x86/vPMU: Efficiency optimization by reusing last created perf_event Like Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=931ebe53-48c8-669d-72a6-9bd8da78b095@linux.intel.com \
--to=like.xu@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=arbel.moshe@oracle.com \
--cc=ehankland@google.com \
--cc=jmattson@google.com \
--cc=kan.liang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox