From: torvalds@transmeta.com (Linus Torvalds)
To: linux-kernel@vger.kernel.org
Subject: Re: exit.c -prerelease-diff - Jan 4
Date: 4 Jan 2001 10:20:12 -0800 [thread overview]
Message-ID: <932ess$ffm$1@penguin.transmeta.com> (raw)
In-Reply-To: <3A5468F0.AC7388AE@xmission.com>
In article <3A5468F0.AC7388AE@xmission.com>,
Frank Jacobberger <f1j@xmission.com> wrote:
>+ current->state = TASK_ZOMBIE;
>
>Why the update on exit.c to include TASK_ZOMBIE?
There's a subtle race in the exit path, where we need to make sure that
"wait4()" does not pick up the process before it is ready to be picked
up.
As the flag for "I'm ready to be picked up" is "TASK_ZOMBIE", we need to
make sure that it maintains serialization. Look at how "exit_code" is
used, for example - as it used to be, we didn't actually have any
guarantees that "exit_code" had even been _written_ yet when wait4()
started using it.
(That's the bug I _know_ about - there may be others here, because the
exit sequence is damn subtle sometimes. So the prerelease-diff fixes at
least that one thing, but I'm still trying checking all the other
exit-paths, things like __exit_mm()/mmput()/swap_out() etc)
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2001-01-04 18:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-04 12:13 exit.c -prerelease-diff - Jan 4 Frank Jacobberger
2001-01-04 18:20 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='932ess$ffm$1@penguin.transmeta.com' \
--to=torvalds@transmeta.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox