From: Johannes Berg <johannes@sipsolutions.net>
To: Yang Li <yang.lee@linux.alibaba.com>, jdike@addtoit.com
Cc: richard@nod.at, anton.ivanov@cambridgegreys.com,
linux-um@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] um: virt-pci: Fix the application of sizeof to pointer
Date: Fri, 03 Sep 2021 10:20:13 +0200 [thread overview]
Message-ID: <93705335a3e6dcdb56de601df566445aa5bcb28e.camel@sipsolutions.net> (raw)
In-Reply-To: <1630655468-71684-1-git-send-email-yang.lee@linux.alibaba.com>
On Fri, 2021-09-03 at 15:51 +0800, Yang Li wrote:
> sizeof() when applied to a pointer typed expression gives the size of
> the pointer.
>
> Clean up coccicheck warning:
> ./arch/um/drivers/virt-pci.c:192:20-26: ERROR: application of sizeof to
> pointer
>
> - memset(data, 0xff, sizeof(data));
> + memset(data, 0xff, sizeof(*data));
Oops. I guess I only tested on 64-bit where this is the same, and in
fact on 32-bit it also wouldn't matter since you can't even do 64-bit
reads there :)
A Fixes: tag would be nice, but otherwise
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
johannes
prev parent reply other threads:[~2021-09-03 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 7:51 [PATCH -next] um: virt-pci: Fix the application of sizeof to pointer Yang Li
2021-09-03 8:20 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93705335a3e6dcdb56de601df566445aa5bcb28e.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anton.ivanov@cambridgegreys.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox